dgfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 13 Mar 2023
5:06 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-14646 Correct inclusion of watchdog alarm. Remove alarm for checking for comm errors detected by the FPGA.

Options
    • -6
    • +0
    ./FPGA.c
    • -2
    • +1
    ./WatchdogMgmt.c
9:13 am

Sean Nash

DEBUG bread crumb comment?

DEBUG bread crumb comment?

9:12 am

Sean Nash

DEBUG bread crumb comment.

DEBUG bread crumb comment.

9:10 am

Sean Nash

Maybe we should put a bread crumb comment here to make it easier to find lines of code that need to be commented out when debugging (e.g. // comment this line for DEBUG).

Maybe we should put a bread crumb comment here to make it easier to find lines of code that need to be commented out when debugging (e.g. // comment this line for DEBUG).

9:06 am

Sean Nash

A small thing, but 24V Main should come before first voltage.

A small thing, but 24V Main should come before first voltage.

9:04 am

Sean Nash

Why is this indented?

Why is this indented?

9:02 am

Sean Nash

Is prefix guaranteed to not be zero?

Is prefix guaranteed to not be zero?

8:55 am

Sean Nash

Is it ok to ignore P if package has already been started? Should this ever happen?

Is it ok to ignore P if package has already been started? Should this ever happen?

8:54 am

Sean Nash

Use #define for bit mask. Remove extra ";".

Use #define for bit mask. Remove extra ";".

Friday 10 Mar 2023
1:44 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-14646 - Remove code inserted for debugging. Enable FPGA clock speed check and watchdog check.

Options
    • -38
    • +8
    ./FPGA.c
    • -2
    • +0
    ./WatchdogMgmt.c
  3. … 3 more files in changeset.
Wednesday 08 Mar 2023
6:53 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

6:52 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

6:33 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-14646 Use typedefs in voltages.c to improve debugging. Correct counting FPGA timeouts twice if write values ACK not received. Correct handling of emstat response status values.

Options
    • -20
    • +34
    ./FPGA.c
  2. … 2 more files in changeset.
4:53 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

4:53 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

3:44 pm

Michael Garthwaite

Merge branch 'DEN-14689-messaging-bugs' into develop

Options
    • -30
    • +45
    ./Reservoirs.c
    • -12
    • +2
    ./Reservoirs.h
    • -17
    • +17
    ./SystemComm.c
    • -2
    • +2
    ./SystemCommMessages.c
  5. … 3 more files in changeset.
3:43 pm

Michael Garthwaite

DEN-14689: sync msg_ids with msgdefs.h

Options
    • -1
    • +1
    ./AlarmMgmt.c
    • -16
    • +20
    ./SystemComm.c
    • -2
    • +2
    ./SystemCommMessages.c
  4. … 1 more file in changeset.
Tuesday 07 Mar 2023
3:03 pm

Dara Navaei

Merge branch 'staging' into DEN-14763-dg_hd_dev-hd_dg_dvt-update-part-10

Options
    • -30
    • +45
    ./Reservoirs.c
    • -12
    • +2
    ./Reservoirs.h
  3. … 5 more files in changeset.
11:34 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Reservoirs.c
    • -1
    • +1
    ./Reservoirs.h
  3. … 6 more files in changeset.
11:32 am

Dara Navaei

11:28 am

wbracken  (deleted user) and Sean Nash

11:19 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:18 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:16 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:16 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:15 am

Dara Navaei

In common.h to be used by both stacks.

In common.h to be used by both stacks.

11:15 am

Sean Nash

Where did this go?

Where did this go?

11:06 am

Dara Navaei

DEN-14834 updated the code to just send the heater command in Idle and Drain if the primary heater is not on. Addressed the code review comments

Options
    • -4
    • +4
    ./Reservoirs.c
    • -10
    • +0
    ./Reservoirs.h
  3. … 3 more files in changeset.
11:05 am

Dara Navaei

Done.

Done.

11:04 am

Dara Navaei

Done.

Done.