Activity dgfirmware/firmware/App/Services

11:29 am

Michael Garthwaite

More
a45a2f0
changed 3 files
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 75 more DG-DIAL-280-1

Merge branch 'staging' into DIAL-280-reservoir-broadcast-override

- -1
- +50
./SystemComm.c
- History
- Source
- Diff
./SystemComm.c
- -0
- +32
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
- -0
- +3
./SystemCommMessages.h
- History
- Source
- Diff
./SystemCommMessages.h

11:27 am

Sean Nash

More
DG-DIAL-280-1
resumed reviewing

11:27 am

Michael Garthwaite

More
DG-DEN-14706-1
Closed

11:24 am

wbracken (deleted user) and Sean Nash

More
DG-DEN-14706-1
finished reviewing

11:10 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

9:49 am

jtaylor (deleted user)

More
Re: DG-DEN-14706-1
commented on review

Suggest aligning comments in the block above

9:04 am

Vinayakam Mani

More
2b2cf77
changed 3 files
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 70 more DG-DEN-16093-1

DEN-16093-added DG park concentrate pumps

- -0
- +4
./SystemComm.c
- History
- Source
- Diff
./SystemComm.c
- -0
- +31
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
- -0
- +3
./SystemCommMessages.h
- History
- Source
- Diff
./SystemCommMessages.h

1:50 pm

Dara Navaei

More
b766ff8
changed 3 files
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 75 more DG-DEN-16093-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
./WatchdogMgmt.c
- History
- Source
- Diff
./WatchdogMgmt.c
… 2 more files in changeset.

1:49 pm

Dara Navaei

More
DG-DEN-16250-1
Closed

1:48 pm

Sean Nash and wbracken (deleted user)

More
DG-DEN-16250-1
finished reviewing

1:39 pm

Dara Navaei

More
e5e7a37
changed 2 files
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 76 more DG-DEN-16250-1

DEN-16250 removed the voltage check code

- -4
- +4
./WatchdogMgmt.c
- History
- Source
- Diff
./WatchdogMgmt.c
… 1 more file in changeset.

1:34 pm

Sean Nash

More
6939919
changed 1 file
develop

Merge branch 'DENBUG-59-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow' into develop

- -1
- +1
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c

1:26 pm

Sean Nash

More
0120c29
changed 1 file
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 74 more DG-DENBUG-59-1

DENBUG-59: Fix alarm trigger msg payload length.

- -1
- +1
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c

12:37 pm

Michael Garthwaite

More
ad186fe
changed 1 file
DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 76 more DG-DEN-14706-1 DG-DIAL-280-1

DEN-14706: removed #define

- -1
- +0
./SystemComm.c
- History
- Source
- Diff
./SystemComm.c

12:35 pm

Michael Garthwaite

More
Re: DG-DEN-14706-1
replied to Sean Nash

Removed #define. Thanks!

11:26 am

Dara Navaei

More
48fa4e3
changed 2 files
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 76 more DG-DEN-16250-1

DEN-16250 updated the voltages in the watchdog and safety shutdown

- -6
- +7
./WatchdogMgmt.c
- History
- Source
- Diff
./WatchdogMgmt.c
… 1 more file in changeset.

11:04 am

Sean Nash

More
Re: DG-DEN-14706-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

11:02 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

11:02 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

10:47 am

Michael Garthwaite

More
507e340
changed 2 files
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 75 more DG-DIAL-280-1

DIAL-280: code review comments.

- -0
- +1
./Reservoirs.c
- History
- Source
- Diff
./Reservoirs.c
- -0
- +1
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c

10:45 am

Michael Garthwaite

More
Re: DG-DIAL-280-1
replied to Sean Nash

Fixed. Thanks!

10:45 am

Michael Garthwaite

More
Re: DG-DIAL-280-1
replied to Sean Nash

Fixed. Thanks!

10:42 am

Michael Garthwaite

More
64f53d7
changed 1 file
DEN-14706-can-messge-not-acked-fix, DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked and 76 more DG-DEN-14706-1

DEN-14706: changed override condition for pending ack

- -2
- +1
./SystemComm.c
- History
- Source
- Diff
./SystemComm.c

10:36 am

Sean Nash

More
Re: DG-DIAL-280-1
commented on review

Add blank line between functions.

10:35 am

Sean Nash

More
Re: DG-DIAL-280-1
commented on review

Add blank line between banner comment and prototype.

10:35 am

Dara Navaei

More
d52eeae
changed 2 files
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 76 more DG-DEN-16250-1

DEN-16250 fixed the logic in the voltages check in watchdog and safety shutdown

- -2
- +2
./WatchdogMgmt.c
- History
- Source
- Diff
./WatchdogMgmt.c
… 1 more file in changeset.

10:25 am

Dara Navaei

More
3115c2c
changed 2 files
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 76 more DG-DEN-16250-1

DEN-16250 added the isolated voltage to the watchdog and safety shutdown POSTs

- -4
- +6
./WatchdogMgmt.c
- History
- Source
- Diff
./WatchdogMgmt.c
… 1 more file in changeset.

10:13 am

Sean Nash

More
Re: DG-DEN-14706-1
commented on review

I think override should be OR'd with timeout only. The used condition should still have to be true even if override is in place.

9:58 am

Sean Nash

More
Re: DG-DEN-14706-1
replied to jtaylor (deleted user)

I don't see where this #define is ever used. Remove if not needed.

8:16 pm

Michael Garthwaite

More
4375a41
changed 5 files
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 75 more DG-DIAL-280-1

DIAL-280: Reservoir broadcast interval override.

- -21
- +85
./Reservoirs.c
- History
- Source
- Diff
./Reservoirs.c
- -1
- +3
./Reservoirs.h
- History
- Source
- Diff
./Reservoirs.h
- -0
- +4
./SystemComm.c
- History
- Source
- Diff
./SystemComm.c
- -0
- +31
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
- -0
- +3
./SystemCommMessages.h
- History
- Source
- Diff
./SystemCommMessages.h

Services

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Michael Garthwaite

Sean Nash

Michael Garthwaite

wbracken (deleted user) and Sean Nash

Sean Nash

jtaylor (deleted user)

Vinayakam Mani

Dara Navaei

Dara Navaei

Sean Nash and wbracken (deleted user)

Dara Navaei

Sean Nash

Sean Nash

Michael Garthwaite

Michael Garthwaite

Dara Navaei

Sean Nash

Sean Nash

Sean Nash

Michael Garthwaite

Michael Garthwaite

Michael Garthwaite

Michael Garthwaite

Sean Nash

Sean Nash

Dara Navaei

Dara Navaei

Sean Nash

Sean Nash

Michael Garthwaite