dgfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 30 Aug 2023
2:26 pm

Michael Garthwaite

12:28 pm

wbracken  (deleted user) and jtaylor  (deleted user)

Tuesday 29 Aug 2023
5:01 pm

Dara Navaei

2:07 pm

Dara Navaei

DG-DEN-15791_DG Software Design Description
DG-DEN-15791_DG Software Design Description
12:32 pm

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:37 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:30 am

Dara Navaei

Please add _MS to be consistent with the reset of times which are all in milliseconds.

Please add _MS to be consistent with the reset of times which are all in milliseconds.

9:03 am

jtaylor  (deleted user)

Monday 28 Aug 2023
2:25 pm

wbracken  (deleted user) and Sean Nash

2:06 pm

Dara Navaei

DG-DIAL-281_Requesting Heat Disinfect Timer Overrides
DG-DIAL-281_Requesting Heat Disinfect Timer Overrides
10:16 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:16 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Friday 25 Aug 2023
3:03 pm

Vinayakam Mani

Done.

Done.

3:03 pm

Vinayakam Mani

Done.

Done.

2:27 pm

Sean Nash

Lets add a comment here that "we are insisting conductivity reach 100% of expected level since signal is very noisy and peak noise will reach 100% when average is about 93%. if sensor noise is redu...

Lets add a comment here that "we are insisting conductivity reach 100% of expected level since signal is very noisy and peak noise will reach 100% when average is about 93%. if sensor noise is reduced, this level should also be reduced accordingly."

2:24 pm

Sean Nash

100% now.

100% now.

12:45 pm

Sean Nash

Thursday 24 Aug 2023
3:41 pm

Dara Navaei

2:09 pm

wbracken  (deleted user) and jtaylor  (deleted user)

12:57 pm

Dara Navaei

12:46 pm

wbracken  (deleted user) and Sean Nash

9:58 am

Dara Navaei

DG-DEN-16308_Srsdg 53 Not Met
DG-DEN-16308_Srsdg 53 Not Met
Tuesday 22 Aug 2023
11:04 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:56 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:07 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:58 am

Sean Nash

Add a blank line between declarations and code.

Add a blank line between declarations and code.

9:57 am

Sean Nash

#includes are sorted. Put OperationModes.h in its proper place.

#includes are sorted. Put OperationModes.h in its proper place.

Monday 21 Aug 2023
6:05 pm

Vinayakam Mani

required changes are done.

required changes are done.

2:54 pm

Michael Garthwaite

1:55 pm

Sean Nash

Consider calling a (new) function in ConcentratePumps.c that would do all of this (decides whether to accept or reject command and parks the pumps if accepting, sets reject reason code if rejecting...

Consider calling a (new) function in ConcentratePumps.c that would do all of this (decides whether to accept or reject command and parks the pumps if accepting, sets reject reason code if rejecting). Function would also create and send the cmd response message and return TRUE/FALSE which would set local result here for the ack response message below.
We should reject cmd if pumps are busy/on and/or if current DG mode is fill or fault mode.