dgfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 01 Sep 2023
10:01 am

Michael Garthwaite

DEN-14706: code review comments.

Options
    • -7
    • +2
    ./SystemComm.c
Thursday 31 Aug 2023
2:37 pm

Sean Nash

This if doesn't appear to be doing anything. Remove.

This if doesn't appear to be doing anything. Remove.

2:36 pm

Sean Nash

This should be inverse of what you had before. I think this is too brief.

This should be inverse of what you had before. I think this is too brief.

2:12 pm

Michael Garthwaite

DEN-14706: wip of code review comments.

Options
    • -9
    • +9
    ./SystemComm.c
2:11 pm

Michael Garthwaite

Pushed wip code. I'm unsure what or if we need to put anything to compare override values.

Pushed wip code. I'm unsure what or if we need to put anything to compare override values.

2:11 pm

Dara Navaei

2:11 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:10 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

12:45 pm

Sean Nash

Too many () after &&?

Too many () after &&?

12:44 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

12:44 pm

Sean Nash

Already TRUE - why set again? I think "if" should be reversed - if not override, set used to FALSE. And then after if, always set result to TRUE (means we found a match - which we did).

Already TRUE - why set again?
I think "if" should be reversed - if not override, set used to FALSE. And then after if, always set result to TRUE (means we found a match - which we did).

12:30 pm

Michael Garthwaite

DEN-14706: Fixed DG pending ack override.

Options
    • -5
    • +18
    ./SystemComm.c
12:18 pm

Dara Navaei

DG-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
DG-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
Wednesday 30 Aug 2023
3:48 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./SystemComm.c
    • -2
    • +2
    ./SystemCommMessages.c
    • -2
    • +2
    ./SystemCommMessages.h
  4. … 3 more files in changeset.
3:25 pm

Vinayakam Mani

DEN-16093 changes merge in to staging

Options
    • -0
    • +4
    ./SystemComm.c
    • -0
    • +21
    ./SystemCommMessages.c
    • -0
    • +3
    ./SystemCommMessages.h
2:48 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./SystemComm.c
    • -2
    • +2
    ./SystemCommMessages.c
    • -1
    • +1
    ./SystemCommMessages.h
  4. … 2 more files in changeset.
2:26 pm

Michael Garthwaite

12:28 pm

wbracken  (deleted user) and jtaylor  (deleted user)

Tuesday 29 Aug 2023
5:01 pm

Dara Navaei

2:07 pm

Dara Navaei

DG-DEN-15791_DG Software Design Description
DG-DEN-15791_DG Software Design Description
1:28 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment' into develop

# Conflicts:

# firmware/App/DGCommon.h

Options
    • -2
    • +2
    ./SystemComm.c
    • -2
    • +2
    ./SystemCommMessages.c
  3. … 1 more file in changeset.
12:35 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'staging' into DEN-15979-fw-investigate-dg-rtc-synchronization-failure

Options
    • -17
    • +173
    ./SystemCommMessages.c
12:32 pm

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:37 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:30 am

Dara Navaei

Please add _MS to be consistent with the reset of times which are all in milliseconds.

Please add _MS to be consistent with the reset of times which are all in milliseconds.

9:56 am

Michael Garthwaite

Merge branch 'DIAL-281-requesting-heat-disinfect-timer-overrides' into develop

Options
    • -0
    • +8
    ./SystemComm.c
    • -0
    • +64
    ./SystemCommMessages.c
    • -1
    • +7
    ./SystemCommMessages.h
9:34 am

Michael Garthwaite

DIAL-278: implementation of heat disinfection state timer overrides.

Options
    • -0
    • +8
    ./SystemComm.c
    • -0
    • +64
    ./SystemCommMessages.c
    • -1
    • +7
    ./SystemCommMessages.h
  4. … 2 more files in changeset.
9:03 am

jtaylor  (deleted user)

Monday 28 Aug 2023
2:25 pm

wbracken  (deleted user) and Sean Nash

2:06 pm

Dara Navaei

DG-DIAL-281_Requesting Heat Disinfect Timer Overrides
DG-DIAL-281_Requesting Heat Disinfect Timer Overrides