dgfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 08 Sep 2023
2:18 pm

James Walter Taylor <jtaylor@diality.com>

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Modification to test DG comm issues.

Options
    • -0
    • +3
    ./Reservoirs.h
2:15 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:28 pm

jtaylor  (deleted user)

Done.

Done.

1:19 pm

Sean Nash

Add blank line between this code and switch below.

Add blank line between this code and switch below.

11:03 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:51 am

jtaylor  (deleted user)

These fields have been moved to a different broadcast at some point, and were no longer being set by the reservoir data broadcast. The fields regularly contained "NAN" values, so I removed them.

These fields have been moved to a different broadcast at some point, and were no longer being set by the reservoir data broadcast. The fields regularly contained "NAN" values, so I removed them.

9:13 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:06 am

Dara Navaei

Why are these fields removed?

Why are these fields removed?

Thursday 07 Sep 2023
3:35 pm

jtaylor  (deleted user)

Done. Code updates pushed.

Done. Code updates pushed.

3:27 pm

James Walter Taylor <jtaylor@diality.com>

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

fill time allowance for time spent in pause state

Cleared fill timer on transition to generate

Added removed unused (and uninitialized) variables from broadcast data structure.

Options
    • -3
    • +0
    ./Reservoirs.h
  2. … 1 more file in changeset.
1:47 pm

Sean Nash

I don't see these being used anywhere.

I don't see these being used anywhere.

Wednesday 06 Sep 2023
1:45 pm

Dara Navaei

Merged DEN-16323

Options
    • -6
    • +14
    ./SystemComm.c
    • -2
    • +2
    ./SystemCommMessages.c
    • -2
    • +2
    ./SystemCommMessages.h
  4. … 5 more files in changeset.
7:40 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./SystemComm.c
7:38 am

Michael Garthwaite

Tuesday 05 Sep 2023
11:43 am

Sean Nash , jtaylor  (deleted user) and wbracken  (deleted user)

10:06 am

jtaylor  (deleted user)

Is the "0" an ACK,NACK, PENDING_OVERRIDE or some other flag? Suggest a #define. (or a comment)

Is the "0" an ACK,NACK, PENDING_OVERRIDE or some other flag? Suggest a #define. (or a comment)

10:06 am

jtaylor  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:05 am

Michael Garthwaite

We typically dont #define for 0. However, the logic has been reworked that we no longer need to compare by 0.

We typically dont #define for 0. However, the logic has been reworked that we no longer need to compare by 0.

8:11 am

Michael Garthwaite

DEN-14706: fixed compiler errors

Options
    • -3
    • +3
    ./SystemComm.c
Friday 01 Sep 2023
4:58 pm

Vinayakam Mani

4:38 pm

James Walter Taylor <jtaylor@diality.com>

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Initial changes for alarm 206 timer

Options
    • -1
    • +1
    ./Reservoirs.c
  2. … 1 more file in changeset.
4:14 pm

Dara Navaei

DG-DEN-16314_Alarm 206 Triggers After Resuming From Incoming Water Conductivity High OR Low
DG-DEN-16314_Alarm 206 Triggers After Resuming From Incoming Water Conductivity High OR Low
11:19 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:19 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:19 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:19 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:18 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:01 am

Michael Garthwaite

DEN-14706: code review comments.

Options
    • -7
    • +2
    ./SystemComm.c
Thursday 31 Aug 2023
2:37 pm

Sean Nash

This if doesn't appear to be doing anything. Remove.

This if doesn't appear to be doing anything. Remove.

2:36 pm

Sean Nash

This should be inverse of what you had before. I think this is too brief.

This should be inverse of what you had before. I think this is too brief.