Services

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'DEN-16475-please-add-average-tdi-tro-delta' into develop

sizeof should be first in if

sizeof should be first in if

DEN-16446 updated the code for VectorCAST

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Should this have a set of parenthesis around the condition similar to line 437?

Should this have a set of parenthesis around the condition similar to line 437?

Resolved in code review.

Resolved in code review.

Merge branch 'DEN-16372-srsdg-907-not-met' into develop

DEN-16372: Turn off trimmer heater if HD communication is lost.

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

Fixed.

Fixed.

DEN-16372: fixed typo - wrong alarm triggered for watchdog expired.

Did this alarm change to HD?

Did this alarm change to HD?

DEN-16372: Matched watchdog expired alarm to requirement.

DG-DEN-16372_Srsdg 907 Not Met
DG-DEN-16372_Srsdg 907 Not Met
In the condition in line 437 we do a subtraction prior to comparing so there are extra parentheses in line 437.

In the condition in line 437 we do a subtraction prior to comparing so there are extra parentheses in line 437.

DEN-16395 fix merge issues

  1. … 3 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 9 more files in changeset.
Merge branch 'DEN-15791-dg-software-design-description' into develop

  1. … 6 more files in changeset.
Merged staging to DEN-15791.

  1. … 5 more files in changeset.
The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH. (with nausea)

RESOLVED in CODE WALKTHROUGH. (with nausea)

But if VECTORCAST is defined there is no default clause. I'm suggesting: ... default: #ifndef VECTORCAST heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER; #endif break;

But if VECTORCAST is defined there is no default clause. I'm suggesting:
...
default:
#ifndef VECTORCAST
heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER;
#endif
break;

Done

Done

This code is the theoretical code for treatment recovery. At the moment this code is not reachable neither in the firmware or VectorCAST.

This code is the theoretical code for treatment recovery. At the moment this code is not reachable neither in the firmware or VectorCAST.