dgfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 09 Oct 2023
8:04 am

Michael Garthwaite

Merge branch 'DEN-16475-please-add-average-tdi-tro-delta' into develop

Options
    • -2
    • +2
    ./SystemComm.c
Sunday 08 Oct 2023
5:55 pm

wbracken  (deleted user)

sizeof should be first in if

sizeof should be first in if

10:49 am

Dara Navaei

DEN-16446 updated the code for VectorCAST

Options
    • -1
    • +1
    ./SystemCommMessages.c
Friday 06 Oct 2023
12:10 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./SystemComm.c
    • -2
    • +2
    ./WatchdogMgmt.c
11:32 am

Sean Nash

10:41 am

wbracken  (deleted user) and Dara Navaei

10:19 am

wbracken  (deleted user)

Should this have a set of parenthesis around the condition similar to line 437?

Should this have a set of parenthesis around the condition similar to line 437?

10:18 am

wbracken  (deleted user)

Resolved in code review.

Resolved in code review.

Thursday 05 Oct 2023
10:43 am

jtaylor  (deleted user)

9:55 am

Sean Nash

Merge branch 'DEN-16372-srsdg-907-not-met' into develop

Options
    • -4
    • +6
    ./SystemComm.c
8:26 am

Sean Nash

DEN-16372: Turn off trimmer heater if HD communication is lost.

Options
    • -4
    • +6
    ./SystemComm.c
Wednesday 04 Oct 2023
8:56 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

8:55 am

Sean Nash

Fixed.

Fixed.

8:54 am

Sean Nash

DEN-16372: fixed typo - wrong alarm triggered for watchdog expired.

Options
    • -1
    • +1
    ./WatchdogMgmt.c
8:41 am

Dara Navaei

Did this alarm change to HD?

Did this alarm change to HD?

Tuesday 03 Oct 2023
3:00 pm

Sean Nash

DEN-16372: Matched watchdog expired alarm to requirement.

Options
    • -11
    • +21
    ./WatchdogMgmt.c
2:39 pm

Dara Navaei

DG-DEN-16372_Srsdg 907 Not Met
DG-DEN-16372_Srsdg 907 Not Met
2:33 pm

Dara Navaei

In the condition in line 437 we do a subtraction prior to comparing so there are extra parentheses in line 437.

In the condition in line 437 we do a subtraction prior to comparing so there are extra parentheses in line 437.

11:46 am

Vinayakam Mani

DEN-16395 fix merge issues

Options
    • -2
    • +2
    ./SystemCommMessages.c
    • -2
    • +2
    ./SystemCommMessages.h
  3. … 3 more files in changeset.
Sunday 01 Oct 2023
4:15 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Saturday 30 Sep 2023
1:05 pm

Dara Navaei

1:03 pm

Dara Navaei and jtaylor  (deleted user)

1:02 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./AlarmMgmt.c
    • -2
    • +2
    ./Reservoirs.c
    • -2
    • +2
    ./SystemCommMessages.c
    • -2
    • +2
    ./SystemCommMessages.h
  5. … 9 more files in changeset.
12:33 pm

Sean Nash

Merge branch 'DEN-15791-dg-software-design-description' into develop

Options
    • -2
    • +2
    ./Reservoirs.c
    • -5
    • +5
    ./SystemCommMessages.c
    • -6
    • +0
    ./SystemCommMessages.h
  4. … 6 more files in changeset.
11:41 am

Sean Nash

Merged staging to DEN-15791.

Options
    • -3
    • +3
    ./Reservoirs.c
    • -2
    • +118
    ./SystemCommMessages.c
    • -2
    • +14
    ./SystemCommMessages.h
  4. … 5 more files in changeset.
Friday 29 Sep 2023
11:16 am

jtaylor  (deleted user)

The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

11:14 am

jtaylor  (deleted user)

RESOLVED in CODE WALKTHROUGH. (with nausea)

RESOLVED in CODE WALKTHROUGH. (with nausea)

11:11 am

jtaylor  (deleted user)

But if VECTORCAST is defined there is no default clause. I'm suggesting: ... default: #ifndef VECTORCAST heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER; #endif break;

But if VECTORCAST is defined there is no default clause. I'm suggesting:
...
default:
#ifndef VECTORCAST
heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER;
#endif
break;

Thursday 28 Sep 2023
8:56 am

Dara Navaei

Done

Done

8:33 am

Dara Navaei

This code is the theoretical code for treatment recovery. At the moment this code is not reachable neither in the firmware or VectorCAST.

This code is the theoretical code for treatment recovery. At the moment this code is not reachable neither in the firmware or VectorCAST.