Services

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-17053 updated the code from staging

  1. … 8 more files in changeset.
DEN-17047 removed the UV reactors code from the firmware

  1. … 14 more files in changeset.
DG-DEN-17047_Remove UV Reactors From Code Bases
DG-DEN-17047_Remove UV Reactors From Code Bases
Merged staging

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 4 more files in changeset.
Merge branch 'DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging' into develop

  1. … 1 more file in changeset.
DEN-16680 updated the start/stop heat disinfect code

  1. … 2 more files in changeset.
Merge branch 'DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging' into develop

DEN-16680 updated the heat disinfect mode with the latest changes on the passive active cool heat disinfect

  1. … 2 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Merge branch 'DEN-16680-p1b-inlet-water-shutdown-during-heat-disinfect-staging' into develop

DEN-16680 addressed the code review comments

  1. … 1 more file in changeset.
Added an event.

Added an event.

Done

Done

Removed the one in else.

Removed the one in else.

Is this necessary in else? If so, can move above or below the if so you just do it once.

Is this necessary in else? If so, can move above or below the if so you just do it once.

This flag is really indicating drain water is not too hot OR we are not doing a nocturnal heat disinfect. Flag name could be better.

This flag is really indicating drain water is not too hot OR we are not doing a nocturnal heat disinfect. Flag name could be better.

This could just be an event at start.

This could just be an event at start.

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

Thanks I meant medium priority. Changed the rank to 500.

Thanks I meant medium priority. Changed the rank to 500.

If it does not come down below 60 and in the cool idle cycle if any issue occurs, the DG Software transitions to the cancel basic path.

If it does not come down below 60 and in the cool idle cycle if any issue occurs, the DG Software transitions to the cancel basic path.

Removed \n

Removed \n

Will there be any worst-case scenario that the temperature never come down (say below 60) and get into a cyclic loop between cancel path and cool idle state?

Will there be any worst-case scenario that the temperature never come down (say below 60) and get into a cyclic loop between cancel path and cool idle state?