Services

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DENBUG-318 added code to keep requesting DG institutional values once start DG has been sent until the values are received

  1. … 3 more files in changeset.
Should we have before and after values in event data?

Should we have before and after values in event data?

Merged DENBUG-318

DENBUG-318 changed the max RO rejection ratio to min RO rejection ratio in percent and updated the mode fill calculations to check the RR

  1. … 2 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Removed. UI is updated too.

Removed. UI is updated too.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Merged DENBUG-318

  1. … 2 more files in changeset.
DENBUG-318 updated the code to receive all the DG institutional record items. Added code to use the min inlet water conductivity alarm from the institutional record

  1. … 4 more files in changeset.
DENBUG-319 added code to receive a command from dialing to enable the mode fill chemicals test

  1. … 3 more files in changeset.
Done

Done

It is an input - don't remove flag there. It is not an output - so remove it there.

It is an input - don't remove flag there. It is not an output - so remove it there.

Done

Done

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DENBUG-320 brought back the start fill command after removing alarms 281, 282

I don't see the flag being set in this function.

I don't see the flag being set in this function.

Why are we keeping these in the broadcast?

Why are we keeping these in the broadcast?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Resolved merge conflicts from DENBUG-318

  1. … 2 more files in changeset.
DENBUG-318 added the word max to the RO rejection ratio

  1. … 1 more file in changeset.
DENBUG-320 added the word max to the RO rejection ratio

  1. … 2 more files in changeset.
Done

Done

Done

Done

DENBUG-320 removed the code that checked for the acid and bicarb low volume and triggered alarms

  1. … 5 more files in changeset.
Should you do something with the received max ratio? It's local, so it's just being dropped.

Should you do something with the received max ratio? It's local, so it's just being dropped.

max ratio

max ratio

DENBUG-318 added code to request and receive the RO rejection ratio from the HD institutional record and apply it in the mode fill

  1. … 2 more files in changeset.
DG-DENBUG-318_Rejection Ratio Setting Feature Implementation IN Manufacturing Configuration For Treatment Staging
DG-DENBUG-318_Rejection Ratio Setting Feature Implementation IN Manufacturing Configuration For Treatment Staging
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 5 more files in changeset.
Merged release/p1b/staging

  1. … 5 more files in changeset.