Activity dgfirmware/firmware/App/Services

Tree
Accordion

Stats

Commits this week: 2

Total Committers:	17
Last Commit:	10 Jun
Commits this week:	2

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Thursday 12 Jun 2025

3:01 pm

Dara Navaei

More
e52fb9e
changed 13 files
DEN-17298-release_22_vc-staging, DENBUG-327-baro-sensor-data-refresh-staging and 3 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
./AlarmMgmtSWFaults.h
- History
- Source
- Diff
./AlarmMgmtSWFaults.h
- -1
- +1
./Reservoirs.c
- History
- Source
- Diff
./Reservoirs.c
- -1
- +1
./SystemComm.c
- History
- Source
- Diff
./SystemComm.c
- -1
- +1
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
- -1
- +1
./SystemCommMessages.h
- History
- Source
- Diff
./SystemCommMessages.h
… 8 more files in changeset.

3:01 pm

Dara Navaei

More
DG-DENBUG-318-1
Closed

Monday 09 Jun 2025

9:33 am

Michael Garthwaite

More
DG-DENBUG-318-1
finished reviewing

Thursday 05 Jun 2025

4:20 pm

Sean Nash

More
DG-DENBUG-318-1
finished reviewing

4:19 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:17 pm

Dara Navaei

More
Re: DG-DENBUG-318-1
replied to Sean Nash

Done

Done

10:01 am

Sean Nash

More
Re: DG-DENBUG-318-1
commented on review

hd mode should be >= standby mode. You have it backward.

hd mode should be >= standby mode. You have it backward.

10:00 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:20 am

Dara Navaei

More
Re: DG-DENBUG-318-1
replied to Sean Nash

Done.

Done.

Wednesday 04 Jun 2025

2:23 pm

Dara Navaei

More
bcafee3
changed 1 file
develop

Merge branch 'DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging' into develop

- -0
- +1
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c

2:23 pm

Dara Navaei

More
68f28bf
changed 2 files
DEN-17298-release_22_vc-staging, DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging and 4 more DG-DENBUG-318-1

DENBUG-318 added code to request the DG institutional values in mode standby until they are received

- -0
- +1
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
… 1 more file in changeset.

1:19 pm

Dara Navaei

More
6727e2e
changed 2 files
develop

Merge branch 'DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging' into develop

- -1
- +1
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
… 1 more file in changeset.

1:17 pm

Dara Navaei

More
80a1b60
changed 4 files
DEN-17298-release_22_vc-staging, DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging and 4 more DG-DENBUG-318-1

DENBUG-318 added code to keep requesting DG institutional values once start DG has been sent until the values are received

- -1
- +1
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
… 3 more files in changeset.

Thursday 29 May 2025

3:41 pm

Sean Nash

More
Re: DG-DENBUG-318-1
commented on review

Should we have before and after values in event data?

Should we have before and after values in event data?

Tuesday 27 May 2025

5:37 pm

Dara Navaei

More
6215388
changed 1 file
develop

Merged DENBUG-318

- -1
- +1
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c

5:33 pm

Dara Navaei

More
df09fff
changed 3 files
DEN-17298-release_22_vc-staging, DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging and 4 more DG-DENBUG-318-1

DENBUG-318 changed the max RO rejection ratio to min RO rejection ratio in percent and updated the mode fill calculations to check the RR

- -1
- +1
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
… 2 more files in changeset.

9:14 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:13 am

Dara Navaei

More
Re: DG-DENBUG-318-1
replied to Sean Nash

Removed. UI is updated too.

Removed. UI is updated too.

9:08 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Friday 23 May 2025

10:03 am

Dara Navaei

More
255e101
changed 5 files
develop

Merged DENBUG-318

- -2
- +6
./SystemComm.c
- History
- Source
- Diff
./SystemComm.c
- -11
- +35
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
- -4
- +7
./SystemCommMessages.h
- History
- Source
- Diff
./SystemCommMessages.h
… 2 more files in changeset.

9:49 am

Dara Navaei

More
caa8c39
changed 7 files
DEN-17298-release_22_vc-staging, DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging and 4 more DG-DENBUG-318-1

DENBUG-318 updated the code to receive all the DG institutional record items. Added code to use the min inlet water conductivity alarm from the institutional record

- -2
- +2
./SystemComm.c
- History
- Source
- Diff
./SystemComm.c
- -11
- +12
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
- -4
- +4
./SystemCommMessages.h
- History
- Source
- Diff
./SystemCommMessages.h
… 4 more files in changeset.

Thursday 22 May 2025

4:27 pm

Dara Navaei

More
27792ea
changed 6 files
DEN-17298-release_22_vc-staging, DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging and 4 more DG-DENBUG-318-1

DENBUG-319 added code to receive a command from dialing to enable the mode fill chemicals test

- -0
- +4
./SystemComm.c
- History
- Source
- Diff
./SystemComm.c
- -0
- +23
./SystemCommMessages.c
- History
- Source
- Diff
./SystemCommMessages.c
- -0
- +3
./SystemCommMessages.h
- History
- Source
- Diff
./SystemCommMessages.h
… 3 more files in changeset.

1:35 pm

Dara Navaei

More
Re: DG-DENBUG-318-1
replied to Sean Nash

Done

Done

12:54 pm

Sean Nash

It is an input - don't remove flag there. It is not an output - so remove it there.

It is an input - don't remove flag there. It is not an output - so remove it there.

Wednesday 21 May 2025

3:28 pm

Dara Navaei

More
Re: DG-DENBUG-318-1
replied to Sean Nash

Done

Done

9:03 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:00 am

Dara Navaei

More
21a5c70
changed 1 file
DEN-17298-release_22_vc-staging, DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging and 4 more DG-DENBUG-318-1

DENBUG-320 brought back the start fill command after removing alarms 281, 282

- -0
- +2
./Reservoirs.c
- History
- Source
- Diff
./Reservoirs.c

8:59 am

Sean Nash

More
Re: DG-DENBUG-318-1
commented on review

I don't see the flag being set in this function.

I don't see the flag being set in this function.

8:55 am

Sean Nash

More
Re: DG-DENBUG-318-1
commented on review

Why are we keeping these in the broadcast?

Why are we keeping these in the broadcast?

8:53 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-06-11 12:13 -0700