dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 02 Mar 2022
3:03 pm

Dara Navaei

DEN-11750 addressed the code review comments

Options
    • -6
    • +7
    ./Controllers/Fans.c
3:02 pm

Dara Navaei

Done.

Done.

2:27 pm

Dara Navaei

DEN-11750 addressed the code review comments

Options
    • -10
    • +10
    ./Controllers/TemperatureSensors.c
1:29 pm

Dara Navaei

DEN-11750 addressed the code review comments

Options
    • -1
    • +2
    ./Controllers/ConductivitySensors.c
    • -15
    • +4
    ./Controllers/UVReactors.c
    • -1
    • +6
    ./Services/AlarmMgmt.c
    • -1
    • +1
    ./Services/AlarmMgmt.h
    • -7
    • +10
    ./Services/SystemCommMessages.c
1:22 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Updated code per peer review comments

Options
    • -1
    • +1
    ./Controllers/ConcentratePumps.h
    • -5
    • +15
    ./Controllers/ConductivitySensors.c
    • -0
    • +1
    ./Controllers/ConductivitySensors.h
    • -16
    • +27
    ./Controllers/TemperatureSensors.c
    • -19
    • +24
    ./Modes/ModeFill.c
1:13 pm

Dara Navaei

I brought the BOOL back.

I brought the BOOL back.

1:10 pm

Dara Navaei

Done.

Done.

11:16 am

Dara Navaei

You are right. I removed the code.

You are right. I removed the code.

10:51 am

Sean Nash

Should this happen in the previous if scope to simplify?

Should this happen in the previous if scope to simplify?

10:33 am

Sean Nash

Who's right?

Who's right?

10:22 am

Dara Navaei

I will implement it in DEN-12224.

I will implement it in DEN-12224.

9:04 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
9:02 am

Dara Navaei

Merge branch 'DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up' into develop

Options
    • -0
    • +1
    ./DGCommon.h
    • -1
    • +1
    ./Modes/ModeFlush.c
9:01 am

Dara Navaei

DEN-11750 added a build switch for heat disinfect

Options
    • -0
    • +1
    ./DGCommon.h
    • -6
    • +3
    ./Modes/ModeChemicalDisinfect.c
    • -0
    • +4
    ./Modes/ModeHeatDisinfect.c
8:49 am

Sean Nash

Seems like this should be an alarm.

Seems like this should be an alarm.

8:05 am

Dara Navaei

This will be addressed once we were working on deciding the number of rinses.

This will be addressed once we were working on deciding the number of rinses.

8:05 am

Dara Navaei

This will be addressed once we were working on deciding the number of rinses.

This will be addressed once we were working on deciding the number of rinses.

8:05 am

Dara Navaei

This will be addressed once we were working on deciding the number of rinses.

This will be addressed once we were working on deciding the number of rinses.

8:04 am

Dara Navaei

This will be addressed once we were working on deciding the number of rinses.

This will be addressed once we were working on deciding the number of rinses.

8:02 am

Dara Navaei

Done.

Done.

8:00 am

Dara Navaei

Done.

Done.

7:57 am

Dara Navaei

I will test this in DEN-12224.

I will test this in DEN-12224.

7:57 am

Dara Navaei

Done.

Done.

Tuesday 01 Mar 2022
8:16 pm

Dara Navaei

DG-DEN-12121_SW Dev Sprint 65
DG-DEN-12121_SW Dev Sprint 65
6:13 pm

hnguyen  (deleted user)

Removed the lines requestConcentratePumpOff( CONCENTRATEPUMPS_CP1_ACID ); requestConcentratePumpOff( CONCENTRATEPUMPS_CP2_BICARB ); The concentrate pumps are already OFF prior to transitioning to ...

Removed the lines
requestConcentratePumpOff( CONCENTRATEPUMPS_CP1_ACID );
requestConcentratePumpOff( CONCENTRATEPUMPS_CP2_BICARB );

The concentrate pumps are already OFF prior to transitioning to produce dialysate state.

5:47 pm

hnguyen  (deleted user)

According Blain's PowerPoint, for bicard, the RO Pump speed is 400mL/min. 800mL/min is for acid.

According Blain's PowerPoint, for bicard, the RO Pump speed is 400mL/min. 800mL/min is for acid.

5:47 pm

hnguyen  (deleted user)

Done.

Done.

5:25 pm

hnguyen  (deleted user)

Added param: testValue, baseValue, percentFactor

Added param: testValue, baseValue, percentFactor

5:06 pm

hnguyen  (deleted user)

RO pump rate is already set in the previous state.

RO pump rate is already set in the previous state.

4:47 pm

hnguyen  (deleted user)

Done.

Done.