dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 03 Mar 2022
1:39 pm

Dara Navaei

DEN-11750 addressed the code review comments

Options
    • -0
    • +1
    ./Modes/ModeChemicalDisinfect.c
1:39 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:38 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:37 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:35 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:34 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:34 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:34 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:22 pm

Michael Garthwaite

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

1:21 pm

Michael Garthwaite

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

1:20 pm

Michael Garthwaite

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

1:20 pm

Michael Garthwaite

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

1:18 pm

Michael Garthwaite

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

1:17 pm

Michael Garthwaite

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

1:15 pm

Michael Garthwaite

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

1:15 pm

Michael Garthwaite

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

11:21 am

hnguyen  (deleted user)

I am not clear on this question, do you want to use the load cell to weight samples based on the concentrate pump rate?

I am not clear on this question, do you want to use the load cell to weight samples based on the concentrate pump rate?

11:18 am

hnguyen  (deleted user)

According to SRSDG 397 we need to check the dialysate temperature within +/- 2 deg C. Systems need to review the DGSRS and provide comments.

According to SRSDG 397 we need to check the dialysate temperature within +/- 2 deg C.
Systems need to review the DGSRS and provide comments.

11:16 am

hnguyen  (deleted user)

According to SRSDG 216, While in Fill-Dialysate Production state, the DG Software shall transition to Fill-Deliver Dialysate state when the dialysate temperature is in target set temperature ± 2° C...

According to SRSDG 216, While in Fill-Dialysate Production state, the DG Software shall transition to Fill-Deliver Dialysate state when the dialysate temperature is in target set temperature ± 2° C and water quality is good (conductivity, pressure, temperature) for at least 3 s ± 100 ms.

11:11 am

hnguyen  (deleted user)

Set isThisFirstFill = FALSE per comment.

Set isThisFirstFill = FALSE per comment.

11:11 am

hnguyen  (deleted user)

According to Blain, the original equation is: (CD1 - CD2) / ( (CD1 + CD2) / 2 ) ) > +/- 5% which is the same as 2 * (CD1 - CD2) / (CD1 + CD2) > +/- 5%

According to Blain, the original equation is: (CD1 - CD2) / ( (CD1 + CD2) / 2 ) ) > +/- 5% which is the same as 2 * (CD1 - CD2) / (CD1 + CD2) > +/- 5%

11:06 am

hnguyen  (deleted user)

Changed the PRIME_CONCENTRATE_LINES_TIME_OUT_MS to 95 seconds.

Changed the PRIME_CONCENTRATE_LINES_TIME_OUT_MS to 95 seconds.

11:04 am

hnguyen  (deleted user)

Reverted the code with timeout. Need to add timeout requirement in the Inlet Water Check in the DG SRS.

Reverted the code with timeout. Need to add timeout requirement in the Inlet Water Check in the DG SRS.

11:02 am

hnguyen  (deleted user)

Sent Dara email asking him to put those numbers in the DG calibration record.

Sent Dara email asking him to put those numbers in the DG calibration record.

10:59 am

hnguyen  (deleted user)

Because the RO pump target flow rate is in liter per minute I updated RO_PUMP_400_ML_PER_MIN from 0.4 to 400.0 RO_PUMP_800_ML_PER_MIN from 0.8 to 800.0 Added #define MILLILITERS_PER_LITER 1000.0 an...

Because the RO pump target flow rate is in liter per minute
I updated RO_PUMP_400_ML_PER_MIN from 0.4 to 400.0
RO_PUMP_800_ML_PER_MIN from 0.8 to 800.0
Added #define MILLILITERS_PER_LITER 1000.0 and use this value in
setROPumpTargetFlowRateLPM( RO_PUMP_800_ML_PER_MIN / MILLILITERS_PER_LITER, TARGET_RO_PRESSURE_PSI );

10:43 am

hnguyen  (deleted user)

I forgot the pumps run at 48 mL/min not 48 mL/sec. total line volume + 25% = 60mL + 25% of 60mL = 75 mL. Concentrate pumps run at 48 mL/ min. ( 75 mL / 48 mL ) * 60 seconds = 93.75 seconds (used...

I forgot the pumps run at 48 mL/min not 48 mL/sec.

total line volume + 25% = 60mL + 25% of 60mL = 75 mL.

Concentrate pumps run at 48 mL/ min.

( 75 mL / 48 mL ) * 60 seconds = 93.75 seconds (used 95 seconds for PRIME_CONCENTRATE_LINES_TIME_OUT_MS)

Wednesday 02 Mar 2022
3:03 pm

Dara Navaei

DEN-11750 addressed the code review comments

Options
    • -6
    • +7
    ./Controllers/Fans.c
3:02 pm

Dara Navaei

Done.

Done.

2:27 pm

Dara Navaei

DEN-11750 addressed the code review comments

Options
    • -10
    • +10
    ./Controllers/TemperatureSensors.c
1:29 pm

Dara Navaei

DEN-11750 addressed the code review comments

Options
    • -1
    • +2
    ./Controllers/ConductivitySensors.c
    • -15
    • +4
    ./Controllers/UVReactors.c
    • -1
    • +6
    ./Services/AlarmMgmt.c
    • -1
    • +1
    ./Services/AlarmMgmt.h
    • -7
    • +10
    ./Services/SystemCommMessages.c