Activity dgfirmware/firmware/App

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Monday 07 Mar 2022

5:51 pm

Dara Navaei

More
e0cdf49
changed 25 files
DEN-12224-dg_hd_dev-switches-monitor, DEN-12845-sw_dev_sprint_s71_steve and 199 more DG-DEN-12224-7

DEN-12224 added F to the defines that are floating numbers

- -9
- +9
./Controllers/ConcentratePumps.c
- History
- Source
- Diff
./Controllers/ConcentratePumps.c
- -1
- +1
./Controllers/ConcentratePumps.h
- History
- Source
- Diff
./Controllers/ConcentratePumps.h
- -4
- +4
./Controllers/ConductivitySensors.c
- History
- Source
- Diff
./Controllers/ConductivitySensors.c
- -1
- +1
./Controllers/DialysateFlow.c
- History
- Source
- Diff
./Controllers/DialysateFlow.c
- -2
- +2
./Controllers/DialysateFlow.h
- History
- Source
- Diff
./Controllers/DialysateFlow.h
- -7
- +7
./Controllers/DrainPump.c
- History
- Source
- Diff
./Controllers/DrainPump.c
- -8
- +8
./Controllers/Fans.c
- History
- Source
- Diff
./Controllers/Fans.c
- -14
- +14
./Controllers/Heaters.c
- History
- Source
- Diff
./Controllers/Heaters.c
- -5
- +5
./Controllers/LoadCell.c
- History
- Source
- Diff
./Controllers/LoadCell.c
- -5
- +5
./Controllers/Pressures.c
- History
- Source
- Diff
./Controllers/Pressures.c
- -17
- +17
./Controllers/ROPump.c
- History
- Source
- Diff
./Controllers/ROPump.c
- -2
- +2
./Controllers/ROPump.h
- History
- Source
- Diff
./Controllers/ROPump.h
- -8
- +8
./Controllers/TemperatureSensors.c
- History
- Source
- Diff
./Controllers/TemperatureSensors.c
- -8
- +8
./Controllers/Thermistors.c
- History
- Source
- Diff
./Controllers/Thermistors.c
- -1
- +1
./Drivers/InternalADC.h
- History
- Source
- Diff
./Drivers/InternalADC.h
… 10 more files in changeset.

4:18 pm

Dara Navaei

More
ba370b0
changed 1 file
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
./DGCommon.h
- History
- Source
- Diff
./DGCommon.h

4:18 pm

Dara Navaei

More
51e60f3
changed 15 files
DEN-14902-bootloader-for-dg, cdc-demo-branch-218 and 3 more DG-DEN-14902-1 DG-DEN-15336-1

Merged DEN-12224 and resolved the conflicts

- -2
- +6
./Controllers/ConcentratePumps.c
- History
- Source
- Diff
./Controllers/ConcentratePumps.c
- -3
- +4
./Controllers/ConductivitySensors.c
- History
- Source
- Diff
./Controllers/ConductivitySensors.c
- -2
- +2
./Controllers/Heaters.c
- History
- Source
- Diff
./Controllers/Heaters.c
- -2
- +2
./Controllers/LoadCell.c
- History
- Source
- Diff
./Controllers/LoadCell.c
- -2
- +2
./Controllers/ROPump.c
- History
- Source
- Diff
./Controllers/ROPump.c
- -2
- +2
./Controllers/Switches.c
- History
- Source
- Diff
./Controllers/Switches.c
- -2
- +2
./Controllers/Thermistors.c
- History
- Source
- Diff
./Controllers/Thermistors.c
- -2
- +3
./DGCommon.h
- History
- Source
- Diff
./DGCommon.h
- -1
- +1
./Modes/ModeDrain.c
- History
- Source
- Diff
./Modes/ModeDrain.c
- -1
- +1
./Modes/ModeFlush.c
- History
- Source
- Diff
./Modes/ModeFlush.c
- -2
- +2
./Modes/OperationModes.c
- History
- Source
- Diff
./Modes/OperationModes.c
- -1
- +1
./Services/SystemComm.c
- History
- Source
- Diff
./Services/SystemComm.c
- -1
- +1
./Services/SystemComm.h
- History
- Source
- Diff
./Services/SystemComm.h
- -8
- +11
./Services/SystemCommMessages.c
- History
- Source
- Diff
./Services/SystemCommMessages.c
- -1
- +1
./Services/SystemCommMessages.h
- History
- Source
- Diff
./Services/SystemCommMessages.h

4:15 pm

Dara Navaei

More
fbeccee
changed 2 files
DEN-12224-dg_hd_dev-switches-monitor, DEN-12845-sw_dev_sprint_s71_steve and 199 more DG-DEN-12224-7

DEN-12224 added a build switch to disbale the conc pumps from running

- -0
- +4
./Controllers/ConcentratePumps.c
- History
- Source
- Diff
./Controllers/ConcentratePumps.c
- -0
- +1
./DGCommon.h
- History
- Source
- Diff
./DGCommon.h

3:50 pm

Hung Nguyen <hnguyen@diality.com>

More
2f3090f
changed 4 files
DEN-11928-dg-conductivity-update-den-tbd, DEN-12224-dg_hd_dev-switches-monitor and 201 more DG-DEN-11928-1

DEN-11928 Updated code per peer reviews comments

- -4
- +3
./Controllers/ConductivitySensors.c
- History
- Source
- Diff
./Controllers/ConductivitySensors.c
- -4
- +4
./Controllers/TemperatureSensors.c
- History
- Source
- Diff
./Controllers/TemperatureSensors.c
- -2
- +2
./DGCommon.h
- History
- Source
- Diff
./DGCommon.h
- -12
- +17
./Modes/ModeFill.c
- History
- Source
- Diff
./Modes/ModeFill.c

2:55 pm

Michael Garthwaite

More
Re: DG-DEN-12121-1
replied to Sean Nash

Not Always. ovData will stay True until the Reset function is called (which is then assigned ovInitData's value). Our handler only calls the Set/Reset function. No parameters are given.

Not Always. ovData will stay True until the Reset function is called (which is then assigned ovInitData's value). Our handler only calls the Set/Reset function. No parameters are given.

2:47 pm

Michael Garthwaite

Looks like it was commented out in this commit in August. http://dvm-linux02:7990/projects/DG/repos/dgfirmware/commits/47205a5002f27add91d8548f31c8a6fa18993fea#firmware/App/Services/SystemComm.c ...

Looks like it was commented out in this commit in August.

http://dvm-linux02:7990/projects/DG/repos/dgfirmware/commits/47205a5002f27add91d8548f31c8a6fa18993fea#firmware/App/Services/SystemComm.c

Should I uncomment it?

11:23 am

hnguyen (deleted user)

More
Re: DG-DEN-11928-1
replied to Sean Nash

set the RO pump rate to setROPumpTargetFlowRateLPM( getTargetFillFlowRateLPM(), TARGET_RO_PRESSURE_PSI );

set the RO pump rate to
setROPumpTargetFlowRateLPM( getTargetFillFlowRateLPM(), TARGET_RO_PRESSURE_PSI );

11:19 am

hnguyen (deleted user)

More
Re: DG-DEN-11928-1
replied to Sean Nash

Updated code to check for the difference in percent of conductivity between CD1 and CD2 and make sure it is < 5% otherwise alarm.

Updated code to check for the difference in percent of conductivity between CD1 and CD2 and make sure it is < 5% otherwise alarm.

11:19 am

hnguyen (deleted user)

More
Re: DG-DEN-11928-1
replied to Sean Nash

Updated code to check for the difference in percent of conductivity between CD1 and CD2 and make sure it is < 5% otherwise alarm.

Updated code to check for the difference in percent of conductivity between CD1 and CD2 and make sure it is < 5% otherwise alarm.

10:34 am

hnguyen (deleted user)

More
Re: DG-DEN-11928-1
replied to Sean Nash

Uncommented and recompiled without errors

Uncommented and recompiled without errors

Sunday 06 Mar 2022

8:53 pm

Dara Navaei

More
Re: DG-DEN-12121-1
commented on review

We do not have doxygen comments for the function declarations.

We do not have doxygen comments for the function declarations.

8:52 pm

Dara Navaei

More
Re: DG-DEN-12121-1
commented on review

Add a space.

Add a space.

8:52 pm

Dara Navaei

More
Re: DG-DEN-12121-1
commented on review

Add a space.

Add a space.

8:50 pm

Dara Navaei

More
Re: DG-DEN-12121-1
commented on review

I noticed you are using a U32 as a boolean without typecasting. I know a boolean is an unsigned integer behind the scenes but to be specific we should explicitly typecast.

I noticed you are using a U32 as a boolean without typecasting. I know a boolean is an unsigned integer behind the scenes but to be specific we should explicitly typecast.

8:45 pm

Dara Navaei

More
Re: DG-DEN-12121-1
commented on review

Why is this commented out?

Why is this commented out?

Friday 04 Mar 2022

2:37 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:36 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:35 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:35 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:35 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:35 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:34 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:34 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:34 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:33 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:33 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:32 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:30 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

Alarm is recoverable. Should go to fill paused state. Paused state should go back to this test inlet water quality state when alarm acknowledged.

Alarm is recoverable. Should go to fill paused state. Paused state should go back to this test inlet water quality state when alarm acknowledged.

2:24 pm

Sean Nash

More
Re: DG-DEN-11928-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-03-26 17:01 -0700