dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 16 Jan 2023
1:42 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13946 Code review correction

Options
    • -1
    • +0
    ./Controllers/Thermistors.c
12:11 pm

wbracken  (deleted user)

Alignment

Alignment

10:55 am

jtaylor  (deleted user)

Alignment

Alignment

Sunday 15 Jan 2023
3:27 pm

Dara Navaei

DEN-14559 updated the cleaning modes with the SRS changes

Options
    • -1
    • +1
    ./Controllers/TemperatureSensors.c
    • -71
    • +84
    ./Modes/ModeChemicalDisinfect.c
    • -65
    • +85
    ./Modes/ModeChemicalDisinfectFlush.c
    • -10
    • +1
    ./Modes/ModeFlush.c
    • -33
    • +18
    ./Modes/ModeHeatDisinfect.c
    • -8
    • +32
    ./Services/AlarmMgmt.c
    • -1
    • +1
    ./Services/AlarmMgmt.h
    • -1
    • +1
    ./Services/Reservoirs.c
Friday 13 Jan 2023
11:56 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13946 Darren comments DEN-14075 Corrected thermistor override in previous commit

Options
    • -6
    • +2
    ./Controllers/Thermistors.c
11:39 am

wbracken  (deleted user)

Corrected.

Corrected.

11:38 am

wbracken  (deleted user)

Only used if Temperature is in alarm.

Only used if Temperature is in alarm.

11:31 am

wbracken  (deleted user)

Only used if the load cell is out of range.

Only used if the load cell is out of range.

10:41 am

dcox  (deleted user)

No initial value for alarmID. Can it end up not set before use in checkPersistentAlarm?

No initial value for alarmID. Can it end up not set before use in checkPersistentAlarm?

10:38 am

dcox  (deleted user)

Why remove initial value for alarmIndex?

Why remove initial value for alarmIndex?

10:35 am

dcox  (deleted user)

Comment does not explain what the numbers are - 3, 10, 10.

Comment does not explain what the numbers are - 3, 10, 10.

10:34 am

dcox  (deleted user)

Comment is 12bit specific, but code updated to use different references per thermistor.

Comment is 12bit specific, but code updated to use different references per thermistor.

12:58 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13676 Add acid and bicarb low volume defines per SRS.

Options
    • -2
    • +17
    ./Modes/ModeDrain.c
Thursday 12 Jan 2023
7:01 pm

Dara Navaei

DG-DEN-13676_Bicarb Low Alarm Threshold Incorrect
DG-DEN-13676_Bicarb Low Alarm Threshold Incorrect
5:25 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
5:23 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13946 Correction to thermistor timeout.

Options
    • -1
    • +1
    ./Controllers/Thermistors.c
5:02 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
5:02 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'DEN-13946-certain-temperature-sensors-trigger-wrong-alarm' into develop

# Conflicts:

# firmware/App/DGCommon.h

Options
    • -1
    • +1
    ./Controllers/ConductivitySensors.c
    • -1
    • +1
    ./Controllers/DrainPump.h
    • -6
    • +6
    ./Controllers/Heaters.c
    • -14
    • +16
    ./Controllers/LoadCell.c
    • -2
    • +2
    ./Controllers/ROPump.h
    • -1
    • +1
    ./Services/AlarmMgmtSWFaults.h
    • -1
    • +1
    ./Services/SystemComm.c
    • -1
    • +1
    ./Services/SystemCommMessages.c
    • -1
    • +1
    ./Services/SystemCommMessages.h
4:56 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13946 Complete and tested for termperatures, pressures, load cells and thermistors. DEN-14075 Corrected thermistor override limits.

Options
    • -30
    • +42
    ./Controllers/Thermistors.c
Wednesday 11 Jan 2023
6:51 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'staging' into DEN-13946-certain-temperature-sensors-trigger-wrong-alarm

Options
    • -11
    • +21
    ./Controllers/Pressures.c
    • -6
    • +17
    ./Controllers/TemperatureSensors.c
5:38 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'staging' into DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle

Options
    • -8
    • +162
    ./Services/FPGA.c
5:01 pm

Dara Navaei

DG-DEN-14559_DG HD Dev HD DG Dvt Update Part 8
DG-DEN-14559_DG HD Dev HD DG Dvt Update Part 8
4:51 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13946 Update thermistor init.

Options
    • -7
    • +21
    ./Controllers/Thermistors.c
2:14 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
2:13 pm

Dara Navaei

2:13 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Controllers/ConductivitySensors.c
    • -1
    • +1
    ./Controllers/ConductivitySensors.h
    • -1
    • +1
    ./Controllers/DrainPump.c
    • -1
    • +1
    ./Controllers/DrainPump.h
    • -1
    • +1
    ./Controllers/Heaters.c
    • -1
    • +1
    ./Controllers/Heaters.h
    • -1
    • +1
    ./Controllers/Pressures.c
    • -1
    • +1
    ./Controllers/ROPump.c
    • -2
    • +2
    ./Controllers/ROPump.h
    • -1
    • +1
    ./Controllers/TemperatureSensors.c
    • -1
    • +1
    ./Controllers/Voltages.h
    • -1
    • +1
    ./Drivers/CPLD.h
    • -1
    • +1
    ./Modes/ModeChemicalDisinfect.c
    • -1
    • +1
    ./Modes/ModeChemicalDisinfectFlush.c
    • -1
    • +1
    ./Modes/ModeDrain.c
  16. … 9 more files in changeset.
2:10 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
1:22 pm

Sean Nash

1:10 pm

wbracken  (deleted user)

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

1:02 pm

Dara Navaei

DEN-14497 addressed the code review comment

Options
    • -1
    • +1
    ./Controllers/Heaters.c