dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 17 May 2023
8:20 am

Dara Navaei

DEN-15274 addressed the code review comments

Options
    • -4
    • +4
    ./Controllers/Heaters.c
    • -0
    • +3
    ./Controllers/LoadCell.c
    • -1
    • +1
    ./Modes/ModeHeatDisinfect.c
    • -3
    • +4
    ./Services/Reservoirs.c
8:11 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Tuesday 16 May 2023
5:49 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

5:49 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

5:32 pm

wbracken  (deleted user)

Includes should be in alphabetical order.

Includes should be in alphabetical order.

5:16 pm

Dara Navaei

Done

Done

5:16 pm

Dara Navaei

Done

Done

5:15 pm

Dara Navaei

Done

Done

5:12 pm

Dara Navaei

Merge branch 'staging' into DEN-15274-hd_dg_test_configuration_setup

Options
    • -3
    • +3
    ./Modes/ModeChemicalDisinfect.c
    • -3
    • +3
    ./Modes/ModeChemicalDisinfectFlush.c
    • -2
    • +3
    ./Modes/ModeDrain.c
    • -3
    • +3
    ./Modes/ModeFill.c
    • -3
    • +3
    ./Modes/ModeFlush.c
    • -3
    • +8
    ./Modes/ModeGenIdle.c
    • -3
    • +3
    ./Modes/ModeHeatDisinfect.c
    • -3
    • +3
    ./Modes/ModeHeatDisinfectActiveCool.c
4:36 pm

Michael Garthwaite

4:05 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
4:04 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Modes/ModeChemicalDisinfect.c
    • -2
    • +2
    ./Modes/ModeChemicalDisinfectFlush.c
    • -2
    • +2
    ./Modes/ModeDrain.c
    • -2
    • +2
    ./Modes/ModeFault.c
    • -2
    • +2
    ./Modes/ModeFill.c
    • -2
    • +2
    ./Modes/ModeFlush.c
    • -2
    • +2
    ./Modes/ModeGenIdle.c
    • -2
    • +2
    ./Modes/ModeHeatDisinfect.c
    • -2
    • +2
    ./Modes/ModeHeatDisinfectActiveCool.c
    • -2
    • +2
    ./Modes/ModeInitPOST.c
    • -2
    • +2
    ./Modes/ModeService.c
    • -2
    • +2
    ./Modes/ModeSolo.c
    • -2
    • +2
    ./Modes/OperationModes.c
    • -2
    • +2
    ./Modes/OperationModes.h
3:45 pm

Michael Garthwaite

3:43 pm

Sean Nash and wbracken  (deleted user)

3:37 pm

Sean Nash

Don't forget to roll compatibility for all 3 stacks.

Don't forget to roll compatibility for all 3 stacks.

2:33 pm

wbracken  (deleted user)

RESOLVED IN CODE WALK THROUGH

RESOLVED IN CODE WALK THROUGH

2:32 pm

Michael Garthwaite

DIAL-251: code review comments.

Options
    • -1
    • +1
    ./Modes/OperationModes.c
2:31 pm

wbracken  (deleted user)

#define for initial/undefined.

#define for initial/undefined.

2:31 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

1:27 pm

Sean Nash

function wants a U32. C will convert automatically, so not necessary I guess.

function wants a U32. C will convert automatically, so not necessary I guess.

12:44 pm

Michael Garthwaite

Merge branch 'staging' into DEN-15196-DIAL-251

Options
    • -1
    • +4
    ./Modes/ModeChemicalDisinfect.c
    • -1
    • +6
    ./Modes/ModeChemicalDisinfectFlush.c
    • -2
    • +9
    ./Modes/ModeFill.c
    • -2
    • +5
    ./Modes/ModeGenIdle.c
12:43 pm

Michael Garthwaite

DIAL-251: DG changes for operation status event handling.

Options
    • -1
    • +1
    ./Modes/ModeChemicalDisinfect.c
    • -1
    • +1
    ./Modes/ModeChemicalDisinfectFlush.c
    • -0
    • +1
    ./Modes/ModeDrain.c
    • -1
    • +1
    ./Modes/ModeFault.c
    • -1
    • +1
    ./Modes/ModeFill.c
    • -1
    • +1
    ./Modes/ModeFlush.c
    • -1
    • +6
    ./Modes/ModeGenIdle.c
    • -1
    • +1
    ./Modes/ModeHeatDisinfect.c
    • -1
    • +1
    ./Modes/ModeHeatDisinfectActiveCool.c
    • -1
    • +1
    ./Modes/ModeInitPOST.c
    • -1
    • +1
    ./Modes/ModeService.c
    • -1
    • +1
    ./Modes/ModeSolo.c
    • -2
    • +48
    ./Modes/OperationModes.c
    • -0
    • +3
    ./Modes/OperationModes.h
11:28 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
11:26 am

Dara Navaei

DEN-15274, DEN-15351 fixed the trimmer heater issue

Options
    • -1
    • +1
    ./Services/Reservoirs.c
10:53 am

wbracken  (deleted user)

Remove (U32) cast.

Remove (U32) cast.

10:53 am

wbracken  (deleted user)

Remove (U32) cast.

Remove (U32) cast.

10:38 am

Sean Nash

This looks wrong.

This looks wrong.

9:07 am

Sean Nash

What is the purpose of the gain/offset? They seem pretty small and are dwarfed by the 2 deg extra offset we're adding.

What is the purpose of the gain/offset? They seem pretty small and are dwarfed by the 2 deg extra offset we're adding.

8:32 am

Dara Navaei

DEN-15274 updated the GenIdle fill target to 0.8 L/min

Options
    • -1
    • +1
    ./Modes/ModeGenIdle.c
8:11 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h