dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 25 Aug 2023
2:55 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
2:52 pm

Vinayakam Mani

DEN-16093 code review comments added

Options
    • -2
    • +5
    ./Modes/ModeFill.c
2:50 pm

Vinayakam Mani

DEN-16093 fixed code review comments

Options
    • -2
    • +5
    ./Modes/ModeFill.c
2:27 pm

Sean Nash

Lets add a comment here that "we are insisting conductivity reach 100% of expected level since signal is very noisy and peak noise will reach 100% when average is about 93%. if sensor noise is redu...

Lets add a comment here that "we are insisting conductivity reach 100% of expected level since signal is very noisy and peak noise will reach 100% when average is about 93%. if sensor noise is reduced, this level should also be reduced accordingly."

2:24 pm

Sean Nash

100% now.

100% now.

2:05 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
2:00 pm

Vinayakam Mani

DEN-16093 fixed merging conflicts

Options
    • -4
    • +5
    ./Controllers/Heaters.c
    • -3
    • +3
    ./Modes/ModeFill.c
    • -2
    • +2
    ./Services/SystemComm.c
    • -2
    • +2
    ./Services/SystemCommMessages.c
1:21 pm

Vinayakam Mani

DEN-16093-Increased conductivity percentage check and time out values

Options
    • -3
    • +3
    ./Modes/ModeFill.c
1:06 pm

Vinayakam Mani

take latest changes from staging

Options
    • -5
    • +13
    ./Modes/ModeFill.c
    • -4
    • +58
    ./Services/SystemComm.c
    • -5
    • +69
    ./Services/SystemCommMessages.c
    • -1
    • +7
    ./Services/SystemCommMessages.h
12:45 pm

Sean Nash

12:42 pm

Sean Nash

As we discussed, I think alarm 150 and related inlet water alarms are already set to block triggering during rinseback and post-treatment modes. So these changes are likely not needed.

As we discussed, I think alarm 150 and related inlet water alarms are already set to block triggering during rinseback and post-treatment modes. So these changes are likely not needed.

12:05 pm

Dara Navaei

DG-DEN-16309_Heat Disinfect Has Spikes IN Temperature Near 95C Which Will Cause Water TO Boil AT
DG-DEN-16309_Heat Disinfect Has Spikes IN Temperature Near 95C Which Will Cause Water TO Boil AT
Thursday 24 Aug 2023
5:21 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
4:46 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
4:46 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Services/AlarmMgmt.c
    • -2
    • +2
    ./Services/AlarmMgmt.h
    • -2
    • +2
    ./Services/Reservoirs.c
    • -2
    • +2
    ./Services/SystemComm.c
    • -2
    • +2
    ./Services/SystemCommMessages.c
3:42 pm

Dara Navaei

3:41 pm

Dara Navaei

3:41 pm

Dara Navaei

2:09 pm

wbracken  (deleted user) and jtaylor  (deleted user)

2:02 pm

jtaylor  (deleted user)

This was a specific change for this alarm (150), and the associated alarms in this routine. It appeared there were similar mode limits for temperature as well. Pressure limits were more uniquely re...

This was a specific change for this alarm (150), and the associated alarms in this routine. It appeared there were similar mode limits for temperature as well. Pressure limits were more uniquely related to valve position, I thought.

I had seen the related changes in 59, and included them in my develop build.

12:58 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
12:58 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Controllers/Heaters.c
    • -2
    • +2
    ./Controllers/Voltages.c
    • -1
    • +1
    ./Controllers/Voltages.h
    • -1
    • +1
    ./Drivers/SafetyShutdown.c
    • -1
    • +1
    ./Services/WatchdogMgmt.c
12:57 pm

Dara Navaei

12:46 pm

wbracken  (deleted user) and Sean Nash

12:37 pm

wbracken  (deleted user) , Sean Nash and jtaylor  (deleted user)

11:27 am

Sean Nash

We don't trigger inlet water conductivity alarm in post-treatment mode? Any reason why we're not just saying "== MODE_POST"? What about inlet water pressure/temperature? FYI - getHDOperationMode()...

We don't trigger inlet water conductivity alarm in post-treatment mode? Any reason why we're not just saying "== MODE_POST"? What about inlet water pressure/temperature?

FYI - getHDOperationMode() was not working - HD op mode handler was mishandling message - fixed in my DENBUG-59 branch, but not yet in staging.

11:04 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
10:55 am

Sean Nash

Merged staging to DENBUG-59.

Options
    • -23
    • +88
    ./Services/Reservoirs.c
    • -4
    • +69
    ./Services/SystemComm.c
    • -7
    • +169
    ./Services/SystemCommMessages.c
10:20 am

Dara Navaei

DEN-16091 changed the trimmer heater's persistent alarm from 10 seconds to 12 seconds

Options
    • -3
    • +4
    ./Controllers/Heaters.c
9:58 am

Dara Navaei

DG-DEN-16308_Srsdg 53 Not Met
DG-DEN-16308_Srsdg 53 Not Met