dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 05 Sep 2023
11:43 am

Sean Nash , jtaylor  (deleted user) and wbracken  (deleted user)

10:06 am

jtaylor  (deleted user)

Is the "0" an ACK,NACK, PENDING_OVERRIDE or some other flag? Suggest a #define. (or a comment)

Is the "0" an ACK,NACK, PENDING_OVERRIDE or some other flag? Suggest a #define. (or a comment)

10:06 am

jtaylor  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:05 am

Michael Garthwaite

We typically dont #define for 0. However, the logic has been reworked that we no longer need to compare by 0.

We typically dont #define for 0. However, the logic has been reworked that we no longer need to compare by 0.

Friday 01 Sep 2023
4:58 pm

Vinayakam Mani

4:14 pm

Dara Navaei

DG-DEN-16314_Alarm 206 Triggers After Resuming From Incoming Water Conductivity High OR Low
DG-DEN-16314_Alarm 206 Triggers After Resuming From Incoming Water Conductivity High OR Low
3:22 pm

Dara Navaei

3:06 pm

jtaylor  (deleted user) , wbracken  (deleted user) , Michael Garthwaite and Sean Nash

2:06 pm

Dara Navaei

DG-DEN-15614_New Updated Disinfect Actuators Requirement Issues List
DG-DEN-15614_New Updated Disinfect Actuators Requirement Issues List
1:36 pm

wbracken  (deleted user)

Removed blank line

Removed blank line

12:28 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:19 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:19 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:19 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:19 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:18 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Thursday 31 Aug 2023
2:37 pm

Sean Nash

This if doesn't appear to be doing anything. Remove.

This if doesn't appear to be doing anything. Remove.

2:36 pm

Sean Nash

This should be inverse of what you had before. I think this is too brief.

This should be inverse of what you had before. I think this is too brief.

2:11 pm

Michael Garthwaite

Pushed wip code. I'm unsure what or if we need to put anything to compare override values.

Pushed wip code. I'm unsure what or if we need to put anything to compare override values.

2:11 pm

Dara Navaei

2:11 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:10 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

1:09 pm

Dara Navaei

12:45 pm

Sean Nash

Too many () after &&?

Too many () after &&?

12:44 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

12:44 pm

Sean Nash

Already TRUE - why set again? I think "if" should be reversed - if not override, set used to FALSE. And then after if, always set result to TRUE (means we found a match - which we did).

Already TRUE - why set again?
I think "if" should be reversed - if not override, set used to FALSE. And then after if, always set result to TRUE (means we found a match - which we did).

12:18 pm

Dara Navaei

DG-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
DG-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
9:51 am

wbracken  (deleted user) and Sean Nash

9:31 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:08 am

Dara Navaei

Done.

Done.