Activity dgfirmware/firmware/App

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	10 Jun
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Wednesday 06 Sep 2023

1:45 pm

Dara Navaei

More
1da5fe9
changed 8 files
develop

Merged DEN-16323

- -2
- +2
./Controllers/ConcentratePumps.c
- History
- Source
- Diff
./Controllers/ConcentratePumps.c
- -2
- +2
./Controllers/ConductivitySensors.c
- History
- Source
- Diff
./Controllers/ConductivitySensors.c
- -1
- +1
./Controllers/Heaters.c
- History
- Source
- Diff
./Controllers/Heaters.c
- -2
- +2
./Controllers/Pressures.c
- History
- Source
- Diff
./Controllers/Pressures.c
- -2
- +2
./Modes/ModeFill.c
- History
- Source
- Diff
./Modes/ModeFill.c
- -6
- +14
./Services/SystemComm.c
- History
- Source
- Diff
./Services/SystemComm.c
- -2
- +2
./Services/SystemCommMessages.c
- History
- Source
- Diff
./Services/SystemCommMessages.c
- -2
- +2
./Services/SystemCommMessages.h
- History
- Source
- Diff
./Services/SystemCommMessages.h

1:41 pm

Dara Navaei

More
30a8e9d
changed 1 file
DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 67 more DG-DEN-16323-1

DEN-16323 added code to reset the conductivity and temperature out of range persistent time in chemical disinfect

- -5
- +8
./Modes/ModeChemicalDisinfect.c
- History
- Source
- Diff
./Modes/ModeChemicalDisinfect.c

1:38 pm

Dara Navaei

More
DG-DEN-16323-1
started review

DG-DEN-16323_FW Alarm 243 Disinfection Interrupted Triggers During Chemical Disinfect

DG-DEN-16323_FW Alarm 243 Disinfection Interrupted Triggers During Chemical Disinfect

7:40 am

Dara Navaei

More
c613ebb
changed 1 file
DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 67 more

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
./DGCommon.h
- History
- Source
- Diff
./DGCommon.h

7:40 am

Dara Navaei

More
f910ec2
changed 1 file
DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 67 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./Services/SystemComm.c
- History
- Source
- Diff
./Services/SystemComm.c

7:38 am

Michael Garthwaite

More
DG-DEN-14706-2
Closed

Tuesday 05 Sep 2023

11:56 am

Dara Navaei

More
a2e2405
changed 1 file
DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 67 more

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
./DGCommon.h
- History
- Source
- Diff
./DGCommon.h

11:43 am

Sean Nash , jtaylor (deleted user) and wbracken (deleted user)

More
DG-DEN-14706-2
finished reviewing

10:06 am

jtaylor (deleted user)

More
Re: DG-DEN-14706-2
commented on review

Is the "0" an ACK,NACK, PENDING_OVERRIDE or some other flag? Suggest a #define. (or a comment)

Is the "0" an ACK,NACK, PENDING_OVERRIDE or some other flag? Suggest a #define. (or a comment)

10:06 am

jtaylor (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:05 am

Michael Garthwaite

More
Re: DG-DEN-14706-2
replied to jtaylor (deleted user)

We typically dont #define for 0. However, the logic has been reworked that we no longer need to compare by 0.

We typically dont #define for 0. However, the logic has been reworked that we no longer need to compare by 0.

8:11 am

Michael Garthwaite

More
0ae5f0f
changed 1 file
DEN-14706-can-messge-not-acked-fix, DEN-15791-dg-software-design-description and 68 more DG-DEN-14706-2

DEN-14706: fixed compiler errors

- -3
- +3
./Services/SystemComm.c
- History
- Source
- Diff
./Services/SystemComm.c

Friday 01 Sep 2023

4:58 pm

Vinayakam Mani

More
DG-DEN-16093-1
Closed

4:38 pm

James Walter Taylor <jtaylor@diality.com>

More
631df81
changed 2 files
DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 64 more DG-DEN-16314-1

DEN-16314-1-alarm-206-triggers-after-resuming-from-incoming-water-conductivity-high-or-low

Initial changes for alarm 206 timer

- -21
- +23
./Modes/ModeFill.c
- History
- Source
- Diff
./Modes/ModeFill.c
- -1
- +1
./Services/Reservoirs.c
- History
- Source
- Diff
./Services/Reservoirs.c

4:14 pm

Dara Navaei

More
DG-DEN-16314-1
started review

DG-DEN-16314_Alarm 206 Triggers After Resuming From Incoming Water Conductivity High OR Low

DG-DEN-16314_Alarm 206 Triggers After Resuming From Incoming Water Conductivity High OR Low

3:30 pm

Dara Navaei

More
ae9ddb7
changed 1 file
DEN-14706-can-messge-not-acked-fix, DEN-15791-dg-software-design-description and 68 more

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
./DGCommon.h
- History
- Source
- Diff
./DGCommon.h

3:30 pm

Dara Navaei

More
373439d
changed 2 files
DEN-14706-can-messge-not-acked-fix, DEN-15791-dg-software-design-description and 68 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
./Modes/ModeChemicalDisinfect.c
- History
- Source
- Diff
./Modes/ModeChemicalDisinfect.c
- -1
- +1
./Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
./Modes/ModeHeatDisinfect.c

3:22 pm

Dara Navaei

More
DG-DEN-15614-4
Closed

3:06 pm

jtaylor (deleted user) , wbracken (deleted user) , Michael Garthwaite and Sean Nash

More
DG-DEN-15614-4
finished reviewing

2:58 pm

Dara Navaei

More
98d8118
changed 2 files
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more DG-DEN-15614-4

DEN-15614 updated the chemical disinfect VPd to drain in the last drains, DEN-16354 changed the heat disinfect 500 mL timeout to 2 minutes to align with the reqruirements

- -1
- +1
./Modes/ModeChemicalDisinfect.c
- History
- Source
- Diff
./Modes/ModeChemicalDisinfect.c
- -1
- +1
./Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
./Modes/ModeHeatDisinfect.c

2:16 pm

Dara Navaei

More
6a4bdeb
changed 1 file
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 69 more DG-DEN-15614-4

DEN-15614 updated the chemical disinfect VPd to drain in the last drains

- -0
- +1
./Modes/ModeChemicalDisinfect.c
- History
- Source
- Diff
./Modes/ModeChemicalDisinfect.c

2:06 pm

Dara Navaei

More
DG-DEN-15614-4
started review

DG-DEN-15614_New Updated Disinfect Actuators Requirement Issues List

DG-DEN-15614_New Updated Disinfect Actuators Requirement Issues List

1:36 pm

wbracken (deleted user)

Removed blank line

Removed blank line

1:35 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
2fcf9be
changed 1 file
DEN-15791-dg-software-design-description, DEN-15973-alarm-48-uf-rate-tare-error-triggered-during-treatment and 65 more DG-DEN-15973-1

DEN-15973 Update per code review comments

- -1
- +0
./Controllers/ROPump.c
- History
- Source
- Diff
./Controllers/ROPump.c

12:28 pm

Sean Nash

More
Re: DG-DEN-15973-1
replied to wbracken (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:19 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:19 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:19 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:19 am

Sean Nash

More
Re: DG-DEN-14706-2
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:18 am

Sean Nash

More
Re: DG-DEN-14706-2
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-07-06 00:55 -0700