Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-17299, DENBUG-318, DENBUG-320, DENBUG-322 added a comment

DEN-17299 added the code changes from staging

    • -11
    • +39
    ./Controllers/ConductivitySensors.c
DG-DEN-17299_Release 22 P1B Staging
DG-DEN-17299_Release 22 P1B Staging
Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

DENBUG-318 addressed the code review comment

hd mode should be >= standby mode. You have it backward.

hd mode should be >= standby mode. You have it backward.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DENBUG-318 addressed the code review comments

Done.

Done.

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Merge branch 'DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging' into develop

DENBUG-318 added code to request the DG institutional values in mode standby until they are received

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Merge branch 'DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging' into develop

DENBUG-318 added code to keep requesting DG institutional values once start DG has been sent until the values are received

Should we have before and after values in event data?

Should we have before and after values in event data?

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Merge branch 'DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging' into develop

DENBUG-318 changed the min inlet water conductivity to recovery offset to 10 uS/cm. Updated the vectorcast test cases

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

DENBUG-318 added the request command to get the DG institutional record from HD upon starting the DG

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

DENBUG-318 added an RO rejection ratio event