firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-9906: Fixed code review issue.

DEN-9906: Fixed merge conflicts from staging.

    • -11
    • +22
    ./App/Controllers/ConcentratePumps.c
    • -49
    • +132
    ./App/Controllers/DrainPump.c
    • -450
    • +454
    ./App/Controllers/Heaters.c
  1. … 9 more files in changeset.
Merge branch 'DEN-9906-hd_dev-flow-measurement-changes' of ssh://dvm-linux02:7999/dg/dgfirmware into DEN-9906-hd_dev-flow-measurement-changes

DEN-9906: Fixed doxygen comments and group for dialysate flow module.

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Merged staging and resolved merge conflicts

    • -7
    • +8
    ./App/Controllers/TemperatureSensors.c
  1. … 15 more files in changeset.
DEN-9906 Added dialysate flow rate out of range alarm

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Fixed merge conflicts.

    • -0
    • +32
    ./App/Services/SystemCommMessages.c
Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -1
    • +1
    ./App/Controllers/TemperatureSensors.c
Merge branch 'staging' of ssh://dvm-linux02:7999/dg/dgfirmware into staging

    • -6
    • +6
    ./App/Controllers/TemperatureSensors.c
Removed the DEBUG_DENALI comment

    • -2
    • +0
    ./App/Controllers/TemperatureSensors.c
Merge branch 'DEN-9906-hd_dev-flow-measurement-changes' of ssh://dvm-linux02:7999/dg/dgfirmware into DEN-9906-hd_dev-flow-measurement-changes

    • -26
    • +0
    ./App/Services/SystemCommMessages.c
DEN-9906: Added publication of DG alarm info (safety line status) and override of its broadcast interval.

    • -0
    • +32
    ./App/Services/SystemCommMessages.c
Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -6
    • +6
    ./App/Controllers/ConductivitySensors.c
    • -6
    • +6
    ./App/Controllers/ConductivitySensors.h
  1. … 78 more files in changeset.
DEN-9480 updated documentation

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Done.

Done.

The const is an optional step in our code. Plus these are the local variables and their values are not changed inside the function.

The const is an optional step in our code. Plus these are the local variables and their values are not changed inside the function.

Done.

Done.

Done.

Done.

Variable reservoirDataPublicationTimerCounter is missing in the @detail Inputs and Output

Variable reservoirDataPublicationTimerCounter is missing in the @detail Inputs and Output

I am not sure why you removed the "const" from dialysateTemp and targetTemp?

I am not sure why you removed the "const" from dialysateTemp and targetTemp?