Activity dgfirmware/firmware

12:10 pm

Dara Navaei

More
3390017
changed 2 files
DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 55 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./App/Services/SystemComm.c
- History
- Source
- Diff
./App/Services/SystemComm.c
- -2
- +2
./App/Services/WatchdogMgmt.c
- History
- Source
- Diff
./App/Services/WatchdogMgmt.c

11:32 am

Sean Nash

More
DG-DEN-16372-1
Closed

10:41 am

wbracken (deleted user) and Dara Navaei

More
DG-DEN-16372-1
finished reviewing

10:19 am

wbracken (deleted user)

More
Re: DG-DEN-16446-1
commented on review

Should this have a set of parenthesis around the condition similar to line 437?

10:18 am

wbracken (deleted user)

Resolved in code review.

2:36 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
119a46b
changed 1 file
develop

DEN-16466 Allow alarm ID 282/281 to only occur in pre-treatment or treatment modes.

- -1
- +1
./App/Modes/ModeDrain.c
- History
- Source
- Diff
./App/Modes/ModeDrain.c

2:09 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
ad8064d
changed 1 file
develop

DEN-16466 Allow alarm ID 282 to only occur in pre-treatment or treatment modes.

- -4
- +10
./App/Modes/ModeDrain.c
- History
- Source
- Diff
./App/Modes/ModeDrain.c

1:39 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

More
86c8979
changed 1 file
develop

DEN-16466 Allow alarm ID 282 to only occur in pre-treatment or treatment modes.

- -2
- +10
./App/Modes/ModeDrain.c
- History
- Source
- Diff
./App/Modes/ModeDrain.c

10:43 am

jtaylor (deleted user)

More
DG-DEN-16372-1
finished reviewing

10:06 am

Dara Navaei

More
1bc6dc8
changed 1 file
develop

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
./App/DGCommon.h
- History
- Source
- Diff
./App/DGCommon.h

9:55 am

Sean Nash

More
36e0a9a
changed 1 file
develop

Merge branch 'DEN-16372-srsdg-907-not-met' into develop

- -4
- +6
./App/Services/SystemComm.c
- History
- Source
- Diff
./App/Services/SystemComm.c

8:26 am

Sean Nash

More
5c8d32c
changed 1 file
DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 56 more DG-DEN-16372-1

DEN-16372: Turn off trimmer heater if HD communication is lost.

- -4
- +6
./App/Services/SystemComm.c
- History
- Source
- Diff
./App/Services/SystemComm.c

9:27 am

Dara Navaei

More
b2c0dc6
changed 1 file
DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 56 more

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
./App/DGCommon.h
- History
- Source
- Diff
./App/DGCommon.h

9:00 am

Dara Navaei

More
4bd9d76
changed 1 file
develop

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
./App/DGCommon.h
- History
- Source
- Diff
./App/DGCommon.h

8:56 am

Dara Navaei

More
Re: DG-DEN-16372-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH

8:55 am

Sean Nash

Fixed.

8:54 am

Sean Nash

More
67cbaca
changed 1 file
DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 56 more DG-DEN-16372-1

DEN-16372: fixed typo - wrong alarm triggered for watchdog expired.

- -1
- +1
./App/Services/WatchdogMgmt.c
- History
- Source
- Diff
./App/Services/WatchdogMgmt.c

8:41 am

Dara Navaei

More
Re: DG-DEN-16372-1
commented on review

Did this alarm change to HD?

8:41 am

Vinayakam Mani

More
DG-DEN-16395-1
Closed

8:39 am

Dara Navaei

More
DG-DEN-16395-1
finished reviewing

8:38 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH

8:35 am

Dara Navaei

More
d5f37a7
changed 1 file
DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 56 more

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
./App/DGCommon.h
- History
- Source
- Diff
./App/DGCommon.h

8:35 am

Dara Navaei

More
6edc3ea
changed 1 file
DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 56 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./App/Controllers/TemperatureSensors.c
- History
- Source
- Diff
./App/Controllers/TemperatureSensors.c

8:26 am

Dara Navaei

More
2223e57
changed 1 file
develop

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
./App/DGCommon.h
- History
- Source
- Diff
./App/DGCommon.h

4:47 pm

Dara Navaei

More
dcd3bd6
changed 1 file
develop

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
./App/DGCommon.h
- History
- Source
- Diff
./App/DGCommon.h

3:00 pm

Sean Nash

More
5f1eb7d
changed 1 file
DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging, DEN-16204-ui-fw-pure-water-mode-turning-on-intermittently-p1-staging and 56 more DG-DEN-16372-1

DEN-16372: Matched watchdog expired alarm to requirement.

- -11
- +21
./App/Services/WatchdogMgmt.c
- History
- Source
- Diff
./App/Services/WatchdogMgmt.c

2:39 pm

Dara Navaei

More
DG-DEN-16372-1
started review

DG-DEN-16372_Srsdg 907 Not Met

2:35 pm

jtaylor (deleted user) and Sean Nash

More
DG-DEN-16395-1
finished reviewing

2:33 pm

Dara Navaei

More
Re: DG-DEN-16446-1
replied to wbracken (deleted user)

In the condition in line 437 we do a subtraction prior to comparing so there are extra parentheses in line 437.

11:51 am

Dara Navaei

More
6dd4a70
changed 1 file
develop

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
./App/DGCommon.h
- History
- Source
- Diff
./App/DGCommon.h

firmware

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Dara Navaei

Sean Nash

wbracken (deleted user) and Dara Navaei

wbracken (deleted user)

wbracken (deleted user)

Bill Bracken <bill@criticalsoftwaresolutions.com>

Bill Bracken <bill@criticalsoftwaresolutions.com>

Bill Bracken <bill@criticalsoftwaresolutions.com>

jtaylor (deleted user)

Dara Navaei

Sean Nash

Sean Nash

Dara Navaei

Dara Navaei

Dara Navaei

Sean Nash

Sean Nash

Dara Navaei

Vinayakam Mani

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Sean Nash

Dara Navaei

jtaylor (deleted user) and Sean Nash

Dara Navaei

Dara Navaei