dgfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 23 May 2025
10:09 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
10:03 am

Dara Navaei

Merged DENBUG-318

Options
    • -8
    • +24
    ./App/Controllers/ConductivitySensors.c
    • -0
    • +2
    ./App/Modes/ModeInitPOST.c
    • -2
    • +6
    ./App/Services/SystemComm.c
    • -11
    • +35
    ./App/Services/SystemCommMessages.c
    • -4
    • +7
    ./App/Services/SystemCommMessages.h
10:01 am

Dara Navaei

DENBUG-318 added a new event for min inlet water conductivity alarm from HD institutional record

Options
    • -0
    • +1
    ./App/Controllers/ConductivitySensors.c
    • -1
    • +1
    ./App/Modes/ModeFill.c
9:49 am

Dara Navaei

DENBUG-318 updated the code to receive all the DG institutional record items. Added code to use the min inlet water conductivity alarm from the institutional record

Options
    • -8
    • +23
    ./App/Controllers/ConductivitySensors.c
    • -0
    • +1
    ./App/Controllers/ConductivitySensors.h
    • -0
    • +2
    ./App/Modes/ModeInitPOST.c
    • -1
    • +0
    ./App/Modes/ModeStandby.c
    • -2
    • +2
    ./App/Services/SystemComm.c
    • -11
    • +12
    ./App/Services/SystemCommMessages.c
    • -4
    • +4
    ./App/Services/SystemCommMessages.h
Thursday 22 May 2025
4:27 pm

Dara Navaei

DENBUG-319 added code to receive a command from dialing to enable the mode fill chemicals test

Options
    • -0
    • +21
    ./App/Modes/ModeFill.c
    • -0
    • +2
    ./App/Modes/ModeFill.h
    • -2
    • +2
    ./App/Modes/ModeGenIdle.c
    • -0
    • +4
    ./App/Services/SystemComm.c
    • -0
    • +23
    ./App/Services/SystemCommMessages.c
    • -0
    • +3
    ./App/Services/SystemCommMessages.h
1:35 pm

Dara Navaei

Done

Done

12:54 pm

Sean Nash

It is an input - don't remove flag there. It is not an output - so remove it there.

It is an input - don't remove flag there. It is not an output - so remove it there.

Wednesday 21 May 2025
5:32 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
5:30 pm

Dara Navaei

Merge branch 'DENBUG-318-rejection-ratio-setting-feature-implementation-in-manufacturing-configuration-for-treatment-staging' into develop

Options
    • -1
    • +13
    ./App/Controllers/ConductivitySensors.c
5:30 pm

Dara Navaei

DENBUG-322 added code to set CPi and CPo to 20 uS/cm if the values are less than 20 uS/cm

Options
    • -1
    • +13
    ./App/Controllers/ConductivitySensors.c
5:03 pm

Dara Navaei

DENBUG-319 added code to skip the acid and bicarb check in mode fill if it is not the first fill

Options
    • -6
    • +12
    ./App/Modes/ModeFill.c
3:28 pm

Dara Navaei

Done

Done

2:56 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
2:54 pm

Dara Navaei

DENBUG-318 changed the location of requesting RO rejection ratio upon starting DG

Options
    • -1
    • +0
    ./App/Modes/ModeFill.c
    • -0
    • +1
    ./App/Modes/ModeStandby.c
9:24 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
9:17 am

Dara Navaei

DENBUG-320 addressed a code review comment

Options
    • -1
    • +1
    ./App/Modes/ModeGenIdle.c
9:03 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:00 am

Dara Navaei

DENBUG-320 brought back the start fill command after removing alarms 281, 282

Options
    • -0
    • +2
    ./App/Services/Reservoirs.c
8:59 am

Sean Nash

I don't see the flag being set in this function.

I don't see the flag being set in this function.

8:55 am

Sean Nash

Why are we keeping these in the broadcast?

Why are we keeping these in the broadcast?

8:53 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Tuesday 20 May 2025
3:02 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
3:00 pm

Dara Navaei

Resolved merge conflicts from DENBUG-318

Options
    • -1
    • +1
    ./App/Controllers/ConcentratePumps.c
    • -51
    • +0
    ./App/Modes/ModeDrain.c
    • -1
    • +1
    ./App/Services/AlarmMgmtSWFaults.h
    • -12
    • +4
    ./App/Services/SystemComm.c
    • -64
    • +47
    ./App/Services/SystemCommMessages.c
    • -6
    • +6
    ./App/Services/SystemCommMessages.h
2:46 pm

Dara Navaei

DENBUG-318 added the word max to the RO rejection ratio

Options
    • -1
    • +1
    ./App/Modes/ModeFill.c
    • -2
    • +2
    ./App/Services/SystemCommMessages.c
    • -2
    • +2
    ./App/Services/SystemCommMessages.h
1:47 pm

Dara Navaei

DENBUG-320 added the word max to the RO rejection ratio

Options
    • -7
    • +7
    ./App/Modes/ModeFill.c
    • -1
    • +1
    ./App/Modes/ModeFill.h
    • -2
    • +2
    ./App/Services/SystemComm.c
    • -5
    • +5
    ./App/Services/SystemCommMessages.c
    • -2
    • +2
    ./App/Services/SystemCommMessages.h
1:39 pm

Dara Navaei

Done

Done

1:38 pm

Dara Navaei

Done

Done

1:32 pm

Dara Navaei

DENBUG-320 removed the code that checked for the acid and bicarb low volume and triggered alarms

Options
    • -41
    • +0
    ./App/Modes/ModeDrain.c
    • -172
    • +2
    ./App/Modes/ModeFill.c
    • -9
    • +0
    ./App/Modes/ModeFill.h
    • -29
    • +4
    ./App/Modes/ModeGenIdle.c
    • -3
    • +0
    ./App/Modes/ModeStandby.c
    • -1
    • +1
    ./App/Services/AlarmMgmtSWFaults.h
    • -6
    • +0
    ./App/Services/Reservoirs.c
    • -8
    • +0
    ./App/Services/SystemComm.c
    • -64
    • +0
    ./App/Services/SystemCommMessages.c
    • -6
    • +0
    ./App/Services/SystemCommMessages.h
1:01 pm

Sean Nash

Should you do something with the received max ratio? It's local, so it's just being dropped.

Should you do something with the received max ratio? It's local, so it's just being dropped.

10:59 am

Sean Nash

max ratio

max ratio