dialin

Clone Tools

Stats

Commits this week: 0
Total Committers: 21
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 04 Mar 2022
2:45 pm

Michael Garthwaite

Merge branch 'DEN-12121-sw_dev-sprint-65' into develop

Options
    • -2
    • +2
    /dialin/hd/treatment.py
2:45 pm

Michael Garthwaite

DEN-12121: Fixed swapped heparin values for request treatment parameters.

Options
    • -2
    • +2
    /dialin/hd/treatment.py
12:37 am

Behrouz NematiPour

To be consistent with rest of the code and what has been decided use the standard docstring format as: @param (int): <description> @return (int): <description>

To be consistent with rest of the code and what has been decided use the standard docstring format as:
@param (int): <description>
@return (int): <description>

12:35 am

Behrouz NematiPour

Please use the new conversion methods, from now on. I believe we decided to use them until you find time to update all the others.

Please use the new conversion methods, from now on.
I believe we decided to use them until you find time to update all the others.

12:34 am

Behrouz NematiPour

unnecessary empty lines.

unnecessary empty lines.

12:34 am

Behrouz NematiPour

please follow the standard: @retrurn: (int) <description>

please follow the standard:
@retrurn: (int) <description>

12:32 am

Behrouz NematiPour

Please add the simulator functions for the newly added models, like the: *DG Conductivity Data *HD blood leak data *HD air bubbles data *Air Trap Data *.....

Please add the simulator functions for the newly added models, like the:

  • DG Conductivity Data
  • HD blood leak data
  • HD air bubbles data
  • Air Trap Data
  • .....
12:30 am

Behrouz NematiPour

update the docstring.

update the docstring.

12:30 am

Behrouz NematiPour

the docstring says it is bool, which is correct.

the docstring says it is bool, which is correct.

12:29 am

Behrouz NematiPour

Please align the pipes ( | ) fix #5 to #6

Please align the pipes ( | )
fix #5 to #6

12:27 am

Behrouz NematiPour

Please update doctring here and above.

Please update doctring here and above.

12:26 am

Behrouz NematiPour

Please update docstring here and above.

Please update docstring here and above.

12:19 am

Behrouz NematiPour

Please update the docstring here and on top.

Please update the docstring here and on top.

Thursday 03 Mar 2022
4:50 pm

Dara Navaei

3:28 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /dialin/dg/alarms.py
    • -1
    • +1
    /dialin/dg/calibration_record.py
    • -1
    • +1
    /dialin/dg/dialysate_generator.py
    • -1
    • +1
    /dialin/dg/fans.py
    • -1
    • +1
    /dialin/dg/ro_pump.py
    • -0
    • +15
    /dialin/dg/sw_configs.py
    • -1
    • +1
    /dialin/dg/temperatures.py
    • -1
    • +1
    /dialin/hd/alarms.py
    • -1
    • +1
    /dialin/hd/calibration_record.py
    • -1
    • +1
    /dialin/hd/fans.py
    • -2
    • +2
    /dialin/hd/hemodialysis_device.py
    • -0
    • +15
    /dialin/hd/sw_configs.py
    • -2
    • +2
    /dialin/hd/syringe_pump.py
    • -1
    • +1
    /dialin/hd/temperatures.py
    • -1
    • +1
    /dialin/hd/treatment.py
  16. … 13 more files in changeset.
Wednesday 02 Mar 2022
12:39 pm

Michael Garthwaite and Sean Nash

10:21 am

Dara Navaei

Merged DEN-11750

Options
    • -2
    • +2
    /dialin/dg/temperatures.py
    • -2
    • +0
    /dialin/hd/hemodialysis_device.py
10:19 am

Dara Navaei

DEN-11750 changed the temperatures

Options
    • -2
    • +2
    /dialin/dg/temperatures.py
Tuesday 01 Mar 2022
8:18 pm

Dara Navaei

DIALIN-DEN-12121_SW Dev Sprint 65
DIALIN-DEN-12121_SW Dev Sprint 65
1:06 pm

Michael Garthwaite

RESOLVED.

RESOLVED.

12:57 pm

Dara Navaei

DEN-11750 addressed the code review comments

Options
    • -6
    • +1
    /dialin/hd/fans.py
12:56 pm

Dara Navaei

This variable was very temporary. I deleted it.

This variable was very temporary. I deleted it.

12:47 pm

Dara Navaei

DEN-11750 updated the code

Options
    • -1
    • +6
    /dialin/hd/fans.py
    • -62
    • +52
    /tests/dg_tests.py
12:45 pm

Dara Navaei

DEN-11750 updated the sw_config to sw_configs

Options
    • -1
    • +1
    /dialin/dg/dialysate_generator.py
    • -289
    • +0
    /dialin/dg/sw_config.py
    • -0
    • +289
    /dialin/dg/sw_configs.py
    • -3
    • +1
    /dialin/hd/hemodialysis_device.py
    • -320
    • +0
    /dialin/hd/sw_config.py
    • -0
    • +320
    /dialin/hd/sw_configs.py
    • -1
    • +1
    /tests/peter/test_dg_records.py
10:52 am

Dara Navaei

Merged DEN-11750

Options
    • -1
    • +1
    /dialin/dg/dialysate_generator.py
    • -0
    • +289
    /dialin/dg/sw_configs.py
    • -1
    • +2
    /dialin/hd/hemodialysis_device.py
    • -0
    • +320
    /dialin/hd/sw_configs.py
10:44 am

Dara Navaei

DEN-11750 Updated the sw_config file to sw_configs

Options
    • -1
    • +1
    /dialin/dg/dialysate_generator.py
    • -289
    • +0
    /dialin/dg/sw_config.py
    • -1
    • +1
    /dialin/hd/hemodialysis_device.py
    • -320
    • +0
    /dialin/hd/sw_config.py
    • -1
    • +1
    /tests/peter/test_dg_records.py
10:38 am

Michael Garthwaite

I don't have an issue with temporary features or variables being merged into staging but could we not name them so vaguely? Ex: calc_rpm_start_time_removable or calc_rpm_start_time_temporary?

I don't have an issue with temporary features or variables being merged into staging but could we not name them so vaguely? Ex: calc_rpm_start_time_removable or calc_rpm_start_time_temporary?

10:24 am

Dara Navaei

Updated the temperature sensors driver

Options
    • -1
    • +1
    /dialin/dg/temperatures.py
10:13 am

Dara Navaei

DEN-11750 tested the code

Options
    • -1
    • +6
    /dialin/hd/fans.py
    • -62
    • +52
    /tests/dg_tests.py
Monday 28 Feb 2022
5:24 pm

Michael Garthwaite

Merge branch 'DEN-12121-sw_dev-sprint-65' into develop

Options
    • -21
    • +22
    /dialin/ui/hd_simulator.py