Activity dialin/

2:56 pm

Dara Navaei

More
830aaa0
changed 1 file
DEN-12224-dg_hd_dev-switches-monitor, DEN-12358-sw_dev-sprint-67_mg and 186 more DIALIN-DEN-12224-1

DEN-12224 addressed the code review comments

- -41
- +15
/dialin/hd/pretreatment.py
- History
- Source
- Diff
/dialin/hd/pretreatment.py

2:55 pm

Dara Navaei

More
c7c9198
changed 6 files
DEN-12224-dg_hd_dev-switches-monitor, DEN-12358-sw_dev-sprint-67_mg and 186 more DIALIN-DEN-12224-1

DEN-12224 updated the test scripts for various tests

- -3
- +3
/tests/dg_nvm_scripts.py
- History
- Source
- Diff
/tests/dg_nvm_scripts.py
- -3
- +6
/tests/dg_tests.py
- History
- Source
- Diff
/tests/dg_tests.py
- -1
- +3
/tests/hd_blood_leak_data.py
- History
- Source
- Diff
/tests/hd_blood_leak_data.py
- -8
- +10
/tests/peter/set_RTCs.py
- History
- Source
- Diff
/tests/peter/set_RTCs.py
- -3
- +3
/tests/peter/test_dg_records.py
- History
- Source
- Diff
/tests/peter/test_dg_records.py
- -3
- +5
/tests/peter/test_hd_records.py
- History
- Source
- Diff
/tests/peter/test_hd_records.py

10:16 am

Dara Navaei

More
7fa2481
changed 2 files
DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device, DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault and 127 more

Merge branch 'DEN-12224-dg_hd_dev-switches-monitor' into develop

- -1
- +1
/tests/dg_nvm_scripts.py
- History
- Source
- Diff
/tests/dg_nvm_scripts.py
- -1
- +6
/tests/hd_nvm_scripts.py
- History
- Source
- Diff
/tests/hd_nvm_scripts.py

10:16 am

Dara Navaei

More
e8e24c9
changed 6 files
DEN-12224-dg_hd_dev-switches-monitor, DEN-12358-sw_dev-sprint-67_mg and 186 more DIALIN-DEN-12224-1

DEN-12224 updated the blood leak observer class

- -2
- +8
/dialin/hd/blood_leak.py
- History
- Source
- Diff
/dialin/hd/blood_leak.py
- -3
- +4
/dialin/hd/hemodialysis_device.py
- History
- Source
- Diff
/dialin/hd/hemodialysis_device.py
- -1
- +1
/tests/dg_nvm_scripts.py
- History
- Source
- Diff
/tests/dg_nvm_scripts.py
- -4
- +30
/tests/hd_blood_leak_data.py
- History
- Source
- Diff
/tests/hd_blood_leak_data.py
- -1
- +6
/tests/hd_nvm_scripts.py
- History
- Source
- Diff
/tests/hd_nvm_scripts.py
- -2
- +2
/tests/peter/test_hd_records.py
- History
- Source
- Diff
/tests/peter/test_hd_records.py

9:49 am

Sean Nash

Agree with Behrouz's initial proposed change above.

9:35 am

alarm_cto[0] is an integer - not a boolean. alarm_clr_top_only[] is an array of booleans. If Python boolean "True" is equivalent to integer "1", then I suppose we can assign directly. I think the c...

alarm_cto[0] is an integer - not a boolean. alarm_clr_top_only[] is an array of booleans.
If Python boolean "True" is equivalent to integer "1", then I suppose we can assign directly.
I think the current way this assignment is coded is making no assumptions and explicitly converting integer to boolean which is ok with me.

9:02 am

Behrouz NematiPour

I not I understand the answer and how that related to my question. I think what I am trying to say is: *Why do we create an object that we have no use for it, yet. *Why create an object for every...

I not I understand the answer and how that related to my question.
I think what I am trying to say is:

Why do we create an object that we have no use for it, yet.
Why create an object for every class before even being used.
Or Why it is not being created when it is needed and where it is going to be used.

And could you please help understand what is "QoL feature"?

8:56 am

Behrouz NematiPour

what I meant is the following statement is a binary why it has been compared with True/False once, and put in trinary once more just to compare a binary statement with binary. alarm_cto[0] == 1 it...

what I meant is the following statement is a binary why it has been compared with True/False once, and put in trinary once more just to compare a binary statement with binary.

alarm_cto[0] == 1

it is double the unnecessary work and confusing.

8:52 am

Behrouz NematiPour

We should improve the Dialin coding someday! RESOLVED

We should improve the Dialin coding someday!
RESOLVED

8:51 am

Behrouz NematiPour

Yes, Sean Nash, a Jira task, I meant. RESOLVED.

Yes, Sean Nash, a Jira task, I meant.
RESOLVED.

11:19 am

Michael Garthwaite

This is a QoL feature for users. Otherwise they would have to create the CAN interface themselves and assign it themselves. V&V has had issues like this before where they would create VV_submodule_...

This is a QoL feature for users. Otherwise they would have to create the CAN interface themselves and assign it themselves. V&V has had issues like this before where they would create VV_submodule_class and it ends up interfering with their data collection.

11:13 am