Activity dialin/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	21
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Monday 20 Jun 2022

3:16 pm

Dara Navaei

More
6b1fd68
changed 5 files
DEN-12224-dg_hd_dev-switches-monitor, DEN-12358-sw_dev-sprint-67_mg and 186 more DIALIN-DEN-12224-1

DEN-12224 updated the heaters

- -9
- +5
/dialin/dg/heaters.py
- History
- Source
- Diff
/dialin/dg/heaters.py
- -6
- +6
/tests/dg_nvm_scripts.py
- History
- Source
- Diff
/tests/dg_nvm_scripts.py
- -7
- +7
/tests/dg_tests.py
- History
- Source
- Diff
/tests/dg_tests.py
- -6
- +2
/tests/hd_nvm_scripts.py
- History
- Source
- Diff
/tests/hd_nvm_scripts.py
- -2
- +2
/tests/peter/set_RTCs.py
- History
- Source
- Diff
/tests/peter/set_RTCs.py

2:05 pm

Dara Navaei

More
0c84db7
changed 8 files
DEN-12224-dg_hd_dev-switches-monitor, DEN-12358-sw_dev-sprint-67_mg and 186 more DIALIN-DEN-12224-1

Merge branch 'staging' into DEN-12224-dg_hd_dev-switches-monitor

- -2
- +2
/dialin/common/dg_defs.py
- History
- Source
- Diff
/dialin/common/dg_defs.py
- -2
- +2
/dialin/common/msg_ids.py
- History
- Source
- Diff
/dialin/common/msg_ids.py
- -2
- +2
/dialin/dg/conductivity_sensors.py
- History
- Source
- Diff
/dialin/dg/conductivity_sensors.py
- -2
- +2
/dialin/dg/dialysate_generator.py
- History
- Source
- Diff
/dialin/dg/dialysate_generator.py
- -2
- +16
/dialin/utils/conversions.py
- History
- Source
- Diff
/dialin/utils/conversions.py
- -1
- +1
/tests/dg_nvm_scripts.py
- History
- Source
- Diff
/tests/dg_nvm_scripts.py
- -1
- +1
/tests/dg_tests.py
- History
- Source
- Diff
/tests/dg_tests.py
- -1
- +1
/tests/hd_nvm_scripts.py
- History
- Source
- Diff
/tests/hd_nvm_scripts.py

2:00 pm

Michael Garthwaite

RESOLVED.

RESOLVED.

2:00 pm

Michael Garthwaite

RESOLVED.

RESOLVED.

1:59 pm

Michael Garthwaite

RESOLVED.

RESOLVED.

1:59 pm

Michael Garthwaite

RESOLVED.

RESOLVED.

1:59 pm

Michael Garthwaite

RESOLVED.

RESOLVED.

1:59 pm

Michael Garthwaite

RESOLVED.

RESOLVED.

1:56 pm

Dara Navaei

Will be addressed in in DIAL-171.

Will be addressed in in DIAL-171.

1:56 pm

Dara Navaei

Will be addressed in in DIAL-171.

Will be addressed in in DIAL-171.

1:55 pm

Dara Navaei

Will be addressed in in DIAL-171.

Will be addressed in in DIAL-171.

1:55 pm

Dara Navaei

Will be addressed in in DIAL-171.

Will be addressed in in DIAL-171.

Saturday 18 Jun 2022

2:56 pm

Dara Navaei

More
830aaa0
changed 1 file
DEN-12224-dg_hd_dev-switches-monitor, DEN-12358-sw_dev-sprint-67_mg and 186 more DIALIN-DEN-12224-1

DEN-12224 addressed the code review comments

- -41
- +15
/dialin/hd/pretreatment.py
- History
- Source
- Diff
/dialin/hd/pretreatment.py

2:55 pm

Dara Navaei

Done.

Done.

2:54 pm

Dara Navaei

Done.

Done.

2:45 pm

Dara Navaei

More
c7c9198
changed 6 files
DEN-12224-dg_hd_dev-switches-monitor, DEN-12358-sw_dev-sprint-67_mg and 186 more DIALIN-DEN-12224-1

DEN-12224 updated the test scripts for various tests

- -3
- +3
/tests/dg_nvm_scripts.py
- History
- Source
- Diff
/tests/dg_nvm_scripts.py
- -3
- +6
/tests/dg_tests.py
- History
- Source
- Diff
/tests/dg_tests.py
- -1
- +3
/tests/hd_blood_leak_data.py
- History
- Source
- Diff
/tests/hd_blood_leak_data.py
- -8
- +10
/tests/peter/set_RTCs.py
- History
- Source
- Diff
/tests/peter/set_RTCs.py
- -3
- +3
/tests/peter/test_dg_records.py
- History
- Source
- Diff
/tests/peter/test_dg_records.py
- -3
- +5
/tests/peter/test_hd_records.py
- History
- Source
- Diff
/tests/peter/test_hd_records.py

Wednesday 15 Jun 2022

10:16 am

Dara Navaei

More
7fa2481
changed 2 files
DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device, DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault and 127 more

Merge branch 'DEN-12224-dg_hd_dev-switches-monitor' into develop

- -1
- +1
/tests/dg_nvm_scripts.py
- History
- Source
- Diff
/tests/dg_nvm_scripts.py
- -1
- +6
/tests/hd_nvm_scripts.py
- History
- Source
- Diff
/tests/hd_nvm_scripts.py

10:16 am

Dara Navaei

More
e8e24c9
changed 6 files
DEN-12224-dg_hd_dev-switches-monitor, DEN-12358-sw_dev-sprint-67_mg and 186 more DIALIN-DEN-12224-1

DEN-12224 updated the blood leak observer class

- -2
- +8
/dialin/hd/blood_leak.py
- History
- Source
- Diff
/dialin/hd/blood_leak.py
- -3
- +4
/dialin/hd/hemodialysis_device.py
- History
- Source
- Diff
/dialin/hd/hemodialysis_device.py
- -1
- +1
/tests/dg_nvm_scripts.py
- History
- Source
- Diff
/tests/dg_nvm_scripts.py
- -4
- +30
/tests/hd_blood_leak_data.py
- History
- Source
- Diff
/tests/hd_blood_leak_data.py
- -1
- +6
/tests/hd_nvm_scripts.py
- History
- Source
- Diff
/tests/hd_nvm_scripts.py
- -2
- +2
/tests/peter/test_hd_records.py
- History
- Source
- Diff
/tests/peter/test_hd_records.py

Tuesday 14 Jun 2022

9:49 am

Sean Nash

Agree with Behrouz's initial proposed change above.

Agree with Behrouz's initial proposed change above.

9:35 am

Sean Nash

alarm_cto[0] is an integer - not a boolean. alarm_clr_top_only[] is an array of booleans. If Python boolean "True" is equivalent to integer "1", then I suppose we can assign directly. I think the c...

alarm_cto[0] is an integer - not a boolean. alarm_clr_top_only[] is an array of booleans.
If Python boolean "True" is equivalent to integer "1", then I suppose we can assign directly.
I think the current way this assignment is coded is making no assumptions and explicitly converting integer to boolean which is ok with me.

Thursday 09 Jun 2022

9:02 am

Behrouz NematiPour

I not I understand the answer and how that related to my question. I think what I am trying to say is: *Why do we create an object that we have no use for it, yet. *Why create an object for every...

I not I understand the answer and how that related to my question.
I think what I am trying to say is:

Why do we create an object that we have no use for it, yet.
Why create an object for every class before even being used.
Or Why it is not being created when it is needed and where it is going to be used.

And could you please help understand what is "QoL feature"?

8:56 am

Behrouz NematiPour

what I meant is the following statement is a binary why it has been compared with True/False once, and put in trinary once more just to compare a binary statement with binary. alarm_cto[0] == 1 it...

what I meant is the following statement is a binary why it has been compared with True/False once, and put in trinary once more just to compare a binary statement with binary.

alarm_cto[0] == 1

it is double the unnecessary work and confusing.

8:52 am

Behrouz NematiPour

We should improve the Dialin coding someday! RESOLVED

We should improve the Dialin coding someday!
RESOLVED

8:51 am

Behrouz NematiPour

Yes, Sean Nash, a Jira task, I meant. RESOLVED.

Yes, Sean Nash, a Jira task, I meant.
RESOLVED.

Wednesday 08 Jun 2022

11:19 am

Michael Garthwaite

This is a QoL feature for users. Otherwise they would have to create the CAN interface themselves and assign it themselves. V&V has had issues like this before where they would create VV_submodule_...

This is a QoL feature for users. Otherwise they would have to create the CAN interface themselves and assign it themselves. V&V has had issues like this before where they would create VV_submodule_class and it ends up interfering with their data collection.

11:13 am

Michael Garthwaite

RESOLVED

RESOLVED

10:55 am

Dong Nguyen <dnguyen@diality.com>

More
30550eb
changed 1 file
DEN-12961-sw_dev_sprint_72_dong DIALIN-DEN-12961-1

Update the script for testing syringe pump operations.

- -9
- +12
/tests/test_syringe.py
- History
- Source
- Diff
/tests/test_syringe.py

Monday 06 Jun 2022

4:44 pm

Behrouz NematiPour

More
2cd826f
changed 1 file
DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device, DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault and 127 more

Merge branch 'DEN-12716-UI_BN_S70' into develop

- -212
- +250
/dialin/common/hd_defs.py
- History
- Source
- Diff
/dialin/common/hd_defs.py

4:39 pm

Behrouz NematiPour

More
8902a3c
changed 2 files
DEN-12716-UI_BN_S70, DEN-13154-heparin-syringe-empty-position-incorrect and 183 more DIALIN-DEN-12716-1

LTTS: https://github.com/Diality/testsuites/issues

- https://github.com/Diality/testsuites/issues/48

- https://github.com/Diality/testsuites/issues/47

- -220
- +247
/dialin/common/hd_defs.py
- History
- Source
- Diff
/dialin/common/hd_defs.py
- -1
- +69
/dialin/common/msg_defs.py
- History
- Source
- Diff
/dialin/common/msg_defs.py

Wednesday 01 Jun 2022

1:14 pm

Darren Cox <darren_m@cox.net>

More
421e18b
changed 1 file
DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device, DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault and 127 more DIALIN-UCOMMITS-16

Updated debug message event indexing

- -3
- +4
/dialin/hd/hemodialysis_device.py
- History
- Source
- Diff
/dialin/hd/hemodialysis_device.py

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-02-12 22:33 -0800