dialin

Clone Tools

Stats

Commits this week: 0
Total Committers: 21
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 14 Sep 2023
9:37 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /dialin/common/msg_ids.py
    • -1
    • +1
    /dialin/dg/chemical_disinfect.py
9:28 am

Michael Garthwaite

Merge branch 'DIAL-283-no-moving-average-commands-conductivity' into staging

Options
9:00 am

Dara Navaei

3:56 am

Behrouz NematiPour

Wednesday 13 Sep 2023
11:16 am

Tiffany Mejia

9:48 am

Dara Navaei

UI-DEN-16419-UI-BN-S106 [ ready - dialin ]
UI-DEN-16419-UI-BN-S106 [ ready - dialin ]
2:48 am

Behrouz NematiPour

DEN-16310: Treatment Log Treatment Data May Not Be Displaying Correct Data

Options
    • -5
    • +5
    /dialin/ui/hd_simulator.py
Tuesday 12 Sep 2023
3:05 pm

Dara Navaei

Bamboo Commit: generated the code change report

Options
    • -0
    • +2
    /tools/Code_Report.csv
3:03 pm

Dara Navaei

Merge branch 'DIAL-283-no-moving-average-commands-conductivity' into develop

Options
Monday 11 Sep 2023
2:02 pm

Michael Garthwaite

DIAL-283: cd2 moving average override.

Options
    • -0
    • +1
    /dialin/common/msg_ids.py
    • -0
    • +32
    /dialin/dg/chemical_disinfect.py
12:05 pm

Dara Navaei

DIALIN-DIAL-283_NO Moving Average Commands Conductivity
DIALIN-DIAL-283_NO Moving Average Commands Conductivity
10:46 am

Dara Navaei

Bamboo Commit: generated the code change report

Options
    • -0
    • +1
    /tools/Code_Report.csv
10:44 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /dialin/dg/chemical_disinfect.py
10:42 am

Dara Navaei

Merged DEN-16390

Options
10:42 am

Dara Navaei

10:41 am

Behrouz NematiPour and Sean Nash

8:53 am

Dara Navaei

Bamboo Commit: generated the code change report

Options
    • -0
    • +1
    /tools/Code_Report.csv
8:51 am

Dara Navaei

DIALIN-DEN-16390_Heat Chemical Disinfect Timers Fails TO Change Under Correct Conditions
DIALIN-DEN-16390_Heat Chemical Disinfect Timers Fails TO Change Under Correct Conditions
8:48 am

Dara Navaei

Merge branch 'DEN-16390-heat-chemical-disinfect-timers-fails-to-change-under-correct-conditions' into develop

Options
8:47 am

Dara Navaei

DEN-16390 initialized the chem disinfect count down time

Options
    • -0
    • +2
    /dialin/dg/chemical_disinfect.py
Wednesday 06 Sep 2023
7:59 am

Dara Navaei

Bamboo Commit: generated the code change report

Options
    • -2
    • +2
    /tools/Code_Report.csv
7:57 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /dialin/common/alarm_defs.py
    • -1
    • +1
    /dialin/hd/ui_proxy.py
7:44 am

Michael Garthwaite

7:44 am

Michael Garthwaite

Merge branch 'DEN-16242-pressure-limit-request-fix' into staging

Options
Tuesday 05 Sep 2023
11:45 am

Sean Nash and Tiffany Mejia

11:45 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:02 am

Michael Garthwaite

DEN-16242: added alarm id 47

Options
    • -1
    • +1
    /dialin/common/alarm_defs.py
Friday 01 Sep 2023
5:05 pm

Vinayakam Mani

12:47 pm

Michael Garthwaite

Advantu team was assumed that false meant the proxy command was not accepted. When we proxy messages through dialin using the dialin channels, the receiver ( HD or DG ) will ACK back in the non-pr...

Advantu team was assumed that false meant the proxy command was not accepted.

When we proxy messages through dialin using the dialin channels, the receiver ( HD or DG ) will ACK back in the non-proxied channel. Dialin will only considers received messages over its own set of CAN channels and will timeout due the ACK from the receiver being sent on the non-dialin channel

EX:
Dialin will send Pressure limits change request over 0x400
HD accepts the message and will ACK back over 0x010
HD sends Pressure limits change response over 0x010 ( Dialin is monitoring via callback )

Proxy commands should be changed eventually... depends on how the users are applying them ( if they are expecting and using a return value like an override ). Older iterations of proxy commands do not return anything nor expect a Denali protocol ACK

12:32 pm

Sean Nash

Why is driving this change? And should other proxy commands be changed as well?

Why is driving this change? And should other proxy commands be changed as well?