Activity dialin/

4:13 pm

Vy <vduong@sunriselabs.com>

More
005d496
changed 2 files
DEN-16454-UI-VD-S106_fix_update_test_pt1, DEN-16512-2-dpo-stops-during-treatment-after-reconfirming-dialysate-flow-rate and 69 more DIALIN-DEN-16454-1

DEN-16465: Updated - TestSuites:Integration testing update

Re-add the parameters removed based on CR comment

Remove extra newline

- -1
- +0
/dialin/common/hd_defs.py
- History
- Source
- Diff
/dialin/common/hd_defs.py
- -4
- +4
/dialin/ui/hd_simulator.py
- History
- Source
- Diff
/dialin/ui/hd_simulator.py

4:08 pm

Behrouz NematiPour

good point. Vy will fix it.

good point.
Vy will fix it.

4:07 pm

Michael Garthwaite Ui code is frozen and we cannot change the UI code, so matched with what currently exists in UI. The attempt was to fix the integration tests, and we did not go over all the mess...

Michael Garthwaite
Ui code is frozen and we cannot change the UI code, so matched with what currently exists in UI.
The attempt was to fix the integration tests, and we did not go over all the messages API to fix them.
We can have it done later when have more time.

3:42 pm

Michael Garthwaite

If the UI can ignore the fields, then why does dialin need to match the UI?

3:41 pm

Behrouz NematiPour

UI will ignore the last two values, which is not using it. FW can add extra fields, but for now if UI don't use it or does not have to use it will just ignore.

UI will ignore the last two values, which is not using it.
FW can add extra fields, but for now if UI don't use it or does not have to use it will just ignore.

3:38 pm

Michael Garthwaite

this message structure is in Release FW. What is the UI going to with the incorrect message size?

3:37 pm

Behrouz NematiPour

Michael Garthwaite we needed to match it with UI and since UI code is freeze.

Michael Garthwaite
we needed to match it with UI and since UI code is freeze.

3:35 pm

Michael Garthwaite

More
Re: DIALIN-DEN-16454-1
commented on review

Missing two fields. Current DG FW has MSG_ID_DG_HEATERS_DATA = 0x2C as /// Heaters data structure. typedef struct F32 mainPrimayHeaterDC; ///< Main primary heater DC F32 smallPrimaryHeaterDC; ///...

Missing two fields. Current DG FW has MSG_ID_DG_HEATERS_DATA = 0x2C as

/// Heaters data structure.
typedef struct

F32 mainPrimayHeaterDC; ///< Main primary heater DC
F32 smallPrimaryHeaterDC; ///< Small primary heater DC
F32 trimmerHeaterDC; ///< Trimmer heater DC
F32 primaryTargetTemp; ///< Primary heater target temperature
F32 trimmerTargetTemp; ///< Trimmer heater target temperature
U32 primaryHeaterState; ///< Primary heater state
U32 trimmerHeaterState; ///< Trimmer heater state
F32 primaryEfficiency; ///< Primary heater efficiency
F32 primaryCalcTargetTemp; ///< Primary heater calculated target temperature
F32 trimmerCalcCurrentTemp; ///< Trimmer heater calculated current temperature
U32 trimmerUseLastDC; ///< Trimmer heater use last duty cycle
F32 previsouFlow; ///< Trimmer heater previous flow L/min
U32 controlCounter; ///< Trimmer heater control count

HEATERS_DATA_T;

3:33 pm

msuleiman (deleted user)

More
DIALIN-DEN-16454-1
joined review

3:31 pm

Michael Garthwaite

More
Re: DIALIN-DEN-16454-1
commented on review

These should not be commented out. Current FW builds have MSG_ID_PRESSURE_OCCLUSION_DATA = 0x9 with the following structure. /// Payload record structure for the pressure & occlusions data message...

These should not be commented out. Current FW builds have MSG_ID_PRESSURE_OCCLUSION_DATA = 0x9 with the following structure.

/// Payload record structure for the pressure & occlusions data message.

F32 arterialPressure; ///< Latest arterial pressure (mmHg)
F32 venousPressure; ///< Latest venous pressure (mmHg)
U32 bldPumpOcclusion; ///< Latest BP occlusion (no units)
U32 presLimitState; ///< Current pressure limits state (enum-stabilization or stable)
S32 artMinLimit; ///< Current arterial minimum pressure limit (mmHg)
S32 artMaxLimit; ///< Current arterial maximum pressure limit (mmHg)
S32 venMinLimit; ///< Current venous minimum pressure limit (mmHg)
S32 venMaxLimit; ///< Current venous maximum pressure limit (mmHg)
F32 arterialLongFilterPres; ///< Latest long filtered arterial pressure (mmHg)
F32 venousLongFilterPres; ///< Latest long filtered venous pressure (mmHg)
PRESSURE_OCCLUSION_DATA_T;

3:28 pm

Michael Garthwaite

More
Re: DIALIN-DEN-16454-1
commented on review

Please remove blank line.

1:24 pm

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

msuleiman (deleted user)

plucia (deleted user) and Sean Nash