fwcommon

Clone Tools

Stats

Commits this week: 2
Total Committers: 13
Last Commit: 04 Jun
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 23 Feb 2021
11:29 am

Sean Nash

Merge branch 'DEN-6372-hd-rinseback' into develop

Options
    • -7
    • +11
    /Accel.c
10:36 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:24 am

Sean Nash

Timeout is not in ms. Renamed constant.

Timeout is not in ms. Renamed constant.

10:22 am

Sean Nash

DEN-6372: Converted some #defines to static constants.

Options
    • -7
    • +11
    /Accel.c
Monday 22 Feb 2021
6:42 pm

qnguyen  (deleted user)

Are timeout and countdown in seconds? If so, RECIRC_TIMEOUT_MS might not convert correctly to second.

Are timeout and countdown in seconds? If so, RECIRC_TIMEOUT_MS might not convert correctly to second.

1:32 pm

qnguyen  (deleted user)

1:27 pm

Dara Navaei and Sean Nash

9:54 am

Sean Nash

Do these structures require packing? Separate those that do from those that do not and pack only those that do.

Do these structures require packing? Separate those that do from those that do not and pack only those that do.

9:48 am

Sean Nash

Why is this commented out?

Why is this commented out?

9:47 am

Sean Nash

You can remove the else - no longer needed.

You can remove the else - no longer needed.

9:46 am

Sean Nash

These cases should be in same order as enum. POST tests for drivers/controllers/monitors will need NV Data Mgmt to have already read and validated NV Data so they can get/apply calibration. So shou...

These cases should be in same order as enum.
POST tests for drivers/controllers/monitors will need NV Data Mgmt to have already read and validated NV Data so they can get/apply calibration. So should this POST be executed earlier?

9:41 am

Sean Nash

See comment above on send functions. Consider packaging the 3 U32s in a structure to reduce memcpys.

See comment above on send functions. Consider packaging the 3 U32s in a structure to reduce memcpys.

9:40 am

Sean Nash

Maybe these 3 U32s can be passed as a structure so you don't have to do so many memcpys below?

Maybe these 3 U32s can be passed as a structure so you don't have to do so many memcpys below?

9:36 am

Sean Nash

Why are all of these commented out?

Why are all of these commented out?

9:34 am

Sean Nash

Why are all of these commented out?

Why are all of these commented out?

9:34 am

Sean Nash

Position may be ok. Check dependencies though.

Position may be ok. Check dependencies though.

9:30 am

Sean Nash

Rather than changing this, maybe you could just not define SKIP_POST? The SKIP_POST build flag should skip all POST.

Rather than changing this, maybe you could just not define SKIP_POST? The SKIP_POST build flag should skip all POST.

9:27 am

Sean Nash

Why is this commented out?

Why is this commented out?

9:26 am

Sean Nash

Why commented out?

Why commented out?

9:25 am

Sean Nash

Why did this file change?

Why did this file change?

9:24 am

Sean Nash

We have a lot of available message IDs above. Why are we using them first before creating new msg IDs?

We have a lot of available message IDs above. Why are we using them first before creating new msg IDs?

Friday 19 Feb 2021
5:13 pm

qnguyen  (deleted user)

10:40 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

Sean Nash

Part of tuning of UF control. Load cells are so noisy, control interval seemed too fast at 1 Hz.

Part of tuning of UF control. Load cells are so noisy, control interval seemed too fast at 1 Hz.

10:28 am

pmontazemi  (deleted user)

Why reduced control frequency update?

Why reduced control frequency update?

8:47 am

Dara Navaei

DEN-5980 addressed doxygen comments

Options
    • -117
    • +133
    /NVDataMgmt.c
    • -20
    • +15
    /NVDataMgmt.h
Thursday 18 Feb 2021
6:23 pm

Dara Navaei

DEN-5980 added a state to verify writes to RTC RAM

Options
    • -11
    • +119
    /NVDataMgmt.c
4:07 pm

Dara Navaei

DEN-5980 fixed NVData issues in HD

Options
    • -3
    • +3
    /NVDataMgmt.c
4:01 pm

Dara Navaei

DEN-5980 added usage info

Options
    • -47
    • +48
    /NVDataMgmt.c
    • -2
    • +4
    /NVDataMgmt.h
    • -0
    • +7
    /NVDataMgmtDGRecords.h
    • -0
    • +6
    /NVDataMgmtHDRecords.h