fwcommon

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Timeout is not in ms. Renamed constant.

Timeout is not in ms. Renamed constant.

Are timeout and countdown in seconds? If so, RECIRC_TIMEOUT_MS might not convert correctly to second.

Are timeout and countdown in seconds? If so, RECIRC_TIMEOUT_MS might not convert correctly to second.

Do these structures require packing? Separate those that do from those that do not and pack only those that do.

Do these structures require packing? Separate those that do from those that do not and pack only those that do.

Why is this commented out?

Why is this commented out?

You can remove the else - no longer needed.

You can remove the else - no longer needed.

These cases should be in same order as enum. POST tests for drivers/controllers/monitors will need NV Data Mgmt to have already read and validated NV Data so they can get/apply calibration. So shou...

These cases should be in same order as enum.
POST tests for drivers/controllers/monitors will need NV Data Mgmt to have already read and validated NV Data so they can get/apply calibration. So should this POST be executed earlier?

See comment above on send functions. Consider packaging the 3 U32s in a structure to reduce memcpys.

See comment above on send functions. Consider packaging the 3 U32s in a structure to reduce memcpys.

Maybe these 3 U32s can be passed as a structure so you don't have to do so many memcpys below?

Maybe these 3 U32s can be passed as a structure so you don't have to do so many memcpys below?

Why are all of these commented out?

Why are all of these commented out?

Why are all of these commented out?

Why are all of these commented out?

Position may be ok. Check dependencies though.

Position may be ok. Check dependencies though.

Rather than changing this, maybe you could just not define SKIP_POST? The SKIP_POST build flag should skip all POST.

Rather than changing this, maybe you could just not define SKIP_POST? The SKIP_POST build flag should skip all POST.

Why is this commented out?

Why is this commented out?

Why commented out?

Why commented out?

Why did this file change?

Why did this file change?

We have a lot of available message IDs above. Why are we using them first before creating new msg IDs?

We have a lot of available message IDs above. Why are we using them first before creating new msg IDs?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Part of tuning of UF control. Load cells are so noisy, control interval seemed too fast at 1 Hz.

Part of tuning of UF control. Load cells are so noisy, control interval seemed too fast at 1 Hz.

Why reduced control frequency update?

Why reduced control frequency update?

Stop signal is removed. But other alarm flags still exist so I added call to reset alarm signal flags as you suggested.

Stop signal is removed. But other alarm flags still exist so I added call to reset alarm signal flags as you suggested.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.