fwcommon

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 04 Jun 2021
2:08 pm

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Added safety shutdown to integrity check

Options
    • -0
    • +2
    /Integrity.c
2:08 pm

Sean Nash

I think we should add the new THd temperature sensor now. I know it's currently using TRo connection (and so we don't have a TRo), but we should handle that with build switch (THd reads from TRo ch...

I think we should add the new THd temperature sensor now. I know it's currently using TRo connection (and so we don't have a TRo), but we should handle that with build switch (THd reads from TRo channel and TRo can just be a copy of TDi for now if THD_USING_TRO_CONNECTOR build switch enabled, actual future code where both sensors exist on their own connectors if build switch is disabled).

12:42 pm

Sean Nash

Is this needed. Should we just let Standby mode set actuators as it wants on entry?

Is this needed. Should we just let Standby mode set actuators as it wants on entry?

12:40 pm

Sean Nash

I think we should at least say that the mode variables are reset to re-start the mode or something.

I think we should at least say that the mode variables are reset to re-start the mode or something.

12:37 pm

Sean Nash

Why are some values aligned at left and others at right? I think all values should align at left.

Why are some values aligned at left and others at right? I think all values should align at left.

12:32 pm

Sean Nash

I'm assuming HET was enabled to get access to a GPIO pin? If so, do we need these notifications? Is there a place in HalCOGen to disable HET interrupts?

I'm assuming HET was enabled to get access to a GPIO pin? If so, do we need these notifications? Is there a place in HalCOGen to disable HET interrupts?

12:28 pm

Sean Nash

Not necessary - included in .h file.

Not necessary - included in .h file.

12:26 pm

Sean Nash

Please keep this case in last position in switch statement.

Please keep this case in last position in switch statement.

11:50 am

Sean Nash

Why commented out?

Why commented out?

10:41 am

Sean Nash

Remove comments or add TODO.

Remove comments or add TODO.

10:41 am

Sean Nash

I think we can remove this test code now.

I think we can remove this test code now.

10:31 am

qnguyen  (deleted user)

Should we call setAlarmAudio here? This test is running at 50 ms while the setAlarmAudio is running at 250 ms. The alarm audio might not be set when we switch to else part.

Should we call setAlarmAudio here?
This test is running at 50 ms while the setAlarmAudio is running at 250 ms. The alarm audio might not be set when we switch to else part.

10:19 am

qnguyen  (deleted user)

The flag is latched by using OR with the local updated noNewTreatment status.

The flag is latched by using OR with the local updated noNewTreatment status.

10:15 am

Sean Nash

But now in order to use the status flag, I think we can't allow that flag to go from TRUE to FALSE - need to latch it.

But now in order to use the status flag, I think we can't allow that flag to go from TRUE to FALSE - need to latch it.

Thursday 03 Jun 2021
10:55 am

qnguyen  (deleted user)

Removed this extra flag and used alarm status noNewTreatment flag.

Removed this extra flag and used alarm status noNewTreatment flag.

10:54 am

qnguyen  (deleted user)

Removed this extra flag.

Removed this extra flag.

10:51 am

qnguyen  (deleted user)

Done.

Done.

10:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:27 am

qnguyen  (deleted user)

Yes, and we checked for DG restarted (after it has started by HD) in DGInterface. Sample water sub-mode has to check before DG started.

Yes, and we checked for DG restarted (after it has started by HD) in DGInterface.
Sample water sub-mode has to check before DG started.

9:07 am

Sean Nash

Looks like you are latching the noEndTreatment status. Maybe we can have that status be latching so we don't need two flags.

Looks like you are latching the noEndTreatment status. Maybe we can have that status be latching so we don't need two flags.

9:03 am

Sean Nash

Is this different than alarmStatus.noNewTreatment?

Is this different than alarmStatus.noNewTreatment?

9:01 am

Sean Nash

Shouldn't this be checked more broadly (not just in water sample sub-mode)?

Shouldn't this be checked more broadly (not just in water sample sub-mode)?

Wednesday 02 Jun 2021
8:39 am

Sean Nash

Merge branch 'DEN-7605-hd_dg_dev-self-tests' into develop

Options
    • -0
    • +3
    /RTC.c
Tuesday 01 Jun 2021
6:23 pm

Sean Nash

DEN-7605: Subtract 6 hr offset to UI date/time sync epoch to achieve same UTC date/time in f/w as UI intended.

Options
    • -0
    • +3
    /RTC.c
6:14 pm

Dara Navaei

Merge branch 'DEN-8030-dg-hd_dev-dg-mode-chemical-disinfect' into develop

Options
    • -18
    • +16
    /NVDataMgmt.c
9:52 am

Sean Nash

DEN-8030: Minor fixes to set calibration.

Options
    • -18
    • +16
    /NVDataMgmt.c
Monday 31 May 2021
4:32 pm

Dara Navaei

DEN-8030 updated Common.h

Options
    • -0
    • +1
    /Common.h
Sunday 30 May 2021
2:46 pm

Dara Navaei

DG-DEN-8030_DG-HD DEV Mode Chemical Disinfect
DG-DEN-8030_DG-HD DEV Mode Chemical Disinfect
Saturday 29 May 2021
1:06 am

qnguyen  (deleted user)

Removed.

Removed.