fwcommon

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 25 Feb 2022
6:34 pm

Dara Navaei

DEN-11750 addressed the code review comments

Options
    • -0
    • +2
    /NVDataMgmt.h
    • -0
    • +4
    /NVDataMgmtDGRecords.h
    • -0
    • +4
    /NVDataMgmtHDRecords.h
6:33 pm

Dara Navaei

The variable is initialized in the init().

The variable is initialized in the init().

6:33 pm

Dara Navaei

Yes, if they are initialized in init() which they should be, they don't need to be initialized here. This puts this static variables in the uninitialized section of the memory.

Yes, if they are initialized in init() which they should be, they don't need to be initialized here. This puts this static variables in the uninitialized section of the memory.

6:30 pm

Dara Navaei

This might have been updated in the different Dialin branch.

This might have been updated in the different Dialin branch.

6:29 pm

Dara Navaei

Good catch, thanks.

Good catch, thanks.

6:27 pm

Dara Navaei

The alarm is not commented out currently, this might be due to an old commit.

The alarm is not commented out currently, this might be due to an old commit.

6:25 pm

Dara Navaei

This was commented for testing. I un-commented it.

This was commented for testing. I un-commented it.

6:24 pm

Dara Navaei

You cannot run a function there. Also, the init function is the proper place to initialize the value.

You cannot run a function there. Also, the init function is the proper place to initialize the value.

6:23 pm

Dara Navaei

Yes because the staging is branched form master that is very old. At the end of this code review I will update the master branch of common.

Yes because the staging is branched form master that is very old. At the end of this code review I will update the master branch of common.

6:22 pm

Dara Navaei

Done.

Done.

6:22 pm

Dara Navaei

Done.

Done.

6:16 pm

Dara Navaei

Done.

Done.

6:15 pm

Dara Navaei

Done.

Done.

6:13 pm

Dara Navaei

This macro has been removed.

This macro has been removed.

6:13 pm

Dara Navaei

Done.

Done.

6:12 pm

Dara Navaei

Done.

Done.

2:24 pm

Sean Nash

Looks like this needs to be addressed.

Looks like this needs to be addressed.

11:02 am

Sean Nash

Magic #.

Magic #.

10:58 am

Sean Nash

rpm should be in ().

rpm should be in ().

10:56 am

Sean Nash

Should we check that payloadLength is at least 12 bytes (sizeof(U32) x 3)?

Should we check that payloadLength is at least 12 bytes (sizeof(U32) x 3)?

10:42 am

Sean Nash

There are 2 functions in this module with this name.

There are 2 functions in this module with this name.

8:57 am

Sean Nash

Are these really common? Can they be moved to sys_selftest.c?

Are these really common? Can they be moved to sys_selftest.c?

8:57 am

Dara Navaei

DG-DEN-11928_DG Conductivity Update
DG-DEN-11928_DG Conductivity Update
8:53 am

Sean Nash

Add #ifndef RELEASE around these definitions and all other build switch related code.

Add #ifndef RELEASE around these definitions and all other build switch related code.

8:51 am

Sean Nash

Add #ifndef RELEASE around this structure.

Add #ifndef RELEASE around this structure.

8:51 am

Sean Nash

Add #ifndef RELEASE around this enum.

Add #ifndef RELEASE around this enum.

8:50 am

Sean Nash

Should be #ifndef RELEASE around this structure.

Should be #ifndef RELEASE around this structure.

8:50 am

Sean Nash

I think there should be a #ifndef RELEASE around these build switches.

I think there should be a #ifndef RELEASE around these build switches.

8:46 am

Sean Nash

Dara, I keep seeing this change in every code review - Compatibility.h is deleted and Compatible.h is created. Why do we keep seeing this?

Dara, I keep seeing this change in every code review - Compatibility.h is deleted and Compatible.h is created. Why do we keep seeing this?

Thursday 24 Feb 2022
3:36 pm

Michael Garthwaite

Does this need to be memset when we can initialize it with 0'd values above? (line 92)

Does this need to be memset when we can initialize it with 0'd values above? (line 92)