fwcommon

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 03 Aug 2022
8:12 pm

Dara Navaei

DEN-12931 addressed the code review comments

Options
    • -1
    • +1
    /Common.h
8:10 pm

Dara Navaei

Removed the code.

Removed the code.

8:09 pm

Dara Navaei

Done.

Done.

8:08 pm

Dara Navaei

Done.

Done.

8:07 pm

Dara Navaei

I thought exiting the normal state is the last request we want to check after making sure nothing else is requested.

I thought exiting the normal state is the last request we want to check after making sure nothing else is requested.

8:06 pm

Dara Navaei

Done.

Done.

8:03 pm

Dara Navaei

Blood leak is still in development. This will be addressed in DEN-13460.

Blood leak is still in development. This will be addressed in DEN-13460.

8:02 pm

Dara Navaei

Done.

Done.

7:59 pm

Dara Navaei

We only do that if we do the == comparison. This is to make sure the compiler errors out if only one = is put instead of ==.

We only do that if we do the == comparison. This is to make sure the compiler errors out if only one = is put instead of ==.

7:56 pm

Dara Navaei

Done.

Done.

7:55 pm

Dara Navaei

Done.

Done.

7:48 pm

Dara Navaei

This can be reached in VC since it is not in a for loop.

This can be reached in VC since it is not in a for loop.

7:48 pm

Dara Navaei

This can be reached in VC because it is not in a for loop.

This can be reached in VC because it is not in a for loop.

6:03 pm

Dara Navaei

Merge branch 'DEN-13460-dg_hd_dev-hd_dg_dvt-update-part-2' into develop

Options
11:12 am

Sean Nash

Use explicit condition ( TRUE == resetStateTimer ).

Use explicit condition ( TRUE == resetStateTimer ).

11:11 am

Sean Nash

Use explicit condition ( TRUE == resetStateTimer ).

Use explicit condition ( TRUE == resetStateTimer ).

11:11 am

Sean Nash

Add resetStateTimer @param.

Add resetStateTimer @param.

11:07 am

Sean Nash

Why commented out? Remove if no longer needed. If coming back, use explicit condition ( TRUE == resetStateTimer ).

Why commented out? Remove if no longer needed. If coming back, use explicit condition ( TRUE == resetStateTimer ).

11:07 am

Sean Nash

Use explicit condition ( TRUE == resetStateTimer ).

Use explicit condition ( TRUE == resetStateTimer ).

11:06 am

Sean Nash

Add resetStateTimer @param.

Add resetStateTimer @param.

11:06 am

Sean Nash

I don't see resetStateTimer being used (unless commented out code is coming back). Also, it is not in function header.

I don't see resetStateTimer being used (unless commented out code is coming back). Also, it is not in function header.

11:04 am

Sean Nash

Why commented out? Remove if no longer needed.

Why commented out? Remove if no longer needed.

11:03 am

Sean Nash

Separate assignments or at least put all in same line.

Separate assignments or at least put all in same line.

11:02 am

Sean Nash

Separate assignments or at least put all in same line.

Separate assignments or at least put all in same line.

11:02 am

Sean Nash

Separate assignments or at least put all in same line.

Separate assignments or at least put all in same line.

11:02 am

Sean Nash

Separate assignments or at least put all in same line.

Separate assignments or at least put all in same line.

11:01 am

Sean Nash

Separate assignments or at least put all in same line.

Separate assignments or at least put all in same line.

10:58 am

Sean Nash

Use explicit condition ( TRUE == resetStateTimer ).

Use explicit condition ( TRUE == resetStateTimer ).

10:56 am

Sean Nash

This looks like it allows flows > maximum now. What is the intent here?

This looks like it allows flows > maximum now. What is the intent here?

10:55 am

Sean Nash

This looks like it allows flows > maximum now. What is the intent here?

This looks like it allows flows > maximum now. What is the intent here?