fwcommon

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Removed the code.

Removed the code.

Done.

Done.

Done.

Done.

I thought exiting the normal state is the last request we want to check after making sure nothing else is requested.

I thought exiting the normal state is the last request we want to check after making sure nothing else is requested.

Done.

Done.

Blood leak is still in development. This will be addressed in DEN-13460.

Blood leak is still in development. This will be addressed in DEN-13460.

Done.

Done.

We only do that if we do the == comparison. This is to make sure the compiler errors out if only one = is put instead of ==.

We only do that if we do the == comparison. This is to make sure the compiler errors out if only one = is put instead of ==.

Done.

Done.

Done.

Done.

This can be reached in VC since it is not in a for loop.

This can be reached in VC since it is not in a for loop.

This can be reached in VC because it is not in a for loop.

This can be reached in VC because it is not in a for loop.

Use explicit condition ( TRUE == resetStateTimer ).

Use explicit condition ( TRUE == resetStateTimer ).

Use explicit condition ( TRUE == resetStateTimer ).

Use explicit condition ( TRUE == resetStateTimer ).

Add resetStateTimer @param.

Add resetStateTimer @param.

Why commented out? Remove if no longer needed. If coming back, use explicit condition ( TRUE == resetStateTimer ).

Why commented out? Remove if no longer needed. If coming back, use explicit condition ( TRUE == resetStateTimer ).

Use explicit condition ( TRUE == resetStateTimer ).

Use explicit condition ( TRUE == resetStateTimer ).

Add resetStateTimer @param.

Add resetStateTimer @param.

I don't see resetStateTimer being used (unless commented out code is coming back). Also, it is not in function header.

I don't see resetStateTimer being used (unless commented out code is coming back). Also, it is not in function header.

Why commented out? Remove if no longer needed.

Why commented out? Remove if no longer needed.

Separate assignments or at least put all in same line.

Separate assignments or at least put all in same line.

Separate assignments or at least put all in same line.

Separate assignments or at least put all in same line.

Separate assignments or at least put all in same line.

Separate assignments or at least put all in same line.

Separate assignments or at least put all in same line.

Separate assignments or at least put all in same line.

Separate assignments or at least put all in same line.

Separate assignments or at least put all in same line.

Use explicit condition ( TRUE == resetStateTimer ).

Use explicit condition ( TRUE == resetStateTimer ).

This looks like it allows flows > maximum now. What is the intent here?

This looks like it allows flows > maximum now. What is the intent here?

This looks like it allows flows > maximum now. What is the intent here?

This looks like it allows flows > maximum now. What is the intent here?

This looks like it allows flows > maximum now. What is the intent here?

This looks like it allows flows > maximum now. What is the intent here?

Why removed?

Why removed?