fwcommon

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 11 May 2023
2:15 pm

Dara Navaei

Merge branch 'staging' into DEN-15246-active-reservoir-empty-post-concentrate-alarm-recovery

Options
2:15 pm

Dara Navaei

DEN-15246 updated the conductivity sensors calibration table

Options
    • -1
    • +1
    /NVDataMgmt.c
    • -1
    • +0
    /NVDataMgmtDGRecords.h
2:13 pm

Dara Navaei

Done

Done

2:12 pm

Dara Navaei

Is this a big risk? At this time I am not too concerned about it. If you think it should be addressed, I can make changes.

Is this a big risk? At this time I am not too concerned about it. If you think it should be addressed, I can make changes.

1:57 pm

Dara Navaei

Done

Done

1:56 pm

Dara Navaei

Done

Done

1:54 pm

Dara Navaei

This is 105.

This is 105.

11:45 am

Dara Navaei

DEN-15274 added HD test configurations

Options
    • -0
    • +2
    /TestSupport.h
Tuesday 09 May 2023
4:02 pm

Dara Navaei

DG-DEN-15274_HD DG Test Configuration Setup
DG-DEN-15274_HD DG Test Configuration Setup
3:24 pm

Dara Navaei

DEN-15274 renamed the DG test configurations

Options
    • -2
    • +2
    /TestSupport.h
1:54 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /NVDataMgmtHDRecords.h
    • -1
    • +1
    /TestSupport.c
    • -1
    • +1
    /TestSupport.h
1:37 pm

Dara Navaei

1:36 pm

Dara Navaei

Merged DEN-15199

Options
11:21 am

wbracken  (deleted user) and Sean Nash

10:40 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:39 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:40 am

Dara Navaei

Done

Done

9:38 am

Dara Navaei

Done

Done

8:25 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:21 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Monday 08 May 2023
4:00 pm

Dara Navaei

Merge branch 'DEN-15199-fw_dn_sprint_95-part-2' into develop

Options
3:58 pm

Dara Navaei

This was updated but not pushed.

This was updated but not pushed.

3:55 pm

Dara Navaei

This was a mistake. I fixed it.

This was a mistake. I fixed it.

2:51 pm

Dara Navaei

Merge branch 'staging' into DEN-15199-fw_dn_sprint_95-part-2

Options
11:09 am

Dara Navaei

DEN-15199 addressed the code review comments

Options
    • -1
    • +0
    /TestSupport.c
    • -3
    • +3
    /TestSupport.h
9:06 am

Sean Nash

Is this needed? Why would a worn cartridge fail pressure test?

Is this needed? Why would a worn cartridge fail pressure test?

9:03 am

Sean Nash

Why isn't this just an else? And if else should be swapped so normal action (alarm) comes first with if and the else should be the exception (else).

Why isn't this just an else? And if else should be swapped so normal action (alarm) comes first with if and the else should be the exception (else).

9:02 am

Sean Nash

I don't think a worn cartridge should fail here (should still be dry). I think only wet cartridge should be checked here.

I don't think a worn cartridge should fail here (should still be dry). I think only wet cartridge should be checked here.

8:58 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:52 am

Sean Nash

Recommend being more direct in naming: TEST_CONFIG_USE_WET_CARTRIDGE TEST_CONFIG_USE_WORN_CARTRIDGE

Recommend being more direct in naming:
TEST_CONFIG_USE_WET_CARTRIDGE
TEST_CONFIG_USE_WORN_CARTRIDGE