fwcommon

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Done

Done

Is this a big risk? At this time I am not too concerned about it. If you think it should be addressed, I can make changes.

Is this a big risk? At this time I am not too concerned about it. If you think it should be addressed, I can make changes.

Done

Done

Done

Done

This is 105.

This is 105.

DG-DEN-15274_HD DG Test Configuration Setup
DG-DEN-15274_HD DG Test Configuration Setup
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

Done

Done

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

This was updated but not pushed.

This was updated but not pushed.

This was a mistake. I fixed it.

This was a mistake. I fixed it.

Is this needed? Why would a worn cartridge fail pressure test?

Is this needed? Why would a worn cartridge fail pressure test?

Why isn't this just an else? And if else should be swapped so normal action (alarm) comes first with if and the else should be the exception (else).

Why isn't this just an else? And if else should be swapped so normal action (alarm) comes first with if and the else should be the exception (else).

I don't think a worn cartridge should fail here (should still be dry). I think only wet cartridge should be checked here.

I don't think a worn cartridge should fail here (should still be dry). I think only wet cartridge should be checked here.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Recommend being more direct in naming: TEST_CONFIG_USE_WET_CARTRIDGE TEST_CONFIG_USE_WORN_CARTRIDGE

Recommend being more direct in naming:
TEST_CONFIG_USE_WET_CARTRIDGE
TEST_CONFIG_USE_WORN_CARTRIDGE

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Please see changes.

Please see changes.

Done

Done

This looks like 104.

This looks like 104.

Probably not needed, but for good measure can we do this in transition to GenIdle mode too?

Probably not needed, but for good measure can we do this in transition to GenIdle mode too?

Add blank line before return statement.

Add blank line before return statement.

This function could, in theory, be used to assign a CD2 cal table to CPo (for example).

This function could, in theory, be used to assign a CD2 cal table to CPo (for example).

Is #if temporary?

Is #if temporary?