fwcommon

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Yes this is still used in the deliver state. I changed the names in the #defines

Yes this is still used in the deliver state. I changed the names in the #defines

Is this 5% definition still used? I don't think these are technically percentages (i.e. we do not mean 0.2%, we mean 20%).

Is this 5% definition still used?
I don't think these are technically percentages (i.e. we do not mean 0.2%, we mean 20%).

DG-DEN-16674_Td2 Calibration Feature
DG-DEN-16674_Td2 Calibration Feature
DG-DEN-16499_FW Message List Testing Issues 2
DG-DEN-16499_FW Message List Testing Issues 2
HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Fixed the code.

Fixed the code.

This looks wrong.

This looks wrong.

DG-DEN-16499_FW Message List Testing Issues
DG-DEN-16499_FW Message List Testing Issues
Is bootloader going to use fwcommon code? Is #ifdef #else backwards?

Is bootloader going to use fwcommon code? Is #ifdef #else backwards?

Needed?

Needed?

This is not user code. Next regen will restore this code. Do we really need to disable ECC test code?

This is not user code. Next regen will restore this code. Do we really need to disable ECC test code?

This is not user code. Next regen will restore this code. Do we really need to remove this code?

This is not user code. Next regen will restore this code. Do we really need to remove this code?

What is this code doing? Why no comments? Is it necessary?

What is this code doing? Why no comments? Is it necessary?

#if 1 and #endif appear to be unnecessary. Remove.

#if 1 and #endif appear to be unnecessary. Remove.

Remove duplicate user code start comment.

Remove duplicate user code start comment.

This is not user code. Next regen will restore this code. Do we really need to disable ECC error handling?

This is not user code. Next regen will restore this code. Do we really need to disable ECC error handling?

This is not user code. Next regen will restore this code. Do we really need to disable this?

This is not user code. Next regen will restore this code. Do we really need to disable this?

Why one handler for 3 commands?

Why one handler for 3 commands?

Why aren't we calling the specific handlers for reboot and enter bootloader commands?

Why aren't we calling the specific handlers for reboot and enter bootloader commands?