fwcommon

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DG-DEN-17220_Release 20 P1B Staging
DG-DEN-17220_Release 20 P1B Staging
RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Updated the trigger condition. This is a calibration and is checked in POST. The titles are POST.

Updated the trigger condition. This is a calibration and is checked in POST. The titles are POST.

The Trigger condition is little confusing. could you please reword it? Also In title, do you want to add " fault", if it is DG fault property?

The Trigger condition is little confusing. could you please reword it? Also In title, do you want to add " fault", if it is DG fault property?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Removed the typecast.

Removed the typecast.

Are these castings of (POLYNOMIAL_CAL_PAYLOAD_T*) necessary? Seems like &concPump->concentratePumps[ i ] is already that type.

Are these castings of (POLYNOMIAL_CAL_PAYLOAD_T*) necessary? Seems like &concPump->concentratePumps[ i ] is already that type.

DG-DEN-17135_Concentrate Pump Calibration Staging
DG-DEN-17135_Concentrate Pump Calibration Staging
DG Staging Unreviewed Commits
DG Staging Unreviewed Commits
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Can we get by with just 1 msg? Add doxygen comments.

Can we get by with just 1 msg? Add doxygen comments.

we need to take care of existing stack size while we merge the bootloader changes. the current stack size is 0x3400, not 0x4C00.

we need to take care of existing stack size while we merge the bootloader changes. the current stack size is 0x3400, not 0x4C00.

HD-DEN-16856_Disable Chemical Disinfection BY Default
HD-DEN-16856_Disable Chemical Disinfection BY Default
RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

Done

Done

Do we need to say in the comment "chemical disinfect is disabled by default in institutional record"?

Do we need to say in the comment "chemical disinfect is disabled by default in institutional record"?

HD-DEN-16856_Disable Chemical Disinfection BY Default
HD-DEN-16856_Disable Chemical Disinfection BY Default