NVDataMgmtDGRecords.h

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DG-DEN-17220_Release 20 P1B Staging
DG-DEN-17220_Release 20 P1B Staging
RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Updated the trigger condition. This is a calibration and is checked in POST. The titles are POST.

Updated the trigger condition. This is a calibration and is checked in POST. The titles are POST.

The Trigger condition is little confusing. could you please reword it? Also In title, do you want to add " fault", if it is DG fault property?

The Trigger condition is little confusing. could you please reword it? Also In title, do you want to add " fault", if it is DG fault property?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Removed the typecast.

Removed the typecast.

Are these castings of (POLYNOMIAL_CAL_PAYLOAD_T*) necessary? Seems like &concPump->concentratePumps[ i ] is already that type.

Are these castings of (POLYNOMIAL_CAL_PAYLOAD_T*) necessary? Seems like &concPump->concentratePumps[ i ] is already that type.

DG-DEN-17135_Concentrate Pump Calibration Staging
DG-DEN-17135_Concentrate Pump Calibration Staging
DG Staging Unreviewed Commits
DG Staging Unreviewed Commits
RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Done

Done

Can we bring a parenthesis for better readability?

Can we bring a parenthesis for better readability?

DG-DEN-16674_Td2 Calibration Feature
DG-DEN-16674_Td2 Calibration Feature
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

But this comment also asked that you remove the transition to fill mode here and add it to the fill mode function called above. It's still here.

But this comment also asked that you remove the transition to fill mode here and add it to the fill mode function called above. It's still here.

No I will check the Dialin check in the function like the rest of the commands from Dialin.

No I will check the Dialin check in the function like the rest of the commands from Dialin.

I don't see change. Did you push?

I don't see change. Did you push?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.