Activity hdfirmware/

4:07 pm

Peman Montazemi <pmontazemi@diality.com>

More
356b6e3
changed 2 files
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 358 more HD-DEN-7395-1

DEN-7395: Addressed code review comments

- -3
- +3
/firmware/App/Controllers/BloodLeak.c
- History
- Source
- Diff
/firmware/App/Controllers/BloodLeak.c
- -1
- +1
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c

4:06 pm

pmontazemi (deleted user)

More
Re: HD-DEN-7395-1
replied to qnguyen (deleted user)

Addressed.

4:03 pm

pmontazemi (deleted user)

More
Re: HD-DEN-7395-1
replied to qnguyen (deleted user)

Addressed.

3:49 pm

qnguyen (deleted user)

More
Re: HD-DEN-7395-1
commented on review

This should be compare to SELF_TEST_STATUS_PASSED now.

3:47 pm

qnguyen (deleted user)

More
Re: HD-DEN-7395-1
commented on review

Recommend adding _MS to the end to indicate the metric in milliseconds.

3:26 pm

Peman Montazemi <pmontazemi@diality.com>

More
75ca74e
changed 1 file
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 358 more HD-DEN-7395-1

DEN-7395: Addressed header needed change based on code review comment

- -1
- +2
/firmware/App/Controllers/BloodLeak.c
- History
- Source
- Diff
/firmware/App/Controllers/BloodLeak.c

3:25 pm

pmontazemi (deleted user)

More
Re: HD-DEN-7395-1
replied to Sean Nash

Addressed.

3:19 pm

Peman Montazemi <pmontazemi@diality.com>

More
47eb930
changed 3 files
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 358 more HD-DEN-7395-1

DEN-7395: Addressed code review comments

- -23
- +49
/firmware/App/Controllers/BloodLeak.c
- History
- Source
- Diff
/firmware/App/Controllers/BloodLeak.c
- -1
- +1
/firmware/App/Controllers/BloodLeak.h
- History
- Source
- Diff
/firmware/App/Controllers/BloodLeak.h
- -4
- +4
/firmware/App/Services/FPGA.c
- History
- Source
- Diff
/firmware/App/Services/FPGA.c

3:18 pm

pmontazemi (deleted user)

More
Re: HD-DEN-7395-1
replied to Sean Nash

Addressed.

3:17 pm

pmontazemi (deleted user)

More
Re: HD-DEN-7395-1
replied to Sean Nash

Addressed.

3:16 pm

pmontazemi (deleted user)

More
Re: HD-DEN-7395-1
replied to Sean Nash

Addressed.

3:16 pm

pmontazemi (deleted user)

More
Re: HD-DEN-7395-1
replied to Sean Nash

Addressed.

3:14 pm

pmontazemi (deleted user)

More
Re: HD-DEN-7395-1
replied to Sean Nash

Addressed.

3:03 pm

pmontazemi (deleted user)

More
Re: HD-DEN-7395-1
replied to Sean Nash

Addressed.

3:03 pm

pmontazemi (deleted user)

More
Re: HD-DEN-7395-1
replied to Dara Navaei

Addressed.

2:59 pm

pmontazemi (deleted user)

More
Re: HD-DEN-7395-1
replied to qnguyen (deleted user)

No action item.

2:58 pm

pmontazemi (deleted user)

More
Re: HD-DEN-7395-1
replied to Sean Nash

Addressed.

2:58 pm

pmontazemi (deleted user)

More
Re: HD-DEN-7395-1
replied to Sean Nash

Addressed.

2:57 pm

pmontazemi (deleted user)

More
Re: HD-DEN-7395-1
replied to Sean Nash

Addressed.

4:03 pm

Sean Nash

More
f3326a3
changed 6 files
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 355 more HD-DEN-7605-2

DEN-7605: More updates to internal ADC channels per X03 schematic. Check 24V cutoff and backup alarm audio during watchdog test.

- -14
- +63
/firmware/App/Drivers/InternalADC.c
- History
- Source
- Diff
/firmware/App/Drivers/InternalADC.c
- -8
- +22
/firmware/App/Drivers/InternalADC.h
- History
- Source
- Diff
/firmware/App/Drivers/InternalADC.h
- -2
- +2
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h
- -2
- +17
/firmware/App/Services/WatchdogMgmt.c
- History
- Source
- Diff
/firmware/App/Services/WatchdogMgmt.c
- -17
- +17
/firmware/HD.dil
- History
- Source
- Diff
/firmware/HD.dil
- -13
- +13
/firmware/source/adc.c
- History
- Source
- Diff
/firmware/source/adc.c

3:03 pm

pmontazemi (deleted user)

More
Re: HD-DEN-7395-1
replied to Dara Navaei

Addressed.

2:59 pm

pmontazemi (deleted user)

More
Re: HD-DEN-7395-1
replied to Sean Nash

No action item.

2:54 pm

pmontazemi (deleted user)

More
Re: HD-DEN-7395-1
replied to Dara Navaei

Addressed.

2:07 pm

Sean Nash

More
5745d7d
changed 6 files
develop_1-61

Added new ADC channels. Will add to DEN-7605.

- -13
- +13
/firmware/App/Drivers/InternalADC.c
- History
- Source
- Diff
/firmware/App/Drivers/InternalADC.c
- -8
- +21
/firmware/App/Drivers/InternalADC.h
- History
- Source
- Diff
/firmware/App/Drivers/InternalADC.h
- -2
- +2
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h
- -1
- +4
/firmware/App/Services/WatchdogMgmt.c
- History
- Source
- Diff
/firmware/App/Services/WatchdogMgmt.c
- -17
- +17
/firmware/HD.dil
- History
- Source
- Diff
/firmware/HD.dil
- -13
- +13
/firmware/source/adc.c
- History
- Source
- Diff
/firmware/source/adc.c

11:11 am

Sean Nash

More
d5b2240
changed 2 files
develop_1-61

Fixed merge conflicts.

- -2
- +2
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h
- -1
- +1
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

11:10 am

Sean Nash

More
340ca37
changed 3 files
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 355 more HD-DEN-7605-2 HD-DEN-8103-1 HD-DEN-8030-1

DEN-7605: Added sub-modes to HD standby mode.

- -3
- +3
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h
- -0
- +1
/firmware/App/Modes/ModePreTreat.c
- History
- Source
- Diff
/firmware/App/Modes/ModePreTreat.c
- -11
- +93
/firmware/App/Modes/ModeStandby.c
- History
- Source
- Diff
/firmware/App/Modes/ModeStandby.c

2:33 pm

Sean Nash

More
6dcc3d9
changed 3 files
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 355 more HD-UCOMMITS-19

DEN-7605: Fixed typo.

- -4
- +4
/firmware/App/Services/AlarmMgmt.c
- History
- Source
- Diff
/firmware/App/Services/AlarmMgmt.c
- -1
- +1
/firmware/App/Services/AlarmMgmt.h
- History
- Source
- Diff
/firmware/App/Services/AlarmMgmt.h
- -1
- +1
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

10:07 am

qnguyen (deleted user)

More
Re: HD-DEN-7395-1
replied to Dara Navaei

The clearAlarmCondition() function will check if the alarm is active or not and only clears if the alarm has been raised.

8:57 am

Dara Navaei

More
Re: HD-DEN-7395-1
commented on review

Typecasting the variables is not needed here. The macro typecasts them.

8:52 am

Sean Nash

More
Re: HD-DEN-7395-1
commented on review

Should probably go to normal state on fail as well - otherwise you get stuck here in self-test state.

hdfirmware

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Peman Montazemi <pmontazemi@diality.com>

pmontazemi (deleted user)

pmontazemi (deleted user)

qnguyen (deleted user)

qnguyen (deleted user)

Peman Montazemi <pmontazemi@diality.com>

pmontazemi (deleted user)

Peman Montazemi <pmontazemi@diality.com>

pmontazemi (deleted user)

pmontazemi (deleted user)

pmontazemi (deleted user)

pmontazemi (deleted user)

pmontazemi (deleted user)

pmontazemi (deleted user)

pmontazemi (deleted user)

pmontazemi (deleted user)

pmontazemi (deleted user)

pmontazemi (deleted user)

pmontazemi (deleted user)

Sean Nash

pmontazemi (deleted user)

pmontazemi (deleted user)

pmontazemi (deleted user)

Sean Nash

Sean Nash

Sean Nash

Sean Nash

qnguyen (deleted user)

Dara Navaei

Sean Nash