hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 05 May 2021
7:26 pm

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Cleaned up TODO and added alarms

Options
    • -4
    • +4
    /firmware/App/Controllers/DGInterface.c
    • -0
    • +1
    /firmware/App/Modes/ConsumableSelfTest.c
    • -1
    • +0
    /firmware/App/Modes/ModeInitPOST.c
    • -2
    • +1
    /firmware/App/Modes/ModePostTreat.c
    • -1
    • +0
    /firmware/App/Modes/ModePreTreat.c
    • -3
    • +2
    /firmware/App/Modes/ModeStandby.c
    • -1
    • +1
    /firmware/App/Modes/OperationModes.c
    • -2
    • +1
    /firmware/App/Modes/PreTreatmentRecirc.c
    • -2
    • +1
    /firmware/App/Modes/Prime.c
    • -1
    • +0
    /firmware/App/Modes/Prime.h
    • -1
    • +1
    /firmware/App/Modes/SampleWater.c
    • -1
    • +1
    /firmware/App/Modes/SampleWater.h
    • -6
    • +3
    /firmware/App/Modes/SelfTests.c
    • -1
    • +2
    /firmware/App/Modes/TreatmentEnd.c
    • -1
    • +1
    /firmware/App/Services/AlarmMgmt.c
  16. … 3 more files in changeset.
6:31 pm

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Converted blood pump alarms to use persistent alarm

Options
    • -154
    • +74
    /firmware/App/Controllers/BloodFlow.c
3:47 pm

Sean Nash

DEN-7605: Added FPGA read timeout checks/alarms for blood/dialysate flow.

Options
    • -13
    • +53
    /firmware/App/Controllers/BloodFlow.c
    • -2
    • +43
    /firmware/App/Controllers/DialInFlow.c
    • -8
    • +112
    /firmware/App/Services/FPGA.c
    • -2
    • +10
    /firmware/App/Services/FPGA.h
1:37 pm

Sean Nash

Fixed merge conflicts.

Options
    • -4
    • +9
    /firmware/App/Controllers/DialInFlow.c
    • -18
    • +77
    /firmware/App/Controllers/PresOccl.c
    • -0
    • +16
    /firmware/App/Services/SystemComm.c
    • -0
    • +128
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +12
    /firmware/App/Services/SystemCommMessages.h
1:35 pm

Sean Nash

DEN-7605: Added FPGA pressure sensor checks and alarms.

Options
    • -17
    • +76
    /firmware/App/Controllers/PresOccl.c
    • -1
    • +111
    /firmware/App/Services/FPGA.c
    • -0
    • +8
    /firmware/App/Services/FPGA.h
9:20 am

Sean Nash

DEN-7605: Updated peristaltic pump speed over PWM DC range for V3.

Options
    • -5
    • +10
    /firmware/App/Controllers/BloodFlow.c
    • -4
    • +9
    /firmware/App/Controllers/DialInFlow.c
    • -4
    • +9
    /firmware/App/Controllers/DialOutFlow.c
Tuesday 04 May 2021
5:22 pm

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Updated fpga comm time out alarm name

Options
    • -1
    • +1
    /firmware/App/Services/FPGA.c
4:14 pm

Sean Nash

DEN-7605: Added FPGA reported comm error to FPGA comm error check. Fixed persistent alarm periods in syringe pump module.

Options
    • -1
    • +1
    /firmware/App/Controllers/BloodFlow.c
    • -1
    • +1
    /firmware/App/Controllers/DialInFlow.c
    • -1
    • +1
    /firmware/App/Controllers/PresOccl.c
    • -5
    • +5
    /firmware/App/Controllers/SyringePump.c
    • -2
    • +2
    /firmware/App/Services/FPGA.c
10:38 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:31 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Monday 03 May 2021
5:21 pm

Sean Nash

DEN-7605: Added more published data and overrides to syringe pump module.

Options
    • -19
    • +288
    /firmware/App/Controllers/SyringePump.c
    • -0
    • +9
    /firmware/App/Controllers/SyringePump.h
    • -1
    • +1
    /firmware/App/Services/AlarmMgmt.c
    • -0
    • +16
    /firmware/App/Services/SystemComm.c
    • -0
    • +128
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +12
    /firmware/App/Services/SystemCommMessages.h
4:47 pm

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Added check for i2c nack and arbitration lost

Options
    • -45
    • +121
    /firmware/App/Drivers/Battery.c
11:55 am

Sean Nash

DEN-7605: Addressed more code review comments.

Options
    • -12
    • +80
    /firmware/App/Services/AlarmMgmt.c
11:40 am

Sean Nash

Fixed.

Fixed.

11:38 am

Sean Nash

Fixed.

Fixed.

11:37 am

Sean Nash

Copy and paste error. Fixed.

Copy and paste error. Fixed.

11:03 am

Sean Nash

DEN-7605: Addressed code review feedback.

Options
    • -85
    • +39
    /firmware/App/Controllers/SyringePump.c
    • -5
    • +5
    /firmware/App/Controllers/Voltages.c
10:47 am

qnguyen  (deleted user)

Same as above.

Same as above.

10:46 am

qnguyen  (deleted user)

Why do we need to subtract from MAX_ALARM_VOLUME_LEVEL?

Why do we need to subtract from MAX_ALARM_VOLUME_LEVEL?

10:44 am

qnguyen  (deleted user)

These functions need doxygen description.

These functions need doxygen description.

10:26 am

Sean Nash

I agree, but sometimes feel it helps readability.

I agree, but sometimes feel it helps readability.

10:25 am

Sean Nash

Yes, you are right. I will use fwcommon code.

Yes, you are right. I will use fwcommon code.