hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 07 Jun 2021
9:34 am

Sean Nash

DEN-7605: pass alarm audio test until test properly implemented.

Options
    • -7
    • +9
    /firmware/App/Services/AlarmMgmt.c
    • -1
    • +1
    /firmware/App/Services/FPGA.c
    • -2
    • +2
    /firmware/App/Services/SystemCommMessages.c
9:27 am

Sean Nash

Good point. Test will need to be longer than 50ms anyway - FPGA ramps the sound and there is a ~250ms time constant in the electronics. But I will want the sound to at least get started immediately.

Good point. Test will need to be longer than 50ms anyway - FPGA ramps the sound and there is a ~250ms time constant in the electronics. But I will want the sound to at least get started immediately.

Friday 04 Jun 2021
12:53 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
12:52 pm

Sean Nash

Merge branch 'develop' of ssh://dvm-linux02:7999/hd/hdfirmware into develop

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
12:52 pm

Sean Nash

Disabled pump checks.

Options
    • -5
    • +5
    /firmware/App/HDCommon.h
    • -2
    • +3
    /firmware/App/Modes/ModeInitPOST.c
    • -1
    • +1
    /firmware/App/Services/FPGA.c
12:44 pm

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Updated alarm check script to include error line

Options
    • -2
    • +6
    /firmware/checkAlarms.sh
10:31 am

qnguyen  (deleted user)

Should we call setAlarmAudio here? This test is running at 50 ms while the setAlarmAudio is running at 250 ms. The alarm audio might not be set when we switch to else part.

Should we call setAlarmAudio here?
This test is running at 50 ms while the setAlarmAudio is running at 250 ms. The alarm audio might not be set when we switch to else part.

10:19 am

qnguyen  (deleted user)

The flag is latched by using OR with the local updated noNewTreatment status.

The flag is latched by using OR with the local updated noNewTreatment status.

10:15 am

Sean Nash

But now in order to use the status flag, I think we can't allow that flag to go from TRUE to FALSE - need to latch it.

But now in order to use the status flag, I think we can't allow that flag to go from TRUE to FALSE - need to latch it.

Thursday 03 Jun 2021
6:06 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
6:05 pm

Sean Nash

Fixed build flags.

Options
    • -2
    • +2
    /firmware/App/HDCommon.h
    • -2
    • +2
    /firmware/App/Services/SystemCommMessages.c
10:55 am

qnguyen  (deleted user)

Removed this extra flag and used alarm status noNewTreatment flag.

Removed this extra flag and used alarm status noNewTreatment flag.

10:54 am

qnguyen  (deleted user)

Removed this extra flag.

Removed this extra flag.

10:52 am

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Addressed code review

Options
    • -1
    • +1
    /firmware/App/Modes/ModeStandby.c
    • -15
    • +7
    /firmware/App/Services/AlarmMgmt.c
    • -1
    • +1
    /firmware/App/Services/AlarmMgmt.h
10:51 am

qnguyen  (deleted user)

Done.

Done.

10:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:27 am

qnguyen  (deleted user)

Yes, and we checked for DG restarted (after it has started by HD) in DGInterface. Sample water sub-mode has to check before DG started.

Yes, and we checked for DG restarted (after it has started by HD) in DGInterface.
Sample water sub-mode has to check before DG started.

9:57 am

Sean Nash

Merge branch 'DEN-7605-hd_dg_dev-self-tests' into develop

Options
    • -0
    • +5
    /firmware/App/Modes/ModeInitPOST.c
    • -1
    • +1
    /firmware/App/Modes/TreatmentEnd.c
    • -5
    • +57
    /firmware/App/Services/AlarmMgmt.c
    • -1
    • +2
    /firmware/App/Services/AlarmMgmt.h
    • -10
    • +12
    /firmware/App/Services/FPGA.c
    • -1
    • +1
    /firmware/App/Services/FPGA.h
9:55 am

Sean Nash

DEN-7605: Added POST test for alarm audio.

Options
    • -6
    • +11
    /firmware/App/Modes/ModeInitPOST.c
    • -1
    • +1
    /firmware/App/Modes/TreatmentEnd.c
    • -1
    • +1
    /firmware/App/Modes/TreatmentStop.c
    • -5
    • +57
    /firmware/App/Services/AlarmMgmt.c
    • -1
    • +2
    /firmware/App/Services/AlarmMgmt.h
    • -10
    • +12
    /firmware/App/Services/FPGA.c
    • -1
    • +1
    /firmware/App/Services/FPGA.h
9:07 am

Sean Nash

Looks like you are latching the noEndTreatment status. Maybe we can have that status be latching so we don't need two flags.

Looks like you are latching the noEndTreatment status. Maybe we can have that status be latching so we don't need two flags.

9:03 am

Sean Nash

Is this different than alarmStatus.noNewTreatment?

Is this different than alarmStatus.noNewTreatment?

9:01 am

Sean Nash

Shouldn't this be checked more broadly (not just in water sample sub-mode)?

Shouldn't this be checked more broadly (not just in water sample sub-mode)?

12:07 am

Quang Nguyen <qnguyen@diality.com>

DEN-8679: Implemented system comm msg for treatment log msgs

Options
    • -1
    • +34
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +3
    /firmware/App/Services/SystemCommMessages.h
Wednesday 02 Jun 2021
4:23 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
4:23 pm

Dara Navaei

Disabled CAL_CHECK build switch'

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
11:09 am

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
11:09 am

Sean Nash

Merge branch 'develop' of ssh://dvm-linux02:7999/hd/hdfirmware into develop

Options
11:09 am

Sean Nash

Moved FPGA POST to last test.

Options
    • -6
    • +6
    /firmware/App/Modes/ModeInitPOST.c
Tuesday 01 Jun 2021
5:52 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h