hdfirmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-9054 removed the FPGA power check

Why was this moved?

Why was this moved?

The message parameter is not used or needed in this function.

The message parameter is not used or needed in this function.

Can we move these 2 lines of code down where the other ADC channels are being read and converted?

Can we move these 2 lines of code down where the other ADC channels are being read and converted?

Do we need a debounce on the switch before changing state?

Do we need a debounce on the switch before changing state?

Caps?

Caps?

Should initialize the other elements of the override structure too. Most importantly, the override flag should be off.

Should initialize the other elements of the override structure too. Most importantly, the override flag should be off.

DEN-9054 added a check for the switch IDs

    • -3
    • +11
    /firmware/App/Controllers/Switches.c
DEN-9054 addressed the code review comments

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

Added additional functions.

Added additional functions.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-8679: Addressed code review

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

Done.

Done.

DEN-8679: Addressed code review

It is both in develop branch and staging branch for fwcommon.

It is both in develop branch and staging branch for fwcommon.

DEN-9054 updated the build history log