hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Why was this moved?

Why was this moved?

The message parameter is not used or needed in this function.

The message parameter is not used or needed in this function.

Can we move these 2 lines of code down where the other ADC channels are being read and converted?

Can we move these 2 lines of code down where the other ADC channels are being read and converted?

Do we need a debounce on the switch before changing state?

Do we need a debounce on the switch before changing state?

Caps?

Caps?

Should initialize the other elements of the override structure too. Most importantly, the override flag should be off.

Should initialize the other elements of the override structure too. Most importantly, the override flag should be off.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

RESOLVED in CODE WALKTRHOUGH.

Added additional functions.

Added additional functions.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

Done.

Done.

It is both in develop branch and staging branch for fwcommon.

It is both in develop branch and staging branch for fwcommon.

First sizeof() should have U32 (same as above).

First sizeof() should have U32 (same as above).

The first sizeof() has ALARM_ID_T. You converted that param to a U32 (which is appropriate) and so you should have U32 in that sizeof().

The first sizeof() has ALARM_ID_T. You converted that param to a U32 (which is appropriate) and so you should have U32 in that sizeof().

I think the data are floats, so 0 should be 0.0.

I think the data are floats, so 0 should be 0.0.

Sent events only for changed settings.

Sent events only for changed settings.

Set UF volume initially to 0 and removed this variable and related function.

Set UF volume initially to 0 and removed this variable and related function.