hdfirmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'DEN-9906-hd_dev-flow-measurement-changes' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-9906-hd_dev-flow-measurement-changes

    • -0
    • +2
    /firmware/App/Controllers/DialInFlow.c
DEN-9906 Implemented DG dialysate flow sensor

    • -5
    • +9
    /firmware/App/Controllers/DialInFlow.c
DEN-9906: Fixed disable pump direction checks build switch.

    • -0
    • +2
    /firmware/App/Controllers/DialInFlow.c
DEN-9906: Added test code to calculate and report measured UF rate based on change in UF volume.

    • -0
    • +14
    /firmware/App/Controllers/DialOutFlow.c
DEN-9906: Removed obsolete blood flow code.

DEN-9906 Fixed merge conflict

    • -124
    • +1
    /firmware/App/Controllers/DGInterface.c
    • -42
    • +1
    /firmware/App/Controllers/DGInterface.h
    • -21
    • +7
    /firmware/App/Services/SystemComm.c
DEN-9906 Implement HD dialysate flow sensor

    • -0
    • +32
    /firmware/App/Controllers/DGInterface.c
    • -2
    • +10
    /firmware/App/Controllers/DGInterface.h
DEN-9906: Added overrides for blood pump rotor count and arterial pressure offset. Removed unused handling of DG data and related functions/variables. Fixed DEN-10973.

    • -335
    • +31
    /firmware/App/Controllers/BloodFlow.c
    • -123
    • +0
    /firmware/App/Controllers/DGInterface.c
    • -41
    • +0
    /firmware/App/Controllers/DGInterface.h
    • -3
    • +49
    /firmware/App/Controllers/PresOccl.c
    • -20
    • +6
    /firmware/App/Services/SystemComm.c
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

DEN-9906: Addressed code review comments.

    • -0
    • +16
    /firmware/App/Controllers/Switches.c
    • -1
    • +16
    /firmware/App/Controllers/Switches.h
    • -1
    • +16
    /firmware/App/Controllers/Temperatures.c
    • -0
    • +16
    /firmware/App/Controllers/Temperatures.h
Fixed.

Fixed.

Fixed.

Fixed.

If using a "==" comparison operator, I like to put the literal first so that the compiler will error if I accidentally use "=" instead. Otherwise, I like to put the literal last because it reads be...

If using a "==" comparison operator, I like to put the literal first so that the compiler will error if I accidentally use "=" instead.
Otherwise, I like to put the literal last because it reads better.

I was thinking 150 was perhaps too fast for UI. But you're right - that only seems to be true at startup. I'll put back to 150.

I was thinking 150 was perhaps too fast for UI. But you're right - that only seems to be true at startup. I'll put back to 150.