hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-11114 addressed the code review comments

    • -17
    • +7
    /firmware/App/Controllers/BloodLeak.c
    • -5
    • +5
    /firmware/App/Controllers/DGInterface.h
Done.

Done.

Done.

Done.

Done.

Done.

Yes, see #ifdef SKIP_PRIMING currentPrimeState = HD_PRIME_RESERVOIR_ONE_FILL_COMPLETE_STATE; #else currentPrimeState = HD_PRIME_WAIT_FOR_USER_START_STATE; #endif

Yes, see
#ifdef SKIP_PRIMING
currentPrimeState = HD_PRIME_RESERVOIR_ONE_FILL_COMPLETE_STATE;
#else
currentPrimeState = HD_PRIME_WAIT_FOR_USER_START_STATE;
#endif

Use () for the multiplication part.

Use () for the multiplication part.

To make sure the order of math operations are correct, we should have () around the items that are multiplied and then divide it to the treatment duration.

To make sure the order of math operations are correct, we should have () around the items that are multiplied and then divide it to the treatment duration.

DEN-11114: Fixed alarm data broadcast structure issue.

Merge branch 'DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2

DEN-11114: Fixed bug DEN-11663.

    • -1
    • +1
    /firmware/App/Controllers/DialInFlow.c
DEN-11114 addressed the code review comments

    • -6
    • +21
    /firmware/App/Controllers/BloodLeak.c
    • -3
    • +3
    /firmware/App/Controllers/DGInterface.c
    • -9
    • +9
    /firmware/App/Controllers/DGInterface.h
DEN-11098 Addressed code review comments

Dara, did you add this alarm?

Dara, did you add this alarm?

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

No I do not think so. The CRCs are all checked in the self test.

No I do not think so. The CRCs are all checked in the self test.

Done.

Done.

Yes, if you add "alarm no alarm" it will not be checked.

Yes, if you add "alarm no alarm" it will not be checked.

Done.

Done.

Magic numbers on these new for loops.

Magic numbers on these new for loops.

Align comment.

Align comment.

Done.

Done.

Fixed it.

Fixed it.

Done.

Done.

Done.

Done.

Done.

Done.