Activity hdfirmware/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Tuesday 01 Feb 2022

3:52 pm

Hung Nguyen <hnguyen@diality.com>

More
ba62e6b
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11250-hd-syringe-pump-updates and 338 more HD-DEN-11250-1

DEN-11250 Updated per peer review comments

- -2
- +1
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c

3:19 pm

hnguyen (deleted user)

More
Re: HD-DEN-11250-1
replied to Sean Nash

Done. Called checkForPrimeOcclusion(); with no parameters.

Done. Called checkForPrimeOcclusion(); with no parameters.

2:21 pm

hnguyen (deleted user)

More
Re: HD-DEN-11250-1
replied to Sean Nash

Line 489 F32 bolusVol = getTreatmentParameterF32() was moved. it is no longer here.

Line 489 F32 bolusVol = getTreatmentParameterF32() was moved. it is no longer here.

2:15 pm

Hung Nguyen <hnguyen@diality.com>

More
0621f9c
changed 2 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11250-hd-syringe-pump-updates and 338 more HD-DEN-11250-1

DEN-11250 Fixed compile errors

- -0
- +1
/firmware/App/Modes/ModeInitPOST.c
- History
- Source
- Diff
/firmware/App/Modes/ModeInitPOST.c
- -0
- +1
/firmware/source/sys_startup.c
- History
- Source
- Diff
/firmware/source/sys_startup.c

2:08 pm

Hung Nguyen <hnguyen@diality.com>

More
67adcef
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11250-hd-syringe-pump-updates and 338 more HD-DEN-11250-1

DEN-11250 Updated handPOSTStateStart with same function from DEN-11750 branch

- -5
- +6
/firmware/App/Modes/ModeInitPOST.c
- History
- Source
- Diff
/firmware/App/Modes/ModeInitPOST.c

2:00 pm

Hung Nguyen <hnguyen@diality.com>

More
9a82438
changed 3 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11250-hd-syringe-pump-updates and 338 more HD-DEN-11250-1

DEN-11250 Updated per peer review comments

- -2
- +2
/firmware/App/Controllers/SyringePump.c
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.c
- -1
- +1
/firmware/App/Controllers/SyringePump.h
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.h
- -7
- +18
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c

1:54 pm

hnguyen (deleted user)

More
Re: HD-DEN-11250-1
replied to Sean Nash

Updated handlePOSTStateStart( ) function with the handlePOSTStateStart( ) used in DEN-11750.

Updated handlePOSTStateStart( ) function with the handlePOSTStateStart( ) used in DEN-11750.

1:49 pm

hnguyen (deleted user)

More
Re: HD-DEN-11250-1
replied to Sean Nash

Changed function prototype from BOOL checkForPrimeOcclusion( BOOL stopPump ) to BOOL checkForPrimeOcclusion( void );

Changed function prototype from BOOL checkForPrimeOcclusion( BOOL stopPump ) to BOOL checkForPrimeOcclusion( void );

1:38 pm

hnguyen (deleted user)

More
Re: HD-DEN-11250-1
replied to Sean Nash

We don't need this here. startHeparinBolus() was moved to handleWetSeltTestStartState(void) function. F32 bolusVol = getTreatmentParameterF32( TREATMENT_PARAM_HEPARIN_BOLUS_VOLUME ); setDialInPum...

We don't need this here. startHeparinBolus() was moved to handleWetSeltTestStartState(void) function.

F32 bolusVol = getTreatmentParameterF32( TREATMENT_PARAM_HEPARIN_BOLUS_VOLUME );

setDialInPumpTargetFlowRate( DIP_FLOW_RATE_SETUP_ML_MIN, MOTOR_DIR_FORWARD, PUMP_CONTROL_MODE_OPEN_LOOP );
fmdIntegratedVolume = 0.0;

if ( ( bolusVol > 0.0 ) && ( getSyringePumpVolumeDelivered() < bolusVol ) )

Unknown macro: { startHeparinBolus(); // moved here from startHeparinPump() in Dialysis.c }

1:32 pm

Dara Navaei

More
24e3289
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 336 more HD-UCOMMITS-19

DEN-11750 made changes for the reservoir test

- -1
- +1
/firmware/App/Services/Reservoirs.c
- History
- Source
- Diff
/firmware/App/Services/Reservoirs.c

1:27 pm

Sean Nash

More
Re: HD-DEN-11250-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:27 pm

Sean Nash

More
Re: HD-DEN-11250-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:26 pm

Sean Nash

More
Re: HD-DEN-11250-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:26 pm

Sean Nash

More
Re: HD-DEN-11250-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:25 pm

Sean Nash

More
Re: HD-DEN-11250-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:25 pm

Sean Nash

More
Re: HD-DEN-11250-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:24 pm

Sean Nash

More
Re: HD-DEN-11250-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:24 pm

Sean Nash

More
Re: HD-DEN-11250-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:24 pm

Sean Nash

More
Re: HD-DEN-11250-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:23 pm

Sean Nash

More
Re: HD-DEN-11250-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:22 pm

Sean Nash

More
Re: HD-DEN-11250-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:22 pm

Sean Nash

More
Re: HD-DEN-11250-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:21 pm

Sean Nash

More
Re: HD-DEN-11250-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:18 pm

Sean Nash

More
Re: HD-DEN-11250-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:18 pm

Sean Nash

More
Re: HD-DEN-11250-1
replied to hnguyen (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:33 am

Hung Nguyen <hnguyen@diality.com>

More
d57c55e
changed 2 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11250-hd-syringe-pump-updates and 338 more HD-DEN-11250-1

DEN-11250 Changed checkOcclusionOr Empty() to checkSyringeEmpty()

- -22
- +14
/firmware/App/Controllers/SyringePump.c
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.c
- -2
- +3
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c

11:32 am

Sean Nash

More
Re: HD-DEN-11250-1
commented on review

No parameter needed in this function.

No parameter needed in this function.

11:31 am

Dara Navaei

More
d00a07a
changed 1 file
demo_branch, develop and 2 more

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

11:31 am

Dara Navaei

More
28719a0
changed 1 file
demo_branch, develop and 2 more

Disabled prime

- -6
- +6
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

11:30 am

Sean Nash

More
Re: HD-DEN-11250-1
commented on review

Not sure why we need stopPump flag - can't we just call the check function w/ no parameters?

Not sure why we need stopPump flag - can't we just call the check function w/ no parameters?

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-03-25 19:57 -0700