hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up' into develop

    • -4
    • +10
    /firmware/App/Controllers/BloodFlow.c
    • -7
    • +19
    /firmware/App/Controllers/DialInFlow.c
    • -6
    • +16
    /firmware/App/Controllers/DialOutFlow.c
    • -15
    • +29
    /firmware/App/Controllers/PresOccl.c
    • -8
    • +31
    /firmware/App/Modes/ModeTreatment.c
DEN-11750 updated HDCommon.h

DEN-11750 updated the software configurations

    • -4
    • +10
    /firmware/App/Controllers/BloodFlow.c
    • -7
    • +19
    /firmware/App/Controllers/DialInFlow.c
    • -6
    • +16
    /firmware/App/Controllers/DialOutFlow.c
    • -15
    • +29
    /firmware/App/Controllers/PresOccl.c
    • -8
    • +31
    /firmware/App/Modes/ModeTreatment.c
Please see comment below regarding the changes in common from this code review.

Please see comment below regarding the changes in common from this code review.

Dara and I have found out that this code review for common is misconfigured. The source and destination branches are misconfigured. The branch to review should have been from DEN-11980_sw_dev_sprin...

Dara and I have found out that this code review for common is misconfigured. The source and destination branches are misconfigured. The branch to review should have been from DEN-11980_sw_dev_sprint_64 and the "branch from" should have been from staging. This code review has staging as the branch to review with master as the "branch review."

DEN-11250 Installed case MSG_ID_HD_FAN_RPM_ALARM_START_TIME_OFFSET_OVERRIDE per peer review comments

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Renamed to testSendCurrentTreatmentParameters(). thanks!

Renamed to testSendCurrentTreatmentParameters(). thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Updates and fixes per code review.

    • -57
    • +58
    /firmware/App/Modes/ModeTreatmentParams.c
    • -1
    • +1
    /firmware/App/Modes/ModeTreatmentParams.h
Reinstalled the case statement back to where it was. case MSG_ID_HD_FAN_RPM_ALARM_START_TIME_OFFSET_OVERRIDE: handleTestFansRPMAlarmStartTimeOffsetOverrideRequest( message );

Reinstalled the case statement back to where it was.
case MSG_ID_HD_FAN_RPM_ALARM_START_TIME_OFFSET_OVERRIDE:
handleTestFansRPMAlarmStartTimeOffsetOverrideRequest( message );

Fixed. Thanks!

Fixed. Thanks!

Function name is misleading. Sounds like Dialin is sending us new parameters, but it is only requesting current params be sent. I would change to something like testSendCurrentTreatmentParameters().

Function name is misleading. Sounds like Dialin is sending us new parameters, but it is only requesting current params be sent. I would change to something like testSendCurrentTreatmentParameters().

Check that Dialin has logged in before acting on a Dialin request (TRUE == isTestingActivated()).

Check that Dialin has logged in before acting on a Dialin request (TRUE == isTestingActivated()).

Add a blank line between declarations and code.

Add a blank line between declarations and code.

Check editor settings. Tabs should be set to 4 spaces.

Check editor settings. Tabs should be set to 4 spaces.

Remove blank lines.

Remove blank lines.

Remove blank line.

Remove blank line.

Remove blank line.

Remove blank line.

I believe this was caused from us branching out of master to have develop & staging branches for common. I will review this as this was not expected.

I believe this was caused from us branching out of master to have develop & staging branches for common. I will review this as this was not expected.

Add one more blank line here.

Add one more blank line here.

Remove extra blank lines.

Remove extra blank lines.

Remove extra blank line.

Remove extra blank line.

Why does it look like you added this table when I know it was there before?

Why does it look like you added this table when I know it was there before?