hdfirmware

Clone Tools

Stats

Commits this week: 13
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 13

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 22 Mar 2022
2:16 pm

Dara Navaei

DEN-12215 addressed the code review comment

Options
    • -3
    • +3
    /firmware/App/Modes/ConsumableSelfTest.c
2:15 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:13 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:12 pm

Dara Navaei

DEN-12224 updated the code

Options
    • -1
    • +1
    /firmware/App/Controllers/Temperatures.c
2:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:10 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:07 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:04 pm

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:04 pm

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:00 pm

Dara Navaei

Done.

Done.

1:49 pm

Hung Nguyen <hnguyen@diality.com>

DEN11250 Added code to allow resume after syringe pump occlusion has been removed - moved here from commit 1bb17047684 in DEN-11250 branch

Options
    • -3
    • +7
    /firmware/App/Modes/SelfTests.c
1:44 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11250 Fixed syringe pump occlusion alarm not triggered - moved commit 269329748ff from DEN-11250 to here

Options
    • -4
    • +1
    /firmware/App/Controllers/SyringePump.c
1:30 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Addressed peer review comments

Options
    • -5
    • +0
    /firmware/App/Modes/ModeStandby.c
    • -1
    • +0
    /firmware/App/Services/AlarmMgmt.c
    • -1
    • +0
    /firmware/App/Services/SystemCommMessages.c
1:29 pm

hnguyen  (deleted user)

Removed // if ( TRUE == getNoNewTreatmentStatus() ) //{ // rejReason = REQUEST_REJECT_REASON_NO_NEW_TREATMENT_ALARM_TRIGGERED; // }

Removed
// if ( TRUE == getNoNewTreatmentStatus() )
//

Unknown macro: { // rejReason = REQUEST_REJECT_REASON_NO_NEW_TREATMENT_ALARM_TRIGGERED; // }
1:28 pm

hnguyen  (deleted user)

Removed line // payload.alarmsFlags |= ( almStatus.noNewTreatment ? BIT_BY_POS(ALARM_STATE_FLAG_BIT_POS_NO_NEW_TREATMENT) : 0 );

Removed line // payload.alarmsFlags |= ( almStatus.noNewTreatment ? BIT_BY_POS(ALARM_STATE_FLAG_BIT_POS_NO_NEW_TREATMENT) : 0 );

1:27 pm

hnguyen  (deleted user)

Removed line //noNewTreatment = ( TRUE == ALARM_TABLE[ a ].alarmNoNewTreatment ? TRUE : noNewTreatment );

Removed line //noNewTreatment = ( TRUE == ALARM_TABLE[ a ].alarmNoNewTreatment ? TRUE : noNewTreatment );

1:18 pm

Sean Nash

Just delete this line of code.

Just delete this line of code.

1:17 pm

Sean Nash

Just delete this line of code.

Just delete this line of code.

1:17 pm

Sean Nash

Just delete this code.

Just delete this code.

1:14 pm

Sean Nash

It looks like staging branch has things the way it was too.

It looks like staging branch has things the way it was too.

1:04 pm

Sean Nash

Should be since last service (not last treatment).

Should be since last service (not last treatment).

10:43 am

dcox  (deleted user)

This was part of the merge from staging branch.

This was part of the merge from staging branch.

Monday 21 Mar 2022
4:14 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Fixed compile errors

Options
    • -4
    • +4
    /firmware/App/Modes/ModeStandby.c
    • -1
    • +1
    /firmware/App/Services/AlarmMgmt.c
    • -2
    • +2
    /firmware/App/Services/SystemCommMessages.c
2:54 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Merged commit 2df3175ad36 to DEN-11928 branch

Options
    • -2
    • +2
    /firmware/App/Modes/ModePostTreat.c
    • -6
    • +6
    /firmware/App/Services/AlarmMgmt.c
    • -1
    • +1
    /firmware/App/Services/AlarmMgmt.h
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.c
Thursday 17 Mar 2022
2:47 pm

Dara Navaei

DEN-12224 updated the standbymode states

Options
    • -30
    • +31
    /firmware/App/Modes/ModeStandby.c
1:28 pm

Sean Nash

What is the reason for these changes? Just reading the code, it makes more sense to me that way it was.

What is the reason for these changes? Just reading the code, it makes more sense to me that way it was.

12:53 pm

Darren Cox <darren_m@cox.net>

staging branch merge to resolve compiler errors from common header files.

Options
    • -2
    • +2
    /firmware/App/Modes/ConsumableSelfTest.c
    • -3
    • +2
    /firmware/App/Modes/SelfTests.c
    • -4
    • +3
    /firmware/App/Services/SystemCommMessages.c
12:34 pm

Darren Cox <darren_m@cox.net>

DEN-10974 Fix Syringe Removed Alarm.

Options
    • -1
    • +1
    /firmware/App/Modes/ModePreTreat.c
11:17 am

Dara Navaei

DEN_12224 merged CodeClinic's changes and resolved the merge conflicts

Options
    • -14
    • +15
    /firmware/App/Controllers/AirTrap.c
10:53 am

Dara Navaei

DEN-12224 updated the standby mode

Options
    • -51
    • +211
    /firmware/App/Modes/ModeStandby.c