Activity hdfirmware/

3:07 pm

Dara Navaei

More
37a9fd8
changed 44 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11928-dg-conductivity-update and 333 more HD-DEN-12224-16 HD-DEN-11928-2 HD-UCOMMITS-19

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/firmware/App/Controllers/AirTrap.c
- History
- Source
- Diff
/firmware/App/Controllers/AirTrap.c
- -2
- +2
/firmware/App/Controllers/BloodFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/BloodFlow.c
- -2
- +2
/firmware/App/Controllers/BloodFlow.h
- History
- Source
- Diff
/firmware/App/Controllers/BloodFlow.h
- -2
- +2
/firmware/App/Controllers/BloodLeak.c
- History
- Source
- Diff
/firmware/App/Controllers/BloodLeak.c
- -2
- +2
/firmware/App/Controllers/Bubble.c
- History
- Source
- Diff
/firmware/App/Controllers/Bubble.c
- -2
- +2
/firmware/App/Controllers/DGInterface.c
- History
- Source
- Diff
/firmware/App/Controllers/DGInterface.c
- -2
- +2
/firmware/App/Controllers/DialInFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/DialInFlow.c
- -2
- +2
/firmware/App/Controllers/DialInFlow.h
- History
- Source
- Diff
/firmware/App/Controllers/DialInFlow.h
- -2
- +2
/firmware/App/Controllers/DialOutFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/DialOutFlow.c
- -2
- +2
/firmware/App/Controllers/DialOutFlow.h
- History
- Source
- Diff
/firmware/App/Controllers/DialOutFlow.h
- -2
- +2
/firmware/App/Controllers/Fans.c
- History
- Source
- Diff
/firmware/App/Controllers/Fans.c
- -2
- +2
/firmware/App/Controllers/Fans.h
- History
- Source
- Diff
/firmware/App/Controllers/Fans.h
- -2
- +2
/firmware/App/Controllers/FluidLeak.c
- History
- Source
- Diff
/firmware/App/Controllers/FluidLeak.c
- -2
- +2
/firmware/App/Controllers/PresOccl.c
- History
- Source
- Diff
/firmware/App/Controllers/PresOccl.c
- -2
- +2
/firmware/App/Controllers/PresOccl.h
- History
- Source
- Diff
/firmware/App/Controllers/PresOccl.h
… 29 more files in changeset.

3:05 pm

Michael Garthwaite and Dara Navaei

More
HD-DEN-12215-2
finished reviewing

2:46 pm

Sean Nash

More
Re: HD-DEN-12215-2
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

2:44 pm

Darren Cox <darren_m@cox.net>

More
0f0863c
changed 0 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11928-dg-conductivity-update and 334 more

Merge branch 'DEN-12215-sw_dev_sprint_65_darren' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-12215-sw_dev_sprint_65_darren

2:44 pm

Darren Cox <darren_m@cox.net>

More
fc3e2b1
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11928-dg-conductivity-update and 334 more HD-DEN-12215-2

DEN-10974 Remove Door check in Post Treat confirm cartride removed state. Not required.

- -18
- +11
/firmware/App/Modes/ModePostTreat.c
- History
- Source
- Diff
/firmware/App/Modes/ModePostTreat.c

2:22 pm

Sean Nash

More
Re: HD-DEN-12215-2
replied to dcox (deleted user)

RESOLVED in CODE WALKTHROUGH.

2:21 pm

Sean Nash

More
Re: HD-DEN-12215-2
replied to dcox (deleted user)

RESOLVED in CODE WALKTHROUGH.

2:19 pm

Sean Nash

More
Re: HD-DEN-12215-2
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

2:18 pm

Sean Nash

More
Re: HD-DEN-12215-2
replied to dcox (deleted user)

RESOLVED in CODE WALKTHROUGH.

2:16 pm

Dara Navaei

More
5981b64
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11928-dg-conductivity-update and 334 more HD-DEN-12215-2

DEN-12215 addressed the code review comment

- -3
- +3
/firmware/App/Modes/ConsumableSelfTest.c
- History
- Source
- Diff
/firmware/App/Modes/ConsumableSelfTest.c

2:15 pm

Sean Nash

More
Re: HD-DEN-12215-2
replied to dcox (deleted user)

RESOLVED in CODE WALKTHROUGH.

2:13 pm

Sean Nash

More
Re: HD-DEN-12215-2
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

2:12 pm

Dara Navaei

More
688cfa4
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12224-dg_hd_dev-switches-monitor and 330 more HD-DEN-12224-16

DEN-12224 updated the code

- -1
- +1
/firmware/App/Controllers/Temperatures.c
- History
- Source
- Diff
/firmware/App/Controllers/Temperatures.c

2:12 pm

Sean Nash

More
Re: HD-DEN-12215-2
replied to dcox (deleted user)

RESOLVED in CODE WALKTHROUGH.

2:10 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

2:07 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

2:04 pm

Michael Garthwaite

More
Re: HD-DEN-12215-2
replied to dcox (deleted user)

RESOLVED IN CODE WALKTHROUGH.

2:04 pm

Michael Garthwaite

More
Re: HD-DEN-12215-2
replied to dcox (deleted user)

RESOLVED IN CODE WALKTHROUGH.

2:00 pm

Dara Navaei

More
Re: HD-DEN-12215-2
replied to Sean Nash

Done.

1:49 pm

Hung Nguyen <hnguyen@diality.com>

More
1177293
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11928-dg-conductivity-update and 333 more HD-DEN-11928-2

DEN11250 Added code to allow resume after syringe pump occlusion has been removed - moved here from commit 1bb17047684 in DEN-11250 branch

- -3
- +7
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c

1:44 pm

Hung Nguyen <hnguyen@diality.com>

More
ce16d7d
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11928-dg-conductivity-update and 333 more HD-DEN-11928-2

DEN-11250 Fixed syringe pump occlusion alarm not triggered - moved commit 269329748ff from DEN-11250 to here

- -4
- +1
/firmware/App/Controllers/SyringePump.c
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.c

1:30 pm

Hung Nguyen <hnguyen@diality.com>

More
031a5ae
changed 3 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11928-dg-conductivity-update and 333 more HD-DEN-11928-2

DEN-11928 Addressed peer review comments

- -5
- +0
/firmware/App/Modes/ModeStandby.c
- History
- Source
- Diff
/firmware/App/Modes/ModeStandby.c
- -1
- +0
/firmware/App/Services/AlarmMgmt.c
- History
- Source
- Diff
/firmware/App/Services/AlarmMgmt.c
- -1
- +0
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

1:29 pm

hnguyen (deleted user)

More
Re: HD-DEN-11928-2
replied to Sean Nash

Removed // if ( TRUE == getNoNewTreatmentStatus() ) //{ // rejReason = REQUEST_REJECT_REASON_NO_NEW_TREATMENT_ALARM_TRIGGERED; // }

Removed
// if ( TRUE == getNoNewTreatmentStatus() )
//

Unknown macro: { // rejReason = REQUEST_REJECT_REASON_NO_NEW_TREATMENT_ALARM_TRIGGERED; // }

1:28 pm

hnguyen (deleted user)

More
Re: HD-DEN-11928-2
replied to Sean Nash

Removed line // payload.alarmsFlags |= ( almStatus.noNewTreatment ? BIT_BY_POS(ALARM_STATE_FLAG_BIT_POS_NO_NEW_TREATMENT) : 0 );

1:27 pm

hnguyen (deleted user)

More
Re: HD-DEN-11928-2
replied to Sean Nash

Removed line //noNewTreatment = ( TRUE == ALARM_TABLE[ a ].alarmNoNewTreatment ? TRUE : noNewTreatment );

1:18 pm

Sean Nash

More
Re: HD-DEN-11928-2
commented on review

Just delete this line of code.

1:17 pm

Sean Nash

More
Re: HD-DEN-11928-2
commented on review

Just delete this line of code.

1:17 pm

Sean Nash

More
Re: HD-DEN-11928-2
commented on review

Just delete this code.

1:14 pm

Sean Nash

More
Re: HD-DEN-12215-2
replied to dcox (deleted user)

It looks like staging branch has things the way it was too.

1:04 pm

Sean Nash

More
Re: HD-DEN-12215-2
commented on review

Should be since last service (not last treatment).

hdfirmware

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Dara Navaei

Michael Garthwaite and Dara Navaei

Sean Nash

Darren Cox <darren_m@cox.net>

Darren Cox <darren_m@cox.net>

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Dara Navaei

Sean Nash

Sean Nash

Dara Navaei

Sean Nash

Sean Nash

Sean Nash

Michael Garthwaite

Michael Garthwaite

Dara Navaei

Hung Nguyen <hnguyen@diality.com>

Hung Nguyen <hnguyen@diality.com>

Hung Nguyen <hnguyen@diality.com>

hnguyen (deleted user)

hnguyen (deleted user)

hnguyen (deleted user)

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Sean Nash