hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'develop' of ssh://dvm-linux02:7999/hd/hdfirmware into develop

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Turned off simulate UI

If only used for debug, this should be removed. If it is to be activated later, a more verbose comment is needed.

If only used for debug, this should be removed. If it is to be activated later, a more verbose comment is needed.

Uncomment or add a comment explaining why it is inactive.

Uncomment or add a comment explaining why it is inactive.

Using a get function for the flag, but then setting value directly. Should there be a set function? Also applies to several functions below.

Using a get function for the flag, but then setting value directly. Should there be a set function? Also applies to several functions below.

We can get to this but bloodPumpOcclusionAfterCartridgeInstall will be set to 0. Therefore, bpOccl will need to be <= 5500 for the alarm to clear. Im unsure if it would be a problem. We use isAlarm...

We can get to this but bloodPumpOcclusionAfterCartridgeInstall will be set to 0. Therefore, bpOccl will need to be <= 5500 for the alarm to clear. Im unsure if it would be a problem. We use isAlarmTriggered() to clear it only if has been raised previously.

Open to discussion in code walkthrough.

Fixed. Thanks!

Fixed. Thanks!

Understood. Fixed. Thanks!

Understood. Fixed. Thanks!

code review changes

    • -13
    • +5
    /firmware/App/Controllers/PresOccl.c
HD-DEN-13598_DG HD Dev Sprint 77 FW Dong
HD-DEN-13598_DG HD Dev Sprint 77 FW Dong
HD-DEN-13460_DG HD Dev HD DG Dvt Update Part 2
HD-DEN-13460_DG HD Dev HD DG Dvt Update Part 2
I think Darren is referring to a needed space after if (before opening parenthesis)? And not adding blank lines before if statements.

I think Darren is referring to a needed space after if (before opening parenthesis)? And not adding blank lines before if statements.

Still see lines of code like this one that require a space after if (i.e. "if(..." should be "if (...").

Still see lines of code like this one that require a space after if (i.e. "if(..." should be "if (...").

Remove all of these new blank lines.

Remove all of these new blank lines.

HD-DEN-13427_SW Dev Sprint 75 MG
HD-DEN-13427_SW Dev Sprint 75 MG
HD-DEN-13712_DG HD Dev Darren Sprint
HD-DEN-13712_DG HD Dev Darren Sprint
Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Merged DEN-13460

    • -2
    • +4
    /firmware/App/Controllers/SyringePump.c
    • -22
    • +9
    /firmware/App/Services/SystemComm.c
DEN-13427: minor refactor of dry pressure leak self-test changes.

DEN-13460 updated the blood leak sensor driver

    • -18
    • +10
    /firmware/App/Controllers/BloodLeak.c
Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Merge branch 'DEN-13427-sw_dev-sprint-75_mg' into develop

DEN-13427: Addressed issues based on feedback. Changed alarm IDs for pressure sensor setup and formatting.

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Merge branch 'DEN-13427-sw_dev-sprint-75_mg' into develop

DEN-13427: changed pressure sensor test to compare both venous and arterial. Added alarms for when we read pressure readings between -10 and 10mmHg before we start pressure sensor tests.

DEN-13712 Fix treatment time save to look at lastMode on switch to newMode.

DEN-13460 merged staging

    • -2
    • +2
    /firmware/App/Controllers/DialOutFlow.c
    • -103
    • +104
    /firmware/App/Services/SystemCommMessages.c
DEN-13460 updated the blood leak sensor driver and added alarms

    • -15
    • +39
    /firmware/App/Controllers/BloodLeak.c