hdfirmware

Clone Tools

Stats

Commits this week: 8
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 26 Aug 2022
2:16 pm

Michael Garthwaite

Merge branch 'staging' into DEN-12609-sw_dev-sprint-69_mg

Options
    • -3
    • +3
    /firmware/App/Modes/Prime.c
2:14 pm

dcox  (deleted user)

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

2:13 pm

dcox  (deleted user)

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

2:13 pm

dcox  (deleted user)

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

2:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:10 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:08 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:07 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:07 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:07 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:06 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:40 pm

Dong Nguyen <dnguyen@diality.com>

Merge branch 'develop' of ssh://dvm-linux02:7999/hd/hdfirmware into develop

Options
1:30 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
1:29 pm

Dara Navaei

Turned off simulate UI

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
11:58 am

dcox  (deleted user)

If only used for debug, this should be removed. If it is to be activated later, a more verbose comment is needed.

If only used for debug, this should be removed. If it is to be activated later, a more verbose comment is needed.

11:56 am

dcox  (deleted user)

Uncomment or add a comment explaining why it is inactive.

Uncomment or add a comment explaining why it is inactive.

11:55 am

dcox  (deleted user)

Using a get function for the flag, but then setting value directly. Should there be a set function? Also applies to several functions below.

Using a get function for the flag, but then setting value directly. Should there be a set function? Also applies to several functions below.

10:19 am

Michael Garthwaite

We can get to this but bloodPumpOcclusionAfterCartridgeInstall will be set to 0. Therefore, bpOccl will need to be <= 5500 for the alarm to clear. Im unsure if it would be a problem. We use isAlarm...

We can get to this but bloodPumpOcclusionAfterCartridgeInstall will be set to 0. Therefore, bpOccl will need to be <= 5500 for the alarm to clear. Im unsure if it would be a problem. We use isAlarmTriggered() to clear it only if has been raised previously.

Open to discussion in code walkthrough.

10:14 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:13 am

Michael Garthwaite

Understood. Fixed. Thanks!

Understood. Fixed. Thanks!

10:13 am

Michael Garthwaite

code review changes

Options
    • -13
    • +5
    /firmware/App/Controllers/PresOccl.c
Thursday 25 Aug 2022
6:10 pm

Dara Navaei

HD-DEN-13598_DG HD Dev Sprint 77 FW Dong
HD-DEN-13598_DG HD Dev Sprint 77 FW Dong
5:10 pm

Dara Navaei

HD-DEN-13460_DG HD Dev HD DG Dvt Update Part 2
HD-DEN-13460_DG HD Dev HD DG Dvt Update Part 2
4:40 pm

Sean Nash

I think Darren is referring to a needed space after if (before opening parenthesis)? And not adding blank lines before if statements.

I think Darren is referring to a needed space after if (before opening parenthesis)? And not adding blank lines before if statements.

4:37 pm

Sean Nash

Still see lines of code like this one that require a space after if (i.e. "if(..." should be "if (...").

Still see lines of code like this one that require a space after if (i.e. "if(..." should be "if (...").

4:35 pm

Sean Nash

Remove all of these new blank lines.

Remove all of these new blank lines.

4:03 pm

Michael Garthwaite

HD-DEN-13427_SW Dev Sprint 75 MG
HD-DEN-13427_SW Dev Sprint 75 MG
3:57 pm

Dara Navaei

HD-DEN-13712_DG HD Dev Darren Sprint
HD-DEN-13712_DG HD Dev Darren Sprint
3:29 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    /firmware/App/HDCommon.h
3:29 pm

Dara Navaei

Merged DEN-13460

Options
    • -1
    • +2
    /firmware/App/Controllers/BloodLeak.h
    • -2
    • +4
    /firmware/App/Controllers/SyringePump.c
    • -1
    • +1
    /firmware/App/HDCommon.h
    • -2
    • +2
    /firmware/App/Modes/Prime.c
    • -3
    • +2
    /firmware/App/Modes/SelfTests.c
    • -22
    • +9
    /firmware/App/Services/SystemComm.c
    • -31
    • +2
    /firmware/App/Services/SystemCommMessages.c
    • -5
    • +0
    /firmware/App/Services/SystemCommMessages.h